Re: [PATCH v4 1/5] expand-on-first-boot: support resizing a btrfs

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

On Tue, 2022-12-13 at 22:20 +0100, Roberto A. Foglietta wrote:
> On Tue, 13 Dec 2022 at 22:06, Henning Schild <
> henning.schild@siemens.com> wrote:
> > 
> > Am Tue, 13 Dec 2022 21:44:01 +0100
> > schrieb "Roberto A. Foglietta" <roberto.foglietta@gmail.com>:
> > 
> > > On Tue, 13 Dec 2022 at 18:18, Henning Schild
> > > <henning.schild@siemens.com> wrote:
> > > > 
> > > > Am Tue, 13 Dec 2022 17:45:23 +0100
> > > > schrieb "Roberto A. Foglietta" <roberto.foglietta@gmail.com>:
> > > > 
> > > > > On Tue, 13 Dec 2022 at 11:15, <henning.schild@siemens.com>
> > > > > wrote:
> > > > > 
> > > > > > 
> > > > > > +MOUNT_POINT=$(mktemp -d -p "" "$(basename
> > > > > > "$0").XXXXXXXXXX")
> > > > > 
> > > > > this uses /tmp which could not be available
> > > > 
> > > > The remark from Felix triggered the switch from '-p "/mnt"' to
> > > > '-p
> > > > ""', one can set TMPDIR if that does not work.
> > > > 
> > > > A valid remark, while yours seems made up just to keep trolling
> > > > around in the whole discussion. Stop it please.
> > > 
> > > Please Hanning, tell to it to my ubuntu - she has some issue to
> > > understand your slang
> > 
> > My name is "Henning" and yours is not Joe!
> > 
> > > roberto:~$ export TMPDIR=/dev/shm
> > > roberto:~$ mktemp -d -p "" ciao.XXXXX
> > > /dev/shm/ciao.X3wlT
> > > 
> > > Ah, oops - in this following way it working, instead
> > > 
> > > roberto:~$ mktemp -d -p "$TMPDIR" ciao.XXXXX
> > > /dev/shm/ciao.jQFYr
> > 
> > Not sure what i see here but it looks like both temporary
> > directories
> > have been created under TMPDIR with -p "" and with -p "$TMPDIR".
> 
> What Felix tried to tell you was to use a variable like in my patch
> but using TMPDIR as the name of the variable. When that variable is
> not defined then "" is the default value. Now, what happens to mktemp
> when it is called with -p ""? Nothing bad, it simply performs without
> -p. Why was Felix pointing this out? Probably because in my patch tmp
> variable should be set if null but using mktemp this is not necessary
> anymore.

No! Please also stop guessing what I could have meant and wait at least
a day for me to answer (instead of trying to convince others of your
interpretation of my opinion).

The way Henning implemented it is exactly how I meant it.

As this whole thing runs as a systemd service, a user can easily set
TMPDIR via a drop-in file.

Felix

> 
> > 
> > I like the "ciao" since it seems to suggest you are willing to
> > leave
> > it.
> > 
> 
> I have the light sensation that after two and more months needed to
> solve an issue that we solved in 2 days after my intervention in this
> list... ciao is for you.
> 
> > Henning
> > 
> > > Possibly you did not catch the Felix suggestion? LOL
> > > 
> > > Ciao, R-
> >