Re: [PATCH] Avoid sharing of /dev/shm from the build context

[Jan Kiszka <jan.kiszka@siemens.com>]

On 18.03.22 10:13, Baurzhan Ismagulov wrote:
> On Thu, Mar 17, 2022 at 07:05:16PM +0100, Jan Kiszka wrote:
>>> diff --git a/meta/classes/buildchroot.bbclass b/meta/classes/buildchroot.bbclass
>>> index dd8f4206..3b214c6c 100644
>>> --- a/meta/classes/buildchroot.bbclass
>>> +++ b/meta/classes/buildchroot.bbclass
>>> @@ -42,7 +42,8 @@ buildchroot_do_mounts() {
>>>                  mount --bind '${CCACHE_DIR}' '${BUILDCHROOT_DIR}/ccache'
>>>          fi
>>>          mountpoint -q '${BUILDCHROOT_DIR}/dev' ||
>>> -            mount --rbind /dev '${BUILDCHROOT_DIR}/dev'
>>> +            ( mount --rbind /dev '${BUILDCHROOT_DIR}/dev';
>>> +              mount -t tmpfs none '${BUILDCHROOT_DIR}/dev/shm' )
>>>          mount --make-rslave '${BUILDCHROOT_DIR}/dev'
> 
> I'd personally convert that to if because I never remember the failure behavior

You mean && - sure.

> in subshells. While at it, I'd also combine to a single mount -o rbind,rslave
> to avoid potential shared mount windows.
> 
> I think that mounting every directory explicitly (bind instead of rbind)
> provides more control and avoids a bunch of issues with recursive mounts.
> 

Do we know what all needs to be mounted then?

> 
>> Uladzimir, didn't check if this is going to be completely obsoleted by
>> sbuild. If so, this can be ignored, and we will carry it locally until
>> sbuild is merged.
> 
> According to Uladzimir, ATM this is orthogonal and should be applied, we keep
> buildchroot at least for some time, as e.g. wic is using it.
> 

OK.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux