From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 20 Aug 2025 11:36:44 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qt1-f190.google.com (mail-qt1-f190.google.com [209.85.160.190]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 57K9ahG1028702 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 20 Aug 2025 11:36:43 +0200 Received: by mail-qt1-f190.google.com with SMTP id d75a77b69052e-4b109912a9csf275872601cf.0 for ; Wed, 20 Aug 2025 02:36:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1755682598; x=1756287398; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-sender:mime-version :subject:references:in-reply-to:message-id:to:from:date:sender:from :to:cc:subject:date:message-id:reply-to; bh=I7cw8YW4h4bqyX3MRqYGNf8fcvpubwYtXxKJ56fH8Jg=; b=kUUA4q7bki5WwaBVn9ahcEdmywRUFIXrBxS+nLq7w8UT2d4K/y7TcutTQ3uj+w9oV6 /qNB+RzDK5mNDR4j/EqhRYExmfnWPnL35nn/SI+jlm2uAJgj9aWcHYQbdWGJWc95zlZ4 gMGLTSt/DMcMP1vC/PFlw1PAdFc60JCbKjHYV7NqBkeHeIg8tJYRdWDO+zu1X4V80Zv+ 1me60+HRT23k33jsSUyruVUA5hdp/hJ5CQ2SI7HJNCWJ5oMqUttQomwV59Bm2jDwnYFY xu+kFD/leKNkNuudp1SZ9Aef/iwN6X6I+akA79zsTPIyRYMQejo4qIjw81nRtDxNNAwu G4WQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755682598; x=1756287398; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-sender:mime-version :subject:references:in-reply-to:message-id:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=I7cw8YW4h4bqyX3MRqYGNf8fcvpubwYtXxKJ56fH8Jg=; b=AVPxEr2adZg4uaHpDMh63EihzaPWYsv2ZN/MDBcOh6zBUFywJWQ7hsX4NFIN/xrt5F r687bc187aHbAkEYBU69bnZoN5vATxEg0+p3z/bsImnJ0xbVg35GW4yM0l5rzywdSAZc 4p+NJhDXzTBPuwJ5nAAYuD3SdPZt358TCiecwdOjY5vHfPOgqcp9IlOY724wvloHegoE dXd9lze5LglG9cz3wHm+rJAX2oairfA60f3bua1rWve3dQI/8w/aEiFOM66QZVI5PpVw tf3y/l8OecQ8+A6FEguZNTA1FNAEFNFjuhFnmUVNBERmN2D4S8ypUhMa1Ts7Lp2phr3l 5esQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755682598; x=1756287398; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-sender:mime-version:subject:references:in-reply-to :message-id:to:from:date:x-beenthere:x-gm-message-state:sender:from :to:cc:subject:date:message-id:reply-to; bh=I7cw8YW4h4bqyX3MRqYGNf8fcvpubwYtXxKJ56fH8Jg=; b=cKVzO+YTYucTbDu/1eh4u0Glb3fESOQ80n8egZAQ3RlgXD++ykwvCxJZVxc2uMAZo3 K6vlgphOwY7bHcRqzlG0zhimbVs+bW79z0ARg2xI3fFwRzIsvUuG5hD/nDBrNWGHHj2P iY7MKWYE9Jv7zxcYWj1IsBi2xqTQc8OSv161aDNflcdGsUmkI5c2blJJ6lbH83HZEe6z Vd4iQBSxQUTUiCf5C2thCJEIfcHxjrGu/UZbeV5OqAUjr8HMA7aYnSs4UEJdwAq6ZN/5 bRITTGjLqRyqfC82X4T5IxrWFfMTcS0dF+XEzfaqaVGiF7qvH7pnL3OuiT7a1v8zYG4k pbeQ== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=1; AJvYcCVVZSFmsLBRwZ1emJ2RMnwEPd6y2+UxW1UEtgr4zW6lo2cPxsr6UowEJoeg0Ibjpbj48M1z@ilbers.de X-Gm-Message-State: AOJu0YzGemLejFOGXZgFXmdvnxP9vye6TKDI2nbfwpwGvR1kSYKIjDn+ dQswpIECjhFbxeMmDYvj6Yy6ohr6aWxPGSkQKqFFrwl/uevbTTr5LdJO X-Google-Smtp-Source: AGHT+IFmfsJYHAQly7iMFrteK4cKAOTomV6iwD3i8vNILvDBEh1oMVgA0wHfC3p7JJpDy1WeZXq5gQ== X-Received: by 2002:a05:622a:17cc:b0:4b0:8092:9912 with SMTP id d75a77b69052e-4b291a7aa28mr25911091cf.19.1755682597643; Wed, 20 Aug 2025 02:36:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h=AZMbMZcLbrIhmYMBptYF21KkqVAlL0SetQ7CDp3tNKLUecZNoA== Received: by 2002:a05:622a:1488:b0:4ab:8dcf:6968 with SMTP id d75a77b69052e-4b109c99f93ls113953721cf.1.-pod-prod-09-us; Wed, 20 Aug 2025 02:36:36 -0700 (PDT) X-Received: by 2002:a05:620a:170f:b0:7e8:370:ec67 with SMTP id af79cd13be357-7e9fcaf6658mr259121185a.51.1755682596630; Wed, 20 Aug 2025 02:36:36 -0700 (PDT) Date: Wed, 20 Aug 2025 02:36:35 -0700 (PDT) From: Kasturi S To: isar-users Message-Id: In-Reply-To: <20250820092041.41798-2-kasturi.shekar@siemens.com> References: <20250820092041.41798-1-kasturi.shekar@siemens.com> <20250820092041.41798-2-kasturi.shekar@siemens.com> Subject: Re: [PATCH 2/2] deploy-image-wic.sh: fix shellcheck warnings MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_13950_1466221466.1755682595634" X-Original-Sender: kasturishekar29@gmail.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: cYs2wpnnmxDA ------=_Part_13950_1466221466.1755682595634 Content-Type: multipart/alternative; boundary="----=_Part_13951_1870272310.1755682595634" ------=_Part_13951_1870272310.1755682595634 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Please Ignore this, as this is duplicate=20 of https://groups.google.com/g/isar-users/c/RTNpsq5L6m8/ . Thanks, Kasturi On Wednesday, August 20, 2025 at 2:51:05=E2=80=AFPM UTC+5:30 Kasturi Shekar= wrote: > No functional changes, only style and readability fixes > without altering runtime behavior > > Signed-off-by: Kasturi Shekar > --- > .../deploy-image/files/usr/bin/deploy-image-wic.sh | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git=20 > a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic= .sh=20 > b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic= .sh > index fa1061c1..e21da8e2 100755 > ---=20 > a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic= .sh > +++=20 > b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic= .sh > @@ -8,8 +8,7 @@ installdata=3D${INSTALL_DATA:-/install} > > SCRIPT_DIR=3D$( dirname -- "$( readlink -f -- "$0"; )"; ) > > -. ${SCRIPT_DIR}/../lib/deploy-image-wic/handle-config.sh > - > +. "${SCRIPT_DIR}/../lib/deploy-image-wic/handle-config.sh" > > if ! $installer_unattended; then > installer_image_uri=3D$(find "$installdata" -type f -iname "*.wic*" -a -n= ot=20 > -iname "*.wic.bmap" -exec basename {} \;) > @@ -37,7 +36,7 @@ if ! $installer_unattended; then > # inspired by poky/meta/recipes-core/initrdscripts/files/install-efi.sh > target_device_list=3D"" > current_root_dev_type=3D$(findmnt / -o fstype -n) > - if [ ${current_root_dev_type} =3D "nfs" ]; then > + if [ "$current_root_dev_type" =3D "nfs" ]; then > current_root_dev=3D"nfs" > else > current_root_dev=3D$(readlink -f "$(findmnt / -o source -n)") > @@ -108,7 +107,7 @@ if ! $installer_unattended; then > exit 0 > fi > else > - installer_target_dev=3D/dev/$(echo "$target_device_list" | tr -d " ") > + installer_target_dev=3D"/dev/$(echo "$target_device_list" | tr -d " ")" > fi > TARGET_DEVICE_SIZE=3D$(lsblk --nodeps --noheadings -o SIZE=20 > "$installer_target_dev" | tr -d " ") > if ! dialog --yes-label Ok --no-label Cancel \ > @@ -186,11 +185,13 @@ if version_ge "$bmap_version" "3.6"; then > gauge_pid=3D$! > fi > > -if ! bmaptool ${quiet_flag} copy ${bmap_options} "$installer_image_uri"= =20 > "${installer_target_dev}"; then > +if ! bmaptool "$quiet_flag" copy "$bmap_options" "$installer_image_uri"= =20 > "$installer_target_dev"; then > kill "$gauge_pid" > exit 1 > fi > > +# Attempt to terminate the gauge process if still running. > +# Errors are ignored since the process may already have exited. > kill "$gauge_pid" 2>/dev/null > > if ! $installer_unattended; then > --=20 > 2.39.5 > > --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= e7753c1e-76fe-4fa3-8e68-c19c73bc6f63n%40googlegroups.com. ------=_Part_13951_1870272310.1755682595634 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Please Ignore this, as this is duplicate of=C2=A0https://groups.google.com/= g/isar-users/c/RTNpsq5L6m8/ .

Thanks,
Kastur= i

On Wednesday, August 20, 2025 at 2:51:05=E2=80=AFPM UTC+5:30 Kast= uri Shekar wrote:
No functional changes, only style and readability fixes
without altering runtime behavior

Signed-off-by: Kasturi Shekar <kasturi...@siemens.com>
---
.../deploy-image/files/usr/bin/deploy-image-wic.sh | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/dep= loy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/d= eploy-image-wic.sh
index fa1061c1..e21da8e2 100755
--- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-ima= ge-wic.sh
+++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-ima= ge-wic.sh
@@ -8,8 +8,7 @@ installdata=3D${INSTALL_DATA:-/install}
=20
SCRIPT_DIR=3D$( dirname -- "$( readlink -f -- "$0"; )&q= uot;; )
=20
-. ${SCRIPT_DIR}/../lib/deploy-image-wic/handle-config.sh
-
+. "${SCRIPT_DIR}/../lib/deploy-image-wic/handle-config.sh"
=20
if ! $installer_unattended; then
installer_image_uri=3D$(find "$installdata" -type f -ina= me "*.wic*" -a -not -iname "*.wic.bmap" -exec basename = {} \;)
@@ -37,7 +36,7 @@ if ! $installer_unattended; then
# inspired by poky/meta/recipes-core/initrdscripts/files/install-e= fi.sh
target_device_list=3D""
current_root_dev_type=3D$(findmnt / -o fstype -n)
- if [ ${current_root_dev_type} =3D "nfs" ]; then
+ if [ "$current_root_dev_type" =3D "nfs" ]; the= n
current_root_dev=3D"nfs"
else
current_root_dev=3D$(readlink -f "$(findmnt / -o source -= n)")
@@ -108,7 +107,7 @@ if ! $installer_unattended; then
exit 0
fi
else
- installer_target_dev=3D/dev/$(echo "$target_device_list&q= uot; | tr -d " ")
+ installer_target_dev=3D"/dev/$(echo "$target_device_= list" | tr -d " ")"
fi
TARGET_DEVICE_SIZE=3D$(lsblk --nodeps --noheadings -o SIZE "$= installer_target_dev" | tr -d " ")
if ! dialog --yes-label Ok --no-label Cancel \
@@ -186,11 +185,13 @@ if version_ge "$bmap_version" "3.6= "; then
gauge_pid=3D$!
fi
=20
-if ! bmaptool ${quiet_flag} copy ${bmap_options} "$installer_imag= e_uri" "${installer_target_dev}"; then
+if ! bmaptool "$quiet_flag" copy "$bmap_options" &= quot;$installer_image_uri" "$installer_target_dev"; then
kill "$gauge_pid"
exit 1
fi
=20
+# Attempt to terminate the gauge process if still running.
+# Errors are ignored since the process may already have exited.
kill "$gauge_pid" 2>/dev/null
=20
if ! $installer_unattended; then
--=20
2.39.5

--
You received this message because you are subscribed to the Google Groups &= quot;isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-use= rs+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-use= rs/e7753c1e-76fe-4fa3-8e68-c19c73bc6f63n%40googlegroups.com.
------=_Part_13951_1870272310.1755682595634-- ------=_Part_13950_1466221466.1755682595634--