Re: [RFC PATCH 1/1] linux-module: append local files path to FILSPATH

[Claudius Heine <ch@denx.de>]

Hi Vijai,

I looked in the gitlog, and it seems like you last changed this stuff in 
`83bfec59f6e4b104de1acabecd51dd08d2c840d8`:

     Replace FILESPATH with FILESEXTRAPATHS

     The suggested approach to include files & patches from bbappend
     files is FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"

     This is not possible if FILESPATH is modified directly. Use
     FILESEXTRAPATHS instead.

I an not 100% sure I understand you here. but couldn't this be solved by 
using the override syntax on `FILESPATH` instead of `=.`?

regards,
Claudius

On 2023-06-29 15:21, Claudius Heine wrote:
> FILESEXTRAPATHS is meant to allow bbappend files to overwrite files from
> their recipe. For this reason the 'normal' patter in bbappend files is
> to prepend the local file path to FILESEXTRAPATHS, which results in
> files from the local file path to be preferred over files from the
> original recipe, or other, lower prioritized bbappend files.
> 
> The `module.inc` file is meant to be included by other recipes (`.bb`)
> files. So it should still allow the recipe to overwrite files its files
> that where added via the normal recipes `FILESPATH` search path.
> 
> If `module.inc` uses `FILESEXTRAPATHS:prepend` to add its local file
> path to `FILESPATH`, then the recipe, that includes the `module.inc`
> would have to use `FILESEXTRAPATHS:prepend` as well, after including the
> `module.inc` file in order to overwrite the files from the `module.inc`
> file. However this is a workaround of the issue.
> 
> `module.inc` should append its local file search path to `FILESPATH`, so
> that it allows other recipes to overwrite any file from it, without
> requiring an additional workaround.
> 
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
>   meta/recipes-kernel/linux-module/module.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
> index 76ad860..333c66b 100644
> --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -5,7 +5,7 @@
>   #
>   # SPDX-License-Identifier: MIT
>   
> -FILESEXTRAPATHS:prepend := "${FILE_DIRNAME}/files:"
> +FILESPATH:append := ":${FILE_DIRNAME}/files"
>   
>   DESCRIPTION ?= "Custom kernel module ${PN}"
>   

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de