From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7250097659913961472 X-Received: by 2002:a05:6402:1159:b0:516:a09c:cb42 with SMTP id g25-20020a056402115900b00516a09ccb42mr25793952edw.4.1688046236862; Thu, 29 Jun 2023 06:43:56 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:1604:b0:51d:8056:da3f with SMTP id f4-20020a056402160400b0051d8056da3fls177317edv.1.-pod-prod-09-eu; Thu, 29 Jun 2023 06:43:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4/l5VQaV4Y9CSBd7BjvLD1FZW7PEFFWcysHBXuhGk/QYf3K1ESCbCyQW6UTIY0BYZOrtUp X-Received: by 2002:a50:ec90:0:b0:51d:d3e0:b098 with SMTP id e16-20020a50ec90000000b0051dd3e0b098mr2871592edr.32.1688046235394; Thu, 29 Jun 2023 06:43:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688046235; cv=none; d=google.com; s=arc-20160816; b=BJV4Xf7fZabI+xUDG21PR+hQBHi9BK6wG+YSfVZKeRt9HGrrRUNgfIP/WOXgBLPpOc lbrJQSMdvtZLJYLHodFlIVV/wZt3yc48vERP111xlJpz+h/2pVCQs4PouXJgo4QW5tfd tvqSyoBkOYDXP3oKkKFy/C0oZTGxeLMpmeua8qz5egcZWHOygiYdxibW051JDQrTkQ6f 3j4acuITfNi4XpN37YUkGaQLVyXoK11P1rYGmBWIrwIMniuKpOzQ4pp1scN5JlyUpHVH 9LDa1fZIZjgFUF65uFkvjEWMiOcw2yMkDiC5y21fyE51xrp5Swf4DwwZIGqVmeCwBZAf 9mIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=Hk7oFoJx4+fnH957v/4NNYblo2JSs4flbEkD2o8Tb/k=; fh=IOvkRtu0uV86wK1FlmX5qlAbGVepDm6/NxMvp8hvIv0=; b=aVP1nvQdi4vNwYz1zYfQtl0xv2MSCQ8GBOccTRBYlhODL2UUCp3VSKcstSo777mmL9 d/NCsdmFOcxjoCMLR9nRiK64jLZbl3nw+pQrytR6/+eUsNlwvDmmgEZFgDb4/vBlRMrs gSdEPTvd1BApUSP19iRWVCMeb4WlG8TsQijf5GlDVnC62xhe270Dc0BsuRfk9Wzb5+nM XB6S6zHb5YHYqUWxTpOP9a6cbeaQZkF9xo5RQBKTRcaodZHAaCQm6BSQ8HTeGUpCbY5k D95rwmqhTlPKnN7kYyfhRIQYN9W9I5XDFHqKoXcAZvwbBDWgcrofIrH6+27dy+i1vxcw Ga2g== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=EVgX7WRH; spf=pass (google.com: domain of ch@denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=ch@denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=denx.de Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by gmr-mx.google.com with ESMTPS id cx26-20020a05640222ba00b0050bdc0e7cf6si933570edb.5.2023.06.29.06.43.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 06:43:55 -0700 (PDT) Received-SPF: pass (google.com: domain of ch@denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=EVgX7WRH; spf=pass (google.com: domain of ch@denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=ch@denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=denx.de Received: from [10.88.0.66] (dslb-088-077-007-063.088.077.pools.vodafone-ip.de [88.77.7.63]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ch@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 5F2848474B; Thu, 29 Jun 2023 15:43:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1688046234; bh=Hk7oFoJx4+fnH957v/4NNYblo2JSs4flbEkD2o8Tb/k=; h=Date:Subject:To:References:From:In-Reply-To:From; b=EVgX7WRH1GAWWcfSPhQ9A2u5+g2ZgAoHJRnk5x7rV9XCENKe2r77FkIeUOcEoRXTs +RiQZ0FgKl6WMEvGJrscmpe989cv0w3dOOE8oUHTX/p603R7LhdOECztsBLyVoBWHD sYEmrZRBtOecmrMndH/1i7zcfcY6hTt8gVvmA27FqKqrQkYiMpsAhS3wcrb1cudGtk ZDMwki9stfSWYnG3lJAYb7v/qV4/xsbTF7aIBcYnkjqM1QkbggHwXia/2vuoxjAZQs MQLizf69mTYL+hws0QPij5dfl/XiIZpgl4kghr253w2yq9sZcgZgGy1fhO0Gg2qGn6 ba3d14rFcO18Q== Message-ID: Date: Thu, 29 Jun 2023 15:43:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFC PATCH 1/1] linux-module: append local files path to FILSPATH Content-Language: en-US To: isar-users@googlegroups.com, Vijai Kumar K References: <20230629132107.2202204-1-ch@denx.de> <20230629132107.2202204-2-ch@denx.de> From: Claudius Heine Organization: Denx Software Engineering In-Reply-To: <20230629132107.2202204-2-ch@denx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-TUID: 3QaMMUpw8jSD Hi Vijai, I looked in the gitlog, and it seems like you last changed this stuff in `83bfec59f6e4b104de1acabecd51dd08d2c840d8`: Replace FILESPATH with FILESEXTRAPATHS The suggested approach to include files & patches from bbappend files is FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" This is not possible if FILESPATH is modified directly. Use FILESEXTRAPATHS instead. I an not 100% sure I understand you here. but couldn't this be solved by using the override syntax on `FILESPATH` instead of `=.`? regards, Claudius On 2023-06-29 15:21, Claudius Heine wrote: > FILESEXTRAPATHS is meant to allow bbappend files to overwrite files from > their recipe. For this reason the 'normal' patter in bbappend files is > to prepend the local file path to FILESEXTRAPATHS, which results in > files from the local file path to be preferred over files from the > original recipe, or other, lower prioritized bbappend files. > > The `module.inc` file is meant to be included by other recipes (`.bb`) > files. So it should still allow the recipe to overwrite files its files > that where added via the normal recipes `FILESPATH` search path. > > If `module.inc` uses `FILESEXTRAPATHS:prepend` to add its local file > path to `FILESPATH`, then the recipe, that includes the `module.inc` > would have to use `FILESEXTRAPATHS:prepend` as well, after including the > `module.inc` file in order to overwrite the files from the `module.inc` > file. However this is a workaround of the issue. > > `module.inc` should append its local file search path to `FILESPATH`, so > that it allows other recipes to overwrite any file from it, without > requiring an additional workaround. > > Signed-off-by: Claudius Heine > --- > meta/recipes-kernel/linux-module/module.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc > index 76ad860..333c66b 100644 > --- a/meta/recipes-kernel/linux-module/module.inc > +++ b/meta/recipes-kernel/linux-module/module.inc > @@ -5,7 +5,7 @@ > # > # SPDX-License-Identifier: MIT > > -FILESEXTRAPATHS:prepend := "${FILE_DIRNAME}/files:" > +FILESPATH:append := ":${FILE_DIRNAME}/files" > > DESCRIPTION ?= "Custom kernel module ${PN}" > -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de