From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 28 Nov 2025 09:56:05 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-lf1-f63.google.com (mail-lf1-f63.google.com [209.85.167.63]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 5AS8u3oJ025963 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 28 Nov 2025 09:56:03 +0100 Received: by mail-lf1-f63.google.com with SMTP id 2adb3069b0e04-594cb7effeasf1014150e87.3 for ; Fri, 28 Nov 2025 00:56:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1764320158; cv=pass; d=google.com; s=arc-20240605; b=K6jOzvX0w7LT7iOf0qGX6JTMez7nIrZatcU/Bb3QUjoT2svb2eCm+lwyIMv5+4vmTV dJTnsh1VjzEupkPjGYpqy5bZfasUW6ZzPYRhuU7lMVoQLJ4lzmwazHZR9eJLpBUHXGnQ pMbzmUL2XDdde+9RIFvFyDowDJMfgFz/xH8aLWTt4TMyuD3yj358sTY4crO5Kodr5I/5 zeO2Ku+K6kLYiXCWxUVrBuhKw6VNvI7E79M/it38aNy9oOR3HwjzhRwCH+RaowbCyNeB 8/QMjyyzUQzp03N1XfZ9qWJX3a3xRDlurzGYUKa5l4ZDaHPr79NklCqTiNy0pUnPhP27 aTlg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:content-transfer-encoding :in-reply-to:from:content-language:references:to:subject:user-agent :mime-version:date:message-id:sender:dkim-signature; bh=bXd2McvDS3iaWzZjInbTIgIXVc5LAzXKn2H/8ihzfSA=; fh=IBOK457zD+cE1R9LKbFsbBrMYVb0tmU7jbMwRKQNFII=; b=RiyyxHmpLUPLQsGxYq7fsMnxLdWiaBUOGwfSh+TDgwDxZeUTRVNiItgC2d/Nk+/Zc6 IH3f7xjzceP9UGlQF2hmAJX07edCmhtqIOxwr4B3RZMMuDlnIBrg9wGoLNoa6BsuZFfu VcZI5sPP6uM0DSFB2tX6LUjf3YP8vwzGsYlPQb8dnOnh1K5pZ7g31L9pdU7qErjUUOGF rZESBcVSOnQ8GP5lHUgexKc/wP1/lOwB5GGVtMIzv4HvZfNRHIJkZJ1l353W6ZrKmcEC n3/YhB+jrmWc8gu9T/s73Bl69a8LzTrqyVRKeNnUlmQvBuvBuFHU64NoX/lAwMw8g7pB Pi/Q==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1764320158; x=1764924958; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=bXd2McvDS3iaWzZjInbTIgIXVc5LAzXKn2H/8ihzfSA=; b=wnopANO883TNRZ8nU1azpZd0a//hY9uJBySjO46GIlJTYViO052MSWqBb6+hNMhd6V wqooQen7hFPGgHckJkBS0OA/tpX5qnWXdHI7cfQgi5ffNL8ZsVKetAekoMpZ4q5KuMUv PUiKmF0/kLSedRyYWbLPGBCbaVvsTk5q9mq7/+XiEMXgwMbL86cjzfb13R2G76zuMH5N WXcqH9mczzOWgNjtpQVSAuajUiLnBC3H/8iTvitw4FKf/MpK5nwIT59cHCP+ckTHRiH7 fiYBFr1gx8CiljFHs0fB1Qkp14hBKf/GB2t4FDvQsdoedvqfMB5asrH9Ywum8miz5Bas Q+qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764320158; x=1764924958; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date :message-id:reply-to; bh=bXd2McvDS3iaWzZjInbTIgIXVc5LAzXKn2H/8ihzfSA=; b=Er2enGfp5BdbElGp9fhuh9vLQtJWzRmoTiGywtYRQwwksnZ0bBmvvqUX0xnLuL/Zvp /XajiyDqaRAKYyfnykH3D/sO8oVfvH4jUhTNNOGzx2gbHWiEUmzaHFUzH4LI7fc8m+dD XeKrdY+xNQq8hbap6PGP6RFnqOzQSbCSuM+9C/la9W4vD4M0LF2SILVMDjimfIuktc1F UpW05px3zPLtsZJj9/8CK+EeeyW4UfpGBJRR384dGwe2q32+zDAV/ffjAIc4aHux8Clz v+O6RvfUQdjsP4+CEky6TzLmFSJjMpeqWxrMqyVaMFpPv2aqaFUlf/P6FrZCH7GPpWuz 0B2w== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCV5IRoX3ch/oOJGqCIgb5Tq0ZFbxSt9HOn/6KULnfg1pYfevdNGVuPMemlXRTSXlOJ5U5yb@ilbers.de X-Gm-Message-State: AOJu0YwdXnYOSQ/DnAv6C8OPa02RerVBzQBv5qwurqT2IRx6mfgTCKhx XJiJz6a2b7DMtIC3pjTWUvkX/6+sCQ/BbRbDg1DbCSy0ZxFeKforTUza X-Google-Smtp-Source: AGHT+IFM2Sjmvs6yJGS97p/sQGIzs1zT3ZKBAWUJAQh2zYHeR5jjxHwW3ts3YVuM2TiqQTpD+AX2xw== X-Received: by 2002:a05:6512:e9c:b0:592:fc68:5b9d with SMTP id 2adb3069b0e04-596b4e4b898mr5640404e87.10.1764320157601; Fri, 28 Nov 2025 00:55:57 -0800 (PST) X-BeenThere: isar-users@googlegroups.com; h="Ae8XA+bdQitRAzh3w6Xb2h2WWQHMWMf5ByV0HVo6RMYs5FF1Xg==" Received: by 2002:a05:651c:31cb:b0:37b:9709:9756 with SMTP id 38308e7fff4ca-37d203dcef5ls1584661fa.2.-pod-prod-09-eu; Fri, 28 Nov 2025 00:55:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCU7sj5B+vcdjfzhArQKQ3dh9XEeM3nqe44+dw+LN+G/R+hKrJf7uv/eSArYtyDsU8tl8T/m7BDUTbe+@googlegroups.com X-Received: by 2002:a2e:9f0b:0:b0:37b:ab6d:e65a with SMTP id 38308e7fff4ca-37d0782c177mr32323511fa.15.1764320154582; Fri, 28 Nov 2025 00:55:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1764320154; cv=none; d=google.com; s=arc-20240605; b=AVmOht079IIJ+yBG/jQb2bKR9cKoH2mOESV0WKnbHNyk7ko3hmQBkR+Cl/VChKkSIC hzopfz4cmEXjDeB5cYSKqTbuI4z6QaCEF279vJC8oKxAp0p1oAWLDU4klGMoDJsdoaEQ Ro1U5GNbHxIAcaFoK6vnJ7p2Ukfm/ZhE6A2kdUU7GNBJcSffXx7lwTBg5wfvXuSje/WG ckKTtfzqkFkM2LZkiKkwm4ceTWNYwl2qBLBRx+9cJlyEAfrkZEDlOR3vqXYD+uV54gF3 2pjWzLuLbNvAY3cSwNa9CAsSv2q0pgRRjW3fuMURljxUN0KOKUYzvGMwHJ/T3XO1oibT M/fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id; bh=gamSUT8pijOu/NHO8uB8xxn5ZjkvnAyNqAJI8psx1Uw=; fh=U838744Lieu98kAmURAlE7+a/Q6mmsmjp8YqlhYb5/w=; b=ekMTcmisjQxTomROuiGPrjMi3TVXeJAjdjyAorSqEfK95olg2IkqbIkop5fEIkPCt1 MBqycK9NNNuF3fzTxgq7c2UN9C2ixECqN2YX4LUJBqjeOWUGfugPFje2wMpceV+0HNKA e8Y1u0C4Jge1yjrCHUzRcJF0DTvZebVorB9Rx9tBJ4sxS8qsV0f/XgW+2YjC30bIaBJW xZQsL+zLynEoKe8u/ukyuiQQCMAT+4d9dBK4+o/MatREzT3Gv33Nas8sSvxcgPR5V/Ei RWfqxqAEBgbCu55GFlXlRAMcXXsP+ZoKfcbcc4SknJduICQo+3RXg8t8h4i4obriJPG6 zMhg==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 38308e7fff4ca-37d235653d6si554601fa.0.2025.11.28.00.55.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Nov 2025 00:55:54 -0800 (PST) Received-SPF: pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [192.168.178.117] ([88.130.203.42]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 5AS8tqoj025952 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Nov 2025 09:55:53 +0100 Message-ID: Date: Fri, 28 Nov 2025 09:55:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] initramfs-tee-ftpm-hook: Fix missing separator in OVERRIDES append To: Jan Kiszka , Sai Sree Kartheek Adivi , isar-users@googlegroups.com, vigneshr@ti.com References: <20251126112816.3415995-1-s-adivi@ti.com> <2e5400ea-5ec4-414d-b4c3-d0696766c711@siemens.com> Content-Language: en-US From: Zhihang Wei In-Reply-To: <2e5400ea-5ec4-414d-b4c3-d0696766c711@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: wzh@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: 7eVz4EdOIQb5 On 11/27/25 17:47, Jan Kiszka wrote: > On 27.11.25 17:18, Zhihang Wei wrote: >> Hi, >> Actually CI failed with this fix. I think we have another bug that we >> didn't notice before. >> > Yes, > > SRC_URI:supp-user +=3D "file://local-top" > > effectively means > > SRC_URI:supp-user =3D "file://local-top" > > and that breaks the initramfs-hook infrastructure. Should have been > :append, but that line was wrong anyway. Let me send out my other patch > then so that you can safely apply this one on top. > > Jan CI has passed for this patch together with [PATCH]=20 initramfs-tee-ftpm-hook: Restore waiting for tpm device. We'll merge=20 both by the end of this workday if there's no more discussion coming. Zhihang >> The following test case in fast CI failed: >> - citest.py:CrossTest.test_cross >> >> It failed when trying to build target: >> - mc:stm32mp15x-bullseye:isar-image-base >> >> Error log follows: >> builder@6782040fd604:/work/testsuite$ avocado run >> citest.py:CrossTest.test_cross$ >> JOB ID : d69c8438384becc97bbdbf1d7c84d6409cf5bc5d >> JOB LOG : /tmp/tmpv12knspa/avocado/job-results/job-2025-11-27T16.27- >> d69c843/job.log >> (1/1) citest.py:CrossTest.test_cross: STARTED >> ERROR: mc:stm32mp15x-bullseye:initramfs-tee-ftpm-hook-0.3-r0 >> do_transform_template: Error executing a python function in >> exec_func_python() autogenerated: >> >> The stack trace of python calls that resulted in this exception/failure >> was: >> File: 'exec_func_python() autogenerated', lineno: 2, function: >> 0001: >> *** 0002:do_transform_template(d) >> 0003: >> File: '/work/meta/classes/template.bbclass', lineno: 53, function: >> do_transform_template >> 0049: else (template_file + ".out")) >> 0050: bb.note("{} {} [in: {} out: {}]".format(cmd, args, >> 0051: template_file, output_file)) >> 0052: with contextlib.ExitStack() as stack: >> *** 0053: input =3D stack.enter_context(open(template_file, 'rb')) >> 0054: output =3D stack.enter_context(open(output_file, 'wb')) >> 0055: process =3D stack.enter_context(subprocess.Popen([cmd, args], >> stdin=3Dinput, >> 0056: stdout=3Doutput, env=3Denv)) >> 0057: if process.wait() !=3D 0: >> Exception: FileNotFoundError: [Errno 2] No such file or directory: '/ >> work/build/tmp/work/debian-bullseye-armhf/initramfs-tee-ftpm-hook/0.3- >> r0/hook-header.tmpl' >> >> ERROR: Logfile of failure stored in: /work/build/tmp/work/debian- >> bullseye-armhf/initramfs-tee-ftpm-hook/0.3-r0/temp/ >> log.do_transform_template.66542 >> (1/1) citest.py:CrossTest.test_cross: FAIL: Bitbake failed (145.59 s) >> RESULTS : PASS 0 | ERROR 0 | FAIL 1 | SKIP 0 | WARN 0 | INTERRUPT 0 | >> CANCEL 0 >> JOB TIME : 146.95 s >> >> Test summary: >> citest.py:CrossTest.test_cross: FAIL >> >> >> >> You can redo the test on your machine using avocado: >> 1. Have a clean clone of isar, checkout to branch next and apply your >> patches: >> $ git clone -b next https://github.com/ilbers/isar.git >> $ cd isar >> $ git am /path-to/0001-my-contribution-to-isar.patch >> 2. Disable several unrelated targets to make error appears faster, by >> applying >> the following diff: >> >> diff --git a/testsuite/citest.py b/testsuite/citest.py >> index 2e46088d..ed6a1114 100755 >> --- a/testsuite/citest.py >> +++ b/testsuite/citest.py >> @@ -197,14 +197,7 @@ class CrossTest(CIBaseTest): >> >> =C2=A0 =C2=A0 =C2=A0def test_cross(self): >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0targets =3D [ >> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'mc:qemuarm-buster:isar-image= -ci', >> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'mc:qemuarm-bullseye:isar-ima= ge-ci', >> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'mc:de0-nano-soc-bullseye:isa= r-image-base', >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'mc:stm32mp15x-bullseye= :isar-image-base', >> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'mc:qemuarm-bookworm:isar-ima= ge-ci', >> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'mc:qemuarm64-focal:isar-imag= e-base', >> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'mc:nanopi-neo-efi-bookworm:i= sar-image-base', >> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'mc:phyboard-mira-bookworm:is= ar-image-base', >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0] >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.init() >> >> >> 3.Run kas shell, setup CI prerequisites (avocado, qemu) and cleanup: >> $ ./kas/kas-container shell kas/isar.yaml --command \ >> =C2=A0 =C2=A0 "rm -rf /work/build/conf && /work/scripts/ci_setup.sh" >> 4.Run the failed test in fast: >> $ cd /work/testsuite >> $avocado run citest.py:CrossTest.test_cross$ >> >> Best regards, >> Zhihang >> >> On 11/26/25 12:28, 'Sai Sree Kartheek Adivi' via isar-users wrote: >>> Prepend the missing colon to the appended string to ensure 'supp-user' >>> is registered as a distinct override. >>> >>> This ensures that SRC_URI:supp-user takes effect when >>> TEE_SUPPLICANT_IN_USERLAND is to "1". >>> >>> Fixes: 3896e4da ("initramfs-tee-ftpm-hook: Use override to model >>> variations") >>> Signed-off-by: Sai Sree Kartheek Adivi >>> --- >>> =C2=A0 .../initramfs-tee-ftpm-hook/initramfs-tee-ftpm-hook_0.3.bb=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 | 2 +- >>> =C2=A0 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/meta/recipes-initramfs/initramfs-tee-ftpm-hook/initramfs- >>> tee-ftpm-hook_0.3.bb b/meta/recipes-initramfs/initramfs-tee-ftpm-hook/ >>> initramfs-tee-ftpm-hook_0.3.bb >>> index 94399374..f1015028 100644 >>> --- a/meta/recipes-initramfs/initramfs-tee-ftpm-hook/initramfs-tee- >>> ftpm-hook_0.3.bb >>> +++ b/meta/recipes-initramfs/initramfs-tee-ftpm-hook/initramfs-tee- >>> ftpm-hook_0.3.bb >>> @@ -12,7 +12,7 @@ require recipes-initramfs/initramfs-hook/hook.inc >>> =C2=A0 # NOTE: default will eventually be flipped >>> =C2=A0 TEE_SUPPLICANT_IN_USERLAND ?=3D "1" >>> =C2=A0 -OVERRIDES .=3D "${@'supp-user' if >>> bb.utils.to_boolean(d.getVar('TEE_SUPPLICANT_IN_USERLAND')) else ''}" >>> +OVERRIDES .=3D "${@':supp-user' if >>> bb.utils.to_boolean(d.getVar('TEE_SUPPLICANT_IN_USERLAND')) else ''}" >>> =C2=A0 =C2=A0 SRC_URI:supp-user +=3D "file://local-top" >>> =20 > --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= e79db2c8-79ce-48d2-b875-5bb0ef14d7f5%40ilbers.de.