Re: [PATCH] mount: Cleanup reference counters before build

[Jan Kiszka <jan.kiszka@siemens.com>]

On 25.06.21 13:25, Anton Mikanovich wrote:
> Thanks for informing, I hope Jan's issues will be also fixed.
> 
> Isar documentation needs some rebuilding. I will prepare appropriate
> patchset.
> 

The issue might be fixed (I didn't find time to test in my setup yet),
but I'm still doubting the general usefulness of this rework.

We need a clearer picture what it fixes, what it possibly can't fix (I
doubt it can fix all error cases), and if we still want it then. Maybe
start with documenting the API changes and their reasoning.

Also describe more clearly how to reproduce the issues you were seeing
and trying to fix. That is key to understand if the new solution is
actually a solution or just shifting the problem from left to right.

Please also study the history of the current solution (master), how we
got there (was surely not straight) and why we may not have taken other
paths back then (e.g. the fact that you cannot umount when something is
still running in the background).

Meanwhile, I'm strongly voting for reverting things in next to master.

Jan

> 25.06.2021 11:19, Moessbauer, Felix wrote:
>> Hi Anton,
>>
>> this patch solved the build issues at least for my use-case.
>> While it required me to add the buildchroot_do_mounts / buildchroot_undo_mounts to custom tasks, I guess that is the new intended behavior.
>>
>> There should be a BIG warning somewhere in the documentation that this might require changes to (ill-formed) recipes.
>>
>> Best regards,
>> Felix
>>
>>> -----Original Message-----
>>> From: isar-users@googlegroups.com <isar-users@googlegroups.com> On
>>> Behalf Of Anton Mikanovich
>>> Sent: Wednesday, June 23, 2021 1:58 PM
>>> To: isar-users@googlegroups.com
>>> Cc: Anton Mikanovich <amikan@ilbers.de>
>>> Subject: [PATCH] mount: Cleanup reference counters before build
>>>
>>> Reference counters are not cleared in case unsuccessful build happens.
>>> So we need to force cleanup before the build.
>>>
>>> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
>>> ---
>>>  meta/classes/isar-events.bbclass | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass
>>> index 73419b4..2f8bf6e 100644
>>> --- a/meta/classes/isar-events.bbclass
>>> +++ b/meta/classes/isar-events.bbclass
>>> @@ -8,6 +8,8 @@ addhandler build_started
>>>
>>>  python build_started() {
>>>      bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/temp/once.*")
>>> +    bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/rootfs.mount")
>>> +    bb.utils.remove(d.getVar('TMPDIR') + "/deploy/buildchroot-*/*.mount")
>>>  }
>>>  build_started[eventmask] = "bb.event.BuildStarted"
>>>
>>> --
>>> 2.20.1
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "isar-users" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an email
>>> to isar-users+unsubscribe@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.g
>>> oogle.com%2Fd%2Fmsgid%2Fisar-users%2F20210623115823.136514-1-
>>> amikan%2540ilbers.de&amp;data=04%7C01%7Cfelix.moessbauer%40siemens.c
>>> om%7Ccb2b9bb12a8c440d39f308d9363e3b61%7C38ae3bcd95794fd4addab42e
>>> 1495d55a%7C1%7C0%7C637600463175992733%7CUnknown%7CTWFpbGZsb3d
>>> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
>>> %7C1000&amp;sdata=XJvU0n32Mh0DrWQXD%2B18VEenK5t2e8lKDLLkyy1tamg
>>> %3D&amp;reserved=0.
> 
> -- 
> Anton Mikanovich
> Promwad Ltd.
> External service provider of ilbers GmbH
> Maria-Merian-Str. 8
> 85521 Ottobrunn, Germany
> +49 (89) 122 67 24-0
> Commercial register Munich, HRB 214197
> General Manager: Baurzhan Ismagulov
> 

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux