From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6976957543224442880 X-Received: by 2002:a05:6512:33b8:: with SMTP id i24mr22736049lfg.540.1624974595883; Tue, 29 Jun 2021 06:49:55 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3f94:: with SMTP id x20ls333291lfa.0.gmail; Tue, 29 Jun 2021 06:49:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmoxvWppiAYsaBUjEnGZ0X1mY95/6EfUrEprNi2kWKDzwxnOTusPGJAowJSR/WzYU8TWLW X-Received: by 2002:a19:7b13:: with SMTP id w19mr23115949lfc.193.1624974594678; Tue, 29 Jun 2021 06:49:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624974594; cv=none; d=google.com; s=arc-20160816; b=fCMqzquoIRLpJid17fgTz37lQLX/0mqKqmMJe5alr75OCBg+l+D31mF8x9P1G3Wb0t juJ09luzzDjgB3LqiCBeg8+Fxe6Dh48O82SIepEELrAeT3HZxQYxTKDOKKThdiotEADM YdOuefAcFor6GlUiamcnoSxaoWb7jaDvxVspPGRLEGhNYZL64FVa6eD9QMIlSnW449kL c4WPgxeI+Rq06lfP+HnQcTYcQwQ4OtXHpQqv7Jb9toYCQZ103xaiF9GJEb3NqkBQELuz 5T59/iLbBxBGmC/+2Gs3Te5sGXbT9QmIpXiJ9X3CXwRAd/C5imLO3QSGdHb8CCSaZPx5 B6Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=1HzBjdWxm9jkFwbGKdq3ew/WCtSwDlt4JG3J5IMwjlI=; b=Q3CdOvY2/Mdl9YKsws49IXLIvCo/AH6qilf82lmRkVwQW1dd1a5i2YPqJ1XepKDxve T52mrTnVfO1KPOvzTB7xWV1cR7r5COk6R2oiS3R7/W8rwcivX0XJEEw+NuMcQ4n8ZbGx CYKW7ziW4OVj5KjWYyrNeMEnTm/A5DfV8lSFBfDrqYEdyfJ/oLoMh/r0fR/tsTY+BztC eMQLgy+K+tkKhbiwQlkCJiMCa0z2mMxYzaK18+YPicWBPvx4LdqEwhkpwS2QuQhPEE26 ywzspDVgJ4nbNf9ZIaT9qiBtz4U0d9JJiEDw2fGFovwcsImQ7klm7WO6oVKpZZTQdT7Y 53dw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id m18si705499lfl.1.2021.06.29.06.49.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jun 2021 06:49:54 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 15TDnrF6014309 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Jun 2021 15:49:54 +0200 Received: from [139.22.37.193] ([139.22.37.193]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 15TDnrUL028958; Tue, 29 Jun 2021 15:49:53 +0200 Subject: Re: [PATCH] mount: Cleanup reference counters before build To: Anton Mikanovich , "Moessbauer, Felix" , "isar-users@googlegroups.com" , Baurzhan Ismagulov Cc: "henning.schild@siemens.com" References: <20210623115823.136514-1-amikan@ilbers.de> <36ad6945-e841-c8fb-3779-44768667e7a4@ilbers.de> From: Jan Kiszka Message-ID: Date: Tue, 29 Jun 2021 15:49:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <36ad6945-e841-c8fb-3779-44768667e7a4@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: ecX1gc5bK1Pl On 25.06.21 13:25, Anton Mikanovich wrote: > Thanks for informing, I hope Jan's issues will be also fixed. > > Isar documentation needs some rebuilding. I will prepare appropriate > patchset. > The issue might be fixed (I didn't find time to test in my setup yet), but I'm still doubting the general usefulness of this rework. We need a clearer picture what it fixes, what it possibly can't fix (I doubt it can fix all error cases), and if we still want it then. Maybe start with documenting the API changes and their reasoning. Also describe more clearly how to reproduce the issues you were seeing and trying to fix. That is key to understand if the new solution is actually a solution or just shifting the problem from left to right. Please also study the history of the current solution (master), how we got there (was surely not straight) and why we may not have taken other paths back then (e.g. the fact that you cannot umount when something is still running in the background). Meanwhile, I'm strongly voting for reverting things in next to master. Jan > 25.06.2021 11:19, Moessbauer, Felix wrote: >> Hi Anton, >> >> this patch solved the build issues at least for my use-case. >> While it required me to add the buildchroot_do_mounts / buildchroot_undo_mounts to custom tasks, I guess that is the new intended behavior. >> >> There should be a BIG warning somewhere in the documentation that this might require changes to (ill-formed) recipes. >> >> Best regards, >> Felix >> >>> -----Original Message----- >>> From: isar-users@googlegroups.com On >>> Behalf Of Anton Mikanovich >>> Sent: Wednesday, June 23, 2021 1:58 PM >>> To: isar-users@googlegroups.com >>> Cc: Anton Mikanovich >>> Subject: [PATCH] mount: Cleanup reference counters before build >>> >>> Reference counters are not cleared in case unsuccessful build happens. >>> So we need to force cleanup before the build. >>> >>> Signed-off-by: Anton Mikanovich >>> --- >>> meta/classes/isar-events.bbclass | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass >>> index 73419b4..2f8bf6e 100644 >>> --- a/meta/classes/isar-events.bbclass >>> +++ b/meta/classes/isar-events.bbclass >>> @@ -8,6 +8,8 @@ addhandler build_started >>> >>> python build_started() { >>> bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/temp/once.*") >>> + bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/rootfs.mount") >>> + bb.utils.remove(d.getVar('TMPDIR') + "/deploy/buildchroot-*/*.mount") >>> } >>> build_started[eventmask] = "bb.event.BuildStarted" >>> >>> -- >>> 2.20.1 >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "isar-users" group. >>> To unsubscribe from this group and stop receiving emails from it, send an email >>> to isar-users+unsubscribe@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.g >>> oogle.com%2Fd%2Fmsgid%2Fisar-users%2F20210623115823.136514-1- >>> amikan%2540ilbers.de&data=04%7C01%7Cfelix.moessbauer%40siemens.c >>> om%7Ccb2b9bb12a8c440d39f308d9363e3b61%7C38ae3bcd95794fd4addab42e >>> 1495d55a%7C1%7C0%7C637600463175992733%7CUnknown%7CTWFpbGZsb3d >>> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D >>> %7C1000&sdata=XJvU0n32Mh0DrWQXD%2B18VEenK5t2e8lKDLLkyy1tamg >>> %3D&reserved=0. > > -- > Anton Mikanovich > Promwad Ltd. > External service provider of ilbers GmbH > Maria-Merian-Str. 8 > 85521 Ottobrunn, Germany > +49 (89) 122 67 24-0 > Commercial register Munich, HRB 214197 > General Manager: Baurzhan Ismagulov > -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux