Re: [PATCH v3 17/20] testsuite: skip VM tests if images are not available

["'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>]

On Wed, 2026-01-28 at 12:54 +0100, Zhihang Wei wrote:
> On 1/23/26 09:24, Zhihang Wei wrote:
> > From: "MOESSBAUER, Felix" <felix.moessbauer@siemens.com>
> > 
> > We currently fail the test if the image is not available. Instead, we
> > now skip it and report what is missing. By that, we stay semantically
> > correct by not failing tests when pre-conditions are not fulfilled.
> > 
> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> > ---
> >   testsuite/cibuilder.py | 19 +++++++++++++++++++
> >   1 file changed, 19 insertions(+)
> > 
> > diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py
> > index 7538ade2..6faa9038 100755
> > --- a/testsuite/cibuilder.py
> > +++ b/testsuite/cibuilder.py
> > @@ -24,6 +24,7 @@ from utils import CIUtils
> >   from avocado import Test
> >   from avocado.utils import path
> >   from avocado.utils import process
> > +from avocado.core import exceptions
> >   
> >   sys.path.append(os.path.join(os.path.dirname(__file__), '../bitbake/lib'))
> >   
> > @@ -703,6 +704,7 @@ class CIBuilder(Test):
> >           keep=False,
> >       ):
> >           time_to_wait = self.params.get('time_to_wait', default=DEF_VM_TO_SEC)
> > +        self.skip_if_vm_image_missing(arch, distro, image)
> >   
> >           self.log.info("===================================================")
> >           self.log.info(f"Running Isar VM boot test for ({distro}-{arch})")
> > @@ -800,3 +802,20 @@ class CIBuilder(Test):
> >               self.vm_turn_off(vm)
> >   
> >           return stdout, stderr
> > +
> > +    def skip_if_vm_image_missing(self, arch, distro, image):
> > +        (
> > +            image_fstypes,
> > +            image_fullname,
> > +            deploy_dir_image,
> > +        ) = CIUtils.getVars(
> > +            'IMAGE_FSTYPES',
> > +            'IMAGE_FULLNAME',
> > +            'DEPLOY_DIR_IMAGE',
> > +            target=f"mc:qemu{arch}-{distro}:{image}",
> > +        )
> > +        image_type = image_fstypes.split()[0]
> > +        rootfs_image = f"{image_fullname}.{image_type}"
> > +        rootfs_image_path = os.path.join(deploy_dir_image, rootfs_image)
> > +        if not os.path.exists(rootfs_image_path):
> > +            raise exceptions.TestSkipError(f'VM image missing: {rootfs_image}')
> Hi,
> 
> this particular patch (p17) causes Avocado to crash because it encounters an
> unrecognized log level. This is a known issue in Avocado that has been fixed
> in more recent versions.
> 
> While we plan to update Avocado on our CI server, we would prefer to 
> partially
> apply the patch set without p17 for now, as that patch is quite independent
> of the others.

That's fine for me. Once we update avocado, we still can re-apply the
patch.

Felix

> 
> Zhihang

-- 
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/e8093f91afe1168aec9b79b53d0c49fd03dd0d79.camel%40siemens.com.