From: "Kanagarajan, Vijaikumar" <Vijaikumar_Kanagarajan@mentor.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "henning.schild@siemens.com" <henning.schild@siemens.com>
Subject: RE: [PATCH 1/2] meta-isar/wks: prepare wks for wic uprev
Date: Mon, 13 Jun 2022 07:36:15 +0000 [thread overview]
Message-ID: <e88e5022e1a64b9da7a79b7c5014e769@mentor.com> (raw)
In-Reply-To: <0a8903ab-ff17-594c-58c9-f4c4db73d831@siemens.com>
> -----Original Message-----
> From: Jan Kiszka <jan.kiszka@siemens.com>
> Sent: 13 June 2022 12:46
> To: Kanagarajan, Vijaikumar <Vijaikumar_Kanagarajan@mentor.com>; isar-
> users@googlegroups.com
> Cc: henning.schild@siemens.com
> Subject: Re: [PATCH 1/2] meta-isar/wks: prepare wks for wic uprev
>
> On 10.06.22 13:39, Vijai Kumar K wrote:
> > In the current version of wic we use, "/" mount points are ignored and
> > their entries are not added to fstab.
> >
> > But in the latest version of wic available in oe-core, this is not the case.
> > "/" mountpoints are respected and are added to fstab.
> >
> > ISAR already creates the necessary fstab. With the new version we will
> > end up with 2 entries for "/". One from ISAR's image_configure_fstab
> > and the other one appended by wic.
> >
> > Explicitly drop "/" mountpoint args in wks files to avoid this.
> >
>
> Wrong patch ordering.
The wks fixes are explicitly put before the wic uprev. Because after uprev you would have duplicate entries for "/" as mentioned in this [1] comment of mine.
In the current wic version in isar these(/ mount points) are ignored and are safe to drop from wks files without affecting functionality.
[1] https://groups.google.com/g/isar-users/c/MoD4uYEAle8/m/YivS6uUKAwAJ
Thanks,
VIjai Kumar K
[1]
>
> Jan
>
> --
> Siemens AG, Technology
> Competence Center Embedded Linux
next prev parent reply other threads:[~2022-06-13 7:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 11:39 [PATCH 0/2] Update wic to bring in fspassno feature Vijai Kumar K
2022-06-10 11:39 ` [PATCH 1/2] meta-isar/wks: prepare wks for wic uprev Vijai Kumar K
2022-06-13 7:16 ` Jan Kiszka
2022-06-13 7:36 ` Kanagarajan, Vijaikumar [this message]
2022-06-13 8:10 ` Henning Schild
2022-06-13 8:35 ` Kanagarajan, Vijaikumar
2022-06-13 9:26 ` Henning Schild
2022-06-10 11:39 ` [PATCH 2/2] wic: Update to the latest revision Vijai Kumar K
2022-06-13 7:15 ` [PATCH 0/2] Update wic to bring in fspassno feature Jan Kiszka
2022-06-13 7:21 ` Anton Mikanovich
2022-06-13 7:32 ` Kanagarajan, Vijaikumar
2022-06-13 8:31 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e88e5022e1a64b9da7a79b7c5014e769@mentor.com \
--to=vijaikumar_kanagarajan@mentor.com \
--cc=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox