From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6629320495720300544 X-Received: by 2002:a19:fc11:: with SMTP id a17mr193512lfi.11.1544190352562; Fri, 07 Dec 2018 05:45:52 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:50c9:: with SMTP id h9ls185030lfm.6.gmail; Fri, 07 Dec 2018 05:45:52 -0800 (PST) X-Google-Smtp-Source: AFSGD/V+OEvz459GcaWdiJlnvWM2bf/1YbC+15SsjA8Y2EJQYeEvl8Qmq0qou5cuiMpPGIXqNaqP X-Received: by 2002:ac2:4316:: with SMTP id l22mr195044lfh.4.1544190352094; Fri, 07 Dec 2018 05:45:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544190352; cv=none; d=google.com; s=arc-20160816; b=jNHcSfeAZ0Idfek9AwUKHhyMssPLDr4TLw3DjR7InucH88/bRxgZtKFwZ1Nbk00R8C qo+EPMp5L4xj73P4uxEFQT4fvLE3QtvBqAq+DbauslH6NO/da0ULJTUnuV/iODwoxQd9 xuRO1SPALk2f6YP2ha+/1e/izFAGim/5jrO7tli9cGHwpUYkcLsxUggQwwe0wXePP1RQ O5xCNBfmORB0m+sJ9d0n8J1Dykaf5e///+XBnCjHSTuoHWcSqh6kIfeMCYpQouene6s2 p2CCexqCz0CLfcVir7mqQLvUk0mq7CATKY7hH7oAy2YXBlWrBaqUUTcsAsQD8oHhuMJM LuZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=Bt/cDC39TtYjF7s3TXWOlFLZyRxn9Vt6VqDbDJerIhY=; b=DC3Zu8+BliTvZyTHEioA0k4pwZGa+xP7jpEdwNVhvdUtaYN/5AhWLfBDGRGwvnSCQ/ +27uW0gsLlCdTBsooGUXmIp3/WzZFtKX9weK2ss0d2yA3STDCIVdsJYFLQ396pEYH6Si HLQgi4IzWNGykgSRMXDWDV6qtUXwuPbaHQoR7h9dnx3Lm+WAsM2Zwa5vaEiglaUAwWT2 W84NdeRuoQSI5fU4nlfR988tEtz1oEwIggEQFemSKIkxp5AUEG877fKUyFSVZ9DwaL29 YH7dn+vz/MUEZsjsIW3XgPGL9WHFOOI/Tkck05bvdUPDaHxKXTC1cvYwi3Wr5++OLSXQ ElLg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id t16-v6si97727ljc.1.2018.12.07.05.45.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Dec 2018 05:45:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.180] (nat-ppp-217.71.235.199-satnet-spb.ru [217.71.235.199] (may be forged)) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id wB7Djnd8004599 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Fri, 7 Dec 2018 14:45:50 +0100 Subject: Re: [PATCH] isar-bootstrap: Fix and cleanup bind mounting To: Jan Kiszka , isar-users , Cedric Hombourger References: <6f5714bc-d5f5-c08f-c408-b32bab9169fc@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: Date: Fri, 7 Dec 2018 16:45:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <6f5714bc-d5f5-c08f-c408-b32bab9169fc@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 94SNrDORgmMZ On 11/29/18 7:29 PM, Jan Kiszka wrote: > First, wrong variables were used (there is no BUILDCHROOT_DIR for > isar_bootstrap). And then we simply left the mount points active after > completing the bootstrap. The led to setup_root_file_system copying all > the mount point content over into the buildchroot or rootfs - including > base-apt when it was used. Applied to the 'next', Thanks, Maxim. > Signed-off-by: Jan Kiszka > --- > > This is a precondition for "isar-image: umount base-apt when doing > offline build" to work properly. IOW, that patch reveal these bugs. > > Possibly, this also explains the increasing mount count that was visible > in CI. > > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > index 8ea3b08..da077d0 100644 > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > @@ -185,12 +185,8 @@ isar_bootstrap() { > sudo -E flock "${ISAR_BOOTSTRAP_LOCK}" -c "\ > set -e > if [ ! -e "${DEPLOY_ISAR_BOOTSTRAP}" ]; then > - if [ -e "${ROOTFSDIR}" ]; then > - umount -R -l "${ROOTFSDIR}/dev" || true > - umount -l "${ROOTFSDIR}/proc" || true > - umount -R -l "${ROOTFSDIR}/sys" || true > - rm -rf "${ROOTFSDIR}" > - fi > + rm -rf "${ROOTFSDIR}" > + > if [ ${IS_HOST} ]; then > ${DEBOOTSTRAP} $debootstrap_args \ > ${@get_distro_components_argument(d, True)} \ > @@ -247,17 +243,22 @@ isar_bootstrap() { > "${ROOTFSDIR}/chroot-setup.sh" "setup" "${ROOTFSDIR}" > > # update APT > - mount --rbind /dev ${BUILDCHROOT_DIR}/dev > - mount --make-rslave ${BUILDCHROOT_DIR}/dev > + mount --rbind /dev ${ROOTFSDIR}/dev > + mount --make-rslave ${ROOTFSDIR}/dev > mount -t proc none ${ROOTFSDIR}/proc > - mount --rbind /sys ${BUILDCHROOT_DIR}/sys > - mount --make-rslave ${BUILDCHROOT_DIR}/sys > + mount --rbind /sys ${ROOTFSDIR}/sys > + mount --make-rslave ${ROOTFSDIR}/sys > > export DEBIAN_FRONTEND=noninteractive > chroot "${ROOTFSDIR}" /usr/bin/apt-get update -y > chroot "${ROOTFSDIR}" /usr/bin/apt-get dist-upgrade -y \ > -o Debug::pkgProblemResolver=yes > > + umount -R -l "${ROOTFSDIR}/dev" > + umount -l "${ROOTFSDIR}/proc" > + umount -R -l "${ROOTFSDIR}/sys" > + umount -l "${ROOTFSDIR}/base-apt" || true > + > # Finalize debootstrap by setting the link in deploy > ln -Tfsr "${ROOTFSDIR}" "${DEPLOY_ISAR_BOOTSTRAP}" > fi" > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov