From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6844521397531705344 X-Received: by 2002:a2e:b55c:: with SMTP id a28mr9631944ljn.42.1593621203689; Wed, 01 Jul 2020 09:33:23 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9809:: with SMTP id a9ls35701ljj.2.gmail; Wed, 01 Jul 2020 09:33:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjcC//Ys1MD2CU/i7ph6/zvLRRRtJM6E2ecPbd6HUeK95ITW8Gid/b+/xjIkq7tZN4LECI X-Received: by 2002:a2e:a375:: with SMTP id i21mr9637584ljn.403.1593621203110; Wed, 01 Jul 2020 09:33:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593621203; cv=none; d=google.com; s=arc-20160816; b=ju+LOUzv2rwBhC/qX4kZmOT4n2AHHcfrhBNFK/3fmWM1UrbxtNVFs9XWq+O0bR9OqV KpDiozOv92KdidJy/zRJAm2MECKF841Y+/zN5I0uvDclAvbauSkluRoGS0/v3slpl2BI galQdRdlfusf4UCpX0GP6/6DFNhUFqevMgtoG4fRmio4ZD2DjoiVkRJu8X7kMSNMFNwo rQq+pxLc/RN1/2+NPFhsSpV6L5RRugxn+3NgmX2og/T9aQP+ur+u2PXQhl2NYE/Unetm 4jqsReE0nodh9TbXzikRHostyJq7eFzCo/abQlupr08GX2yK1BFZKwDBq1uPieK6Yf0s UQ5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:mime-version:user-agent:date:message-id:organization :autocrypt:from:references:to:subject; bh=YRhFQ2ZPx+LBjibZfFtd3E8z06lSxK//FslGjo7+FXg=; b=Fo32kU1cNiv9qU6erGPjuzMPNWx2e6vPXNITbRNfU1DS/a7jejFpP+zFFzBW1eaqL4 C4Ui5h/BMVHFeO6a8S/vudCwgp0+9E8w4GvPbWgAnbcASl5n6ONHtykRYkucvr9OeuYG e0QCBqd7/de080sJUbdomTIZXVUG6kXqGS8qL/hn70T0yXlJuuPthmjYggKxxWWBgYfe PO3OLvghAlMFVSb+vsEXghWG64itt1Yg+hl72bNRK0vDFEVR9YVqjLQyoyh1Fjo1q4oZ J5UXYlaet1iCkjhcU51JuM1aT7JfKuU4DJ5myCEUCzfXpE5/UCdDo+0tYGawWgztpGdj 8XyA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id b13si175104lfc.1.2020.07.01.09.33.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Jul 2020 09:33:22 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=212.18.0.9; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 49xmxZ3rW5z1qs0m; Wed, 1 Jul 2020 18:33:22 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 49xmxZ3f8zz1r575; Wed, 1 Jul 2020 18:33:22 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id MoI1-AnCDAWv; Wed, 1 Jul 2020 18:33:21 +0200 (CEST) X-Auth-Info: GVeOauMV4NhdgY7s2jELqRd6GiAGuD4veRJ/Nv5M7Hc= Received: from [10.88.0.186] (dslb-090-186-059-007.090.186.pools.vodafone-ip.de [90.186.59.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 1 Jul 2020 18:33:21 +0200 (CEST) Subject: Re: [PATCH] rootfs: Report progress for postprocessing steps To: Harald Seiler , isar-users@googlegroups.com References: <20200701143832.1113534-1-hws@denx.de> From: Claudius Heine Autocrypt: addr=ch@denx.de; keydata= mQINBFSuWugBEADI18RqDRNsXrWtQBuI60knLMfJ6j26C4ArB5ht4TzTQg9PfTJf1BwKUMYH 1s5qKikAX1mAFm7ca4uxc8uY1AdTFKepNp6ewcRShWPFo1+7DJcTlS1O+cIUyOeo6yrMMI2D DeILzcird0ATI+v7QzO1TmAmEGB28kp9KozZqFKS28p6/GLJ8qCYo50MpacsB0oi8pUeU6+8 KUlKfDDNZvwM+7rVlshOdp0iuAe12IH4gePkXycTm/PvCdqpvm6Uc0FryYh2AzB78Zvzpysb VTdGzFYavdLJJjNifj1XKgeRayR1UG0dMpcUwzLxqRmeRN1Ca7/NVT/NUHm8r80ta6mvjDHj 0vHWfn0CFgfikRtB4tftWmsvYs8YtDtR7X4gaYk5CHhR9iAGU2zElYp2Q417oe1FuXn0eFxG 1SzENtFdUZv64oQSOblJ9ZKslXLBlwCLacSdNK499IEs03UAaTPgh5L/t8G81FDeXduFt129 h6UY6Si2xDYE9wZ90XGag7Uv0wC2LKyOWzEgeOJDIGjQVAMlcr5i6nNa30n/qMTWSf+jahLa 7cr8Mgzw0W9lSAX1CytJJjh5hTHF/atZkl6+vInHJLTtBA2leRF7og2H6PHfUmpJ/A46x71l rODfqjq4/ZblSgqgQCU3rXq8bPwnl7zo/dlyqYUPVAJQ79m9jwARAQABtBtDbGF1ZGl1cyBI ZWluZSA8Y2hAZGVueC5kZT6JAlUEEwEKAD8CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheA FiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAl4pTU4FCQtcJeYACgkQEXPLGZgIsVM+ow//beDC TngJxFrJIgYqHKe93kMBUNjeY9X96nYxELg2dtQQXVeMx+CWsZymP4B9UVXQLGti9ZStKuOB HHlxfVGttwdNeQ1BjjeO9TNJNS0T1jSfz+j/lmSuoCGveojONse2/MOwMNRHtfrkws0JoM1L X3oZkv5JGXDQ51ZVIKXe2+aqIu7oouYpGsDYhxyP2tMhS3J/BHjFDjtQu1H/w64Hq28oa2aY 44prBgz0eCS8V88nlbFPc8K0nZNQYxb0bFcm4VuEHqpSHwbr6Gll9zXVpiOUddv/kbghsz3l u1/7k5Va5ZtRMumhnids5ttmrOIEib+GjpukWGUgZaukF0SNHxhHoAiyklgjEAPMJXYUZjw6 PEUMY+ocYMOgU7uZVLu8rWyCztE0/MW/JawfX/jPAUSRWluA8mP6UNkJDQmuquoaDAv1cQCH h8te/W+Rqa5xYCJCx5B4jEa8Kxmdq6kaWxU2/RXLAHypssiO5Y1XRhDImSjG2SEwJ3nzVpP5 Rd0lDhuoz+UnyidB5Np0tAvQ/4dq4XXxg7/dze0isi58GDtUxMDvtbOnmH2Y/AwxWiM4bC2B gq3JOuG4zAhWFbTG8WHirsvvkzdNXwCyepcR+2jzj1v80k3YqZOYE05POhr0dqeGPFAJJdxl TzwsLPp1z+fsE2nr9jAGd/rLNQ0YCzC5Ag0EVK5a6AEQANbSW8FeAXDMaL26JYiaWriOCB4g zqSIGXPjy1pdtS3dghks2WvADdoUuXBE6ZdbEGl+3QUlXhv167iY1M48oOVCmBnp/ENt1D9s mYB8lby4bVfb5e6eP4VivRUKiU1S2Yvp3en6/Bnts8q6clDezcbWu8lOjzlZEgXbcUPM77r3 3knriTtjnGEGc4Blta/1ED6U00NjqZ3mxpyVT1dmafmMt2Onh6XsYUgCuuAFOkhg0hUB3ems 7NPawURj6PYDYxnbpt/qTJiKbWM6CCkPDHrHesoY/ONvCeGaxzIytaUwXJ/mi3ws36hJXSST Nfyo2W5SskPJvGyn06KXr9YMW9IyZ4AV1pIs2iJ6T1rUXlXpxZ63BMY8Ja8r58Zg5+0cOaBr IAtMCo2aPsfChHEBc3m7XBCfM8yNtvzex8SCVLa/pOVXbKmXKbseInpdtP+3EM1p3R/PjBvK bvsyesk90F6+zsyVu46JVCyqrN3RGGyZCdicFHIPfqzUAnuFIOlUYSDwqvJXMwT5XcZ1jvNR eUvYwqpIJJYumoL3V5SFu434Wu81vMLeFPEccgLW4tbqpckBdbwP8GaPVmgnCWsQhcO9KUDE bnL4nO4lNPgz94dmb579BLsoAH5VVNQONyBEBxeiQBsK3DebwCmQha3qunRc4VUJQlZm/if4 lBdkNMavABEBAAGJAjwEGAEKACYCGwwWIQRv8uWfAMa8KDHYZMERc8sZmAixUwUCXilOFQUJ C1wmrQAKCRARc8sZmAixUyC7EACZIIclsnQc9gLSLxDwBMdEIXmTOEy0tuqJ5MPLNkULH6Sz nPtNBufvkhkKgt56pxTUrxS3ARahLb6AGn8Pl0B2DDtc8SE/L16LCXElssz4VpZ51udKHDzk ijPuaeCevQdTU2Rqdvx26XZre7kQBTXGgvlJAMJlJp0SMfsQ8QdhIHtGLtQmRAzSy6cHNeHX 3HDC7jxrJlJYsmwxbViagYVd9g1D7OE3dCfv9AWqclzbCMLxL0K5QCLLpqiI89dCNKzYyL4F +Cnt98PDa5GG+VXeMB6X6nfWApR20mC1pZP7Tb3XJrEtVkDONejUgQMj9Ao1cPWndma3LAtO aWcenPIPjYQ5Ab38rlE9hEHBfWSC7NriRvCEID7jDmcNG+4j5shKexz7KBoM+Kdr1WjUb3h5 TemrZycE3JGQ4GK46FwRp2O6F4mnrmNdVpnFRT+ilwZ5HOhxKqi8MslDlWmfu6m15JZSvv48 sBWpuXSbJlAKtJkuHVf45gejesDEqG89wE3xGuEnoMsn3+1rpcdLlsXtGuY8fXV4nlPw6Y8e iMuaOyn8qWvxczORDrWk1ZfRlUyV64LDDnbosHoxGLxZ1hf7V6VBtwPqngij2rsMTnCOD11y 3V3xxZAIv7Im43MsUbhZe2andR4UCQFE6NKWG5yHZtCC51APbLwM4ryINad1LA== Organization: Denx Software Engineering Message-ID: Date: Wed, 1 Jul 2020 18:33:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200701143832.1113534-1-hws@denx.de> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eKkLtuKyyf6pLCr84CKXRyuK2DlPQtiwK" X-TUID: SgeIUTTRe1Xu This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eKkLtuKyyf6pLCr84CKXRyuK2DlPQtiwK Content-Type: multipart/mixed; boundary="GzmlbGxTKYWLVMnAsZZbGLIOqChE1XEvo" --GzmlbGxTKYWLVMnAsZZbGLIOqChE1XEvo Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Harald, On 2020-07-01 16:38, Harald Seiler wrote: > Use a ProgressHandler to report how far postprocessing has progressed. > Because we can't know the exact timing of all postprocessing tasks, the= > percentages are split evenly for all steps. I think I wanted to do this myself at some point. So great that I don't have to ;) I think I would probably have used the MultiStageProgressReporter here as well, like with it is done in `do_rootfs_install` and just entered some measured values for the tasks I got locally as weights. The idea is that the weights are just a rough indicator. Since `do_rootfs_install` has some tasks that take much longer than others, it sort of makes sense. If the postprocessing tasks are mostly equal, then the ProgressHandler is ok. Maybe you can just try measuring it with the MultiStageProgressReporter and then decide. IIRC, I though at that time that the post-process tasks are finished pretty fast and so decided not to invest the time to add a progress bar. But its long ago, so I might be mistaken. regards, Claudius >=20 > Signed-off-by: Harald Seiler > --- > meta/classes/rootfs.bbclass | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index 806e824c825a..889272e7bee4 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -248,12 +248,16 @@ python do_rootfs_postprocess() { > # removed on a previous execution of this task: > bb.build.exec_func('rootfs_do_qemu', d) > =20 > + progress_reporter =3D bb.progress.ProgressHandler(d) > + progress_reporter.update(0) > + > cmds =3D d.getVar("ROOTFS_POSTPROCESS_COMMAND") > if cmds is None or not cmds.strip(): > return > cmds =3D cmds.split() > - for cmd in cmds: > + for i, cmd in enumerate(cmds): > bb.build.exec_func(cmd, d) > + progress_reporter.update(int(i / len(cmds) * 100)) > } > addtask rootfs_postprocess before do_rootfs > =20 > --GzmlbGxTKYWLVMnAsZZbGLIOqChE1XEvo-- --eKkLtuKyyf6pLCr84CKXRyuK2DlPQtiwK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAl78us0ACgkQEXPLGZgI sVMS4w//WedO+KTcxTNPZRpugvMn16XjksQ0gWqgoBju4C25kG9zAEiFwgUj2FvY /VDTG7LB+NClMI5RvM31m655Kz347psPA65Mms6IBDpfi86djxCRn+NKiOPHOlR/ zzto2gE/JJ5BvnZ4X5/m60nwou1J3R442mZ/T/VcTwM7lxu9IuHmbU80mfYFQZCM 0x1BPJlIZ6/6oQrZWg61gPrjuiI79uogeg041S5iuV74Pf9vyVJz0p9thfi3l1Ik xS3K2LZEn8n5BDRqT0FIu/jO6Xo/VMCUYGRiuWa6++lyUAFa4GclbmKwJaJKzxHI j9RvQfhUA7HXVzZeOPaJy1xoG4m61+09CW8W9I3vKQ+332IaArID1tFwB1Jsq2aR PXXi/e48Ed4RNK35Q2QgYHy9/pEI2anQ5zxk4/UJGTzHvZUUf2sxW2OpthZJ53YR ljoJgb7THxddVm+O6+/8wolQojdvczYm/yie7jet8oow5H4PIgTfwDuY3joyKzkY 61tTggQadr/J+xTRZ5sZ0a3fTwLEcYQqi3dHE4sqVrWMkEBhp/2SaCtNDm9398iw LOx6ATuIffOXmH5E2+UI3aBkQuha0gdheeyQGB77W1cwG3mHqmQp9Y1PWw/OcbKt 590YRYnC6LQXgYZrDVfID+dbj2aCpQuW5Lb1ZOXZITDTmn1hNDY= =86mK -----END PGP SIGNATURE----- --eKkLtuKyyf6pLCr84CKXRyuK2DlPQtiwK--