From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: Quirin Gylstorff <quirin.gylstorff@siemens.com>,
isar-users@googlegroups.com, felix.moessbauer@siemens.com,
cedric.hombourger@siemens.com
Subject: Re: [RFC PATCH 5/5] initramfs: allow to set the generator command
Date: Fri, 5 Sep 2025 14:52:10 +0200 [thread overview]
Message-ID: <e9c7ad61-0fed-4d9b-b63a-084186c3ccfd@siemens.com> (raw)
In-Reply-To: <f0106581-8925-422d-8488-a18523081b24@siemens.com>
On 05.09.25 14:41, Quirin Gylstorff wrote:
>
>
> On 9/5/25 14:32, Jan Kiszka wrote:
>> On 05.09.25 13:27, Quirin Gylstorff wrote:
>>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>>
>>> This allows to exchange the initramfs generator.
>>>
>>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>> ---
>>> meta/classes/initramfs.bbclass | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/classes/initramfs.bbclass b/meta/classes/
>>> initramfs.bbclass
>>> index 658ef0ac..f9c919de 100644
>>> --- a/meta/classes/initramfs.bbclass
>>> +++ b/meta/classes/initramfs.bbclass
>>> @@ -10,6 +10,7 @@ INITRAMFS_INSTALL ?= ""
>>> INITRAMFS_PREINSTALL ?= ""
>>> INITRAMFS_ROOTFS ?= "${WORKDIR}/rootfs"
>>> INITRAMFS_IMAGE_NAME = "${INITRAMFS_FULLNAME}.initrd.img"
>>> +INITRAMFS_GENERATOR_PKG ??= "initramfs-tools"
>>> INITRD_DEPLOY_FILE = "${INITRAMFS_IMAGE_NAME}"
>>> # Install proper kernel
>>> @@ -26,6 +27,6 @@ DEPENDS += "${INITRAMFS_INSTALL}"
>>> ROOTFSDIR = "${INITRAMFS_ROOTFS}"
>>> ROOTFS_FEATURES = "generate-manifest"
>>> -ROOTFS_PACKAGES = "initramfs-tools ${INITRAMFS_PREINSTALL}
>>> ${INITRAMFS_INSTALL}"
>>> +ROOTFS_PACKAGES = "${INITRAMFS_GENERATOR_PKG}
>>> ${INITRAMFS_PREINSTALL} ${INITRAMFS_INSTALL}"
>>> inherit rootfs
>>
>> Do we need extra safety belts for the case that users create custom
>> initramfs hooks and set the wrong INITRAMFS_GENERATOR_PKG?
>
> I am not sure if this will survive the next iteration. Reusing the
> initramfs class for dracut initrd leads to major pains if using in
> layers where the INITRAMFS_(PRE)INSTALL is set by *.conf.
No, it's really about flagging / preventing unsupported combos. We will
continue to support initramfs-hooks for a longer while, backward
compatibility. But now user should not try to generate custom initramfs
with those hooks while having switched to a different generator.
>
> My current plan is to split it up and create a base class.
We will probably need completely different helpers to create custom
dracut modules, no?
Jan
--
Siemens AG, Foundational Technologies
Linux Expert Center
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/e9c7ad61-0fed-4d9b-b63a-084186c3ccfd%40siemens.com.
next prev parent reply other threads:[~2025-09-05 12:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 11:27 [RFC PATCH 0/5] Add support for dracut 'Quirin Gylstorff' via isar-users
2025-09-05 11:27 ` [RFC PATCH 1/5] enable-fsck: remove dependency to initramfs-tools 'Quirin Gylstorff' via isar-users
2025-09-05 12:25 ` 'Jan Kiszka' via isar-users
2025-09-05 12:38 ` 'Jan Kiszka' via isar-users
2025-09-05 11:27 ` [RFC PATCH 2/5] add dracut to custom kernel builds 'Quirin Gylstorff' via isar-users
2025-09-05 11:27 ` [RFC PATCH 3/5] rootfs: Allow to overwrite the initramfs generation cmds 'Quirin Gylstorff' via isar-users
2025-09-05 12:29 ` 'Jan Kiszka' via isar-users
2025-09-05 11:27 ` [RFC PATCH 4/5] rootfs Add dracut to initramfs generator 'Quirin Gylstorff' via isar-users
2025-09-05 12:30 ` 'Jan Kiszka' via isar-users
2025-09-05 12:42 ` 'Quirin Gylstorff' via isar-users
2025-09-05 12:44 ` 'Quirin Gylstorff' via isar-users
2025-09-05 11:27 ` [RFC PATCH 5/5] initramfs: allow to set the generator command 'Quirin Gylstorff' via isar-users
2025-09-05 12:32 ` 'Jan Kiszka' via isar-users
2025-09-05 12:41 ` 'Quirin Gylstorff' via isar-users
2025-09-05 12:52 ` 'Jan Kiszka' via isar-users [this message]
2025-09-05 13:03 ` 'Quirin Gylstorff' via isar-users
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9c7ad61-0fed-4d9b-b63a-084186c3ccfd@siemens.com \
--to=isar-users@googlegroups.com \
--cc=cedric.hombourger@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=quirin.gylstorff@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox