From: "Maxim Yu. Osipov" <mosipov@ilbers.de>
To: claudius.heine.ext@siemens.com, isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: Re: [PATCH v2] image.bbclass: allow ISAR_RELEASE_CMD that produce space seperated vals
Date: Thu, 6 Sep 2018 22:47:34 +0200 [thread overview]
Message-ID: <e9eb9fef-cbb5-9cc3-ba0e-a05b8fdd38cf@ilbers.de> (raw)
In-Reply-To: <20180905091356.8175-1-claudius.heine.ext@siemens.com>
On 09/05/2018 11:13 AM, claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
>
> Directly using `get_build_id` inside quotes resulted in an empty string,
> so we take the detour via a variable.
Applied to the 'next',
Thanks,
Maxim.
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
> meta/classes/image.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 6a5f0e9..ad78347 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -74,8 +74,9 @@ addtask rootfs before do_build after do_unpack
> do_rootfs[deptask] = "do_deploy_deb"
>
> do_mark_rootfs() {
> + BUILD_ID=$(get_build_id)
> update_etc_os_release \
> - --build-id $(get_build_id) --variant "${DESCRIPTION}" \
> + --build-id "${BUILD_ID}" --variant "${DESCRIPTION}" \
> "${IMAGE_ROOTFS}"
> }
>
>
--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
prev parent reply other threads:[~2018-09-06 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 7:18 [PATCH] " claudius.heine.ext
2018-09-05 9:13 ` [PATCH v2] " claudius.heine.ext
2018-09-06 20:47 ` Maxim Yu. Osipov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9eb9fef-cbb5-9cc3-ba0e-a05b8fdd38cf@ilbers.de \
--to=mosipov@ilbers.de \
--cc=ch@denx.de \
--cc=claudius.heine.ext@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox