From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6597636282865680384 X-Received: by 2002:a1c:c00b:: with SMTP id q11-v6mr360087wmf.5.1536266859115; Thu, 06 Sep 2018 13:47:39 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:7a0a:: with SMTP id v10-v6ls1583798wmc.9.canary-gmail; Thu, 06 Sep 2018 13:47:38 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYMyFouS5LLDSW0jNnA1J82cFJZWWd2UAVguvo6lj3Pjw/85SWNMb/+ZhUu1QNQTQDtoloF X-Received: by 2002:a1c:af51:: with SMTP id y78-v6mr369341wme.26.1536266858750; Thu, 06 Sep 2018 13:47:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536266858; cv=none; d=google.com; s=arc-20160816; b=a24ZJYPo0V7lBXCV0IUYlGfFS+3B3/lxWWhbwgxz6A9kLiCaX6IaE4VwM2EpLHo46S wJZfj3x27aw4it1HqUB/rLTsGCdmVgvpKSaf7icg11jZ4AQPqforTTtHppDyMWxRYGKq 5s43sHQGak+Rwtw5Cpe3RjG2mRbNq3uI7nVfNt3glTEaFgeVraP9X5uHcfZ2ekocm+cf iRRdf5tQ/kxIQmIFFSYdmDlE4cnW5Jo8r1/SFb3+dojO40GPkfObZv6583+u6zTTvU41 TJNsM732Ymu/4TZDsGYI/Pu+AawwkFYscVxRLnNq+LwTRkwtkXHOd4p1BiqzPGCAn7Ru BweA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=mbr+Nrq9H/MCT7YxRn8yNAL/BcRTKTLQd0ZaZ78gopI=; b=JcMUff7mjWKmUEivzh8lv8nxMwHPZ/N8VP43lb82PjxxchABqVQroSnwkEgL7h4YlY RfWlUiPt4cGZkU9OzgtUeA+BItoJisVmyyWrZCIXeXTMWMPsRHWbBy8utYYyiu0bq4eX iDI8UXUHIhQR9E1QEm/ZPdAEZQuN4NOWkkdc6tB0h1g4PHZUiX1YCtqG2j9yGDpK2wq0 IGji4CXWTaaa6PWmnDK1QM79kbTwXcTY6hFXnbmFpIAExv0UO0dBIlj4c9bHp4kVdEAo qQu4tHhebqwmSAMNsW2BHfoyJZxK4Y+3Kj41yAYQ7Pjz7a2PLHxyu31i6Rkc9Rs1Fd4a pQZw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id l2-v6si154365wmh.1.2018.09.06.13.47.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Sep 2018 13:47:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.180] (d51A48A80.access.telenet.be [81.164.138.128]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w86KlY0E016907 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 6 Sep 2018 22:47:35 +0200 Subject: Re: [PATCH v2] image.bbclass: allow ISAR_RELEASE_CMD that produce space seperated vals To: claudius.heine.ext@siemens.com, isar-users@googlegroups.com Cc: Claudius Heine References: <20180905071812.26252-1-claudius.heine.ext@siemens.com> <20180905091356.8175-1-claudius.heine.ext@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: Date: Thu, 6 Sep 2018 22:47:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180905091356.8175-1-claudius.heine.ext@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: h67biE4OySuR On 09/05/2018 11:13 AM, claudius.heine.ext@siemens.com wrote: > From: Claudius Heine > > Directly using `get_build_id` inside quotes resulted in an empty string, > so we take the detour via a variable. Applied to the 'next', Thanks, Maxim. > Signed-off-by: Claudius Heine > --- > meta/classes/image.bbclass | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 6a5f0e9..ad78347 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -74,8 +74,9 @@ addtask rootfs before do_build after do_unpack > do_rootfs[deptask] = "do_deploy_deb" > > do_mark_rootfs() { > + BUILD_ID=$(get_build_id) > update_etc_os_release \ > - --build-id $(get_build_id) --variant "${DESCRIPTION}" \ > + --build-id "${BUILD_ID}" --variant "${DESCRIPTION}" \ > "${IMAGE_ROOTFS}" > } > > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov