public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Schaffner, Tobias" <tobias.schaffner@siemens.com>,
	isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] Fail on errors in chroot subshell
Date: Tue, 25 Oct 2022 10:13:29 +0200	[thread overview]
Message-ID: <ea9e12d4-cd81-e685-e8a0-c6ebb8dcd27e@siemens.com> (raw)
In-Reply-To: <2d61f5bf-f945-a13e-4c4c-305bd7c39ecc@siemens.com>

On 25.10.22 10:09, Schaffner, Tobias wrote:
> Let the chroot subshell in the image locales extension fail on errors.
> 
> Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
> ---
>   meta/classes/image-locales-extension.bbclass | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/image-locales-extension.bbclass b/meta/classes/image-locales-extension.bbclass
> index 2db6d4a..01163bb 100644
> --- a/meta/classes/image-locales-extension.bbclass
> +++ b/meta/classes/image-locales-extension.bbclass
> @@ -77,6 +77,7 @@ __EOF__
>   
>           # Enter image and trigger locales config and localepurge:
>           chroot '${ROOTFSDIR}' /bin/sh <<'EOSH'
> +            set -e
>   
>               echo 'running locale debconf-set-selections'
>               debconf-set-selections /tmp/locale.debconf

Broken indention - possibly a sign more more formatting issues?

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux


      reply	other threads:[~2022-10-25  8:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25  8:09 Schaffner, Tobias
2022-10-25  8:13 ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea9e12d4-cd81-e685-e8a0-c6ebb8dcd27e@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=tobias.schaffner@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox