public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] Fail on errors in chroot subshell
@ 2022-10-25  8:09 Schaffner, Tobias
  2022-10-25  8:13 ` Jan Kiszka
  0 siblings, 1 reply; 2+ messages in thread
From: Schaffner, Tobias @ 2022-10-25  8:09 UTC (permalink / raw)
  To: isar-users

Let the chroot subshell in the image locales extension fail on errors.

Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
---
  meta/classes/image-locales-extension.bbclass | 1 +
  1 file changed, 1 insertion(+)

diff --git a/meta/classes/image-locales-extension.bbclass b/meta/classes/image-locales-extension.bbclass
index 2db6d4a..01163bb 100644
--- a/meta/classes/image-locales-extension.bbclass
+++ b/meta/classes/image-locales-extension.bbclass
@@ -77,6 +77,7 @@ __EOF__
  
          # Enter image and trigger locales config and localepurge:
          chroot '${ROOTFSDIR}' /bin/sh <<'EOSH'
+            set -e
  
              echo 'running locale debconf-set-selections'
              debconf-set-selections /tmp/locale.debconf
-- 
2.34.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fail on errors in chroot subshell
  2022-10-25  8:09 [PATCH] Fail on errors in chroot subshell Schaffner, Tobias
@ 2022-10-25  8:13 ` Jan Kiszka
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kiszka @ 2022-10-25  8:13 UTC (permalink / raw)
  To: Schaffner, Tobias, isar-users

On 25.10.22 10:09, Schaffner, Tobias wrote:
> Let the chroot subshell in the image locales extension fail on errors.
> 
> Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
> ---
>   meta/classes/image-locales-extension.bbclass | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/image-locales-extension.bbclass b/meta/classes/image-locales-extension.bbclass
> index 2db6d4a..01163bb 100644
> --- a/meta/classes/image-locales-extension.bbclass
> +++ b/meta/classes/image-locales-extension.bbclass
> @@ -77,6 +77,7 @@ __EOF__
>   
>           # Enter image and trigger locales config and localepurge:
>           chroot '${ROOTFSDIR}' /bin/sh <<'EOSH'
> +            set -e
>   
>               echo 'running locale debconf-set-selections'
>               debconf-set-selections /tmp/locale.debconf

Broken indention - possibly a sign more more formatting issues?

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-25  8:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-25  8:09 [PATCH] Fail on errors in chroot subshell Schaffner, Tobias
2022-10-25  8:13 ` Jan Kiszka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox