Re: [PATCH 0/4] apt configuration fixes

[Jan Kiszka <jan.kiszka@siemens.com>]

On 21.02.22 21:30, Henning Schild wrote:
> Am Mon, 21 Feb 2022 20:20:21 +0100
> schrieb Jan Kiszka <jan.kiszka@siemens.com>:
> 
>> On 21.02.22 17:12, Henning Schild wrote:
>>> Am Mon, 21 Feb 2022 12:24:09 +0300
>>> schrieb Anton Mikanovich <amikan@ilbers.de>:
>>>   
>>>> 5.02.22 18:15, henning.schild@siemens.com wrote:  
>>>>> This attempts to solve the apt fetch retry problem in a better
>>>>> way. On the way it was found that bootstrap leaves a file around,
>>>>> which probably should not remain in images.
>>>>>
>>>>> Henning Schild (4):
>>>>>    rootfs: configure apt to always retry downloads
>>>>>    Revert "deb-dl-dir: Retry downloads 3 times for src files"
>>>>>    Revert "rootfs: Retry downloads 3 times"
>>>>>    bootstrap: do not leave 50isar.conf in final rootfss
>>>>>
>>>>>   meta/classes/deb-dl-dir.bbclass                |  2 +-
>>>>>   meta/classes/image.bbclass                     |  1 +
>>>>>   meta/classes/rootfs.bbclass                    | 18
>>>>> +++++++++++++++++- .../isar-bootstrap/files/isar-apt.conf
>>>>> | 2 -- .../isar-bootstrap/isar-bootstrap.inc          |  5 +----
>>>>>   5 files changed, 20 insertions(+), 8 deletions(-)
>>>>>   delete mode 100644
>>>>> meta/recipes-core/isar-bootstrap/files/isar-apt.conf   
>>>> Applied to next, thanks.
>>>>  
>>>
>>> Thanks! I see only now that the "From:" in my emails was messed
>>> with by the SMTP server i am now forced to use. Any chance we can
>>> force-push next to fix that?
>>>
>>> What i did send and wanted was 
>>> "Henning Schild <henning.schild@siemens.com>" but what came out is
>>> "henning.schild@siemens.com <henning.schild@siemens.com>"
>>>   
>>
>> I heard these complaints from other as well. Since our servers started
>> rewriting but also because of me sometime using different servers, I
>> *always* force git to inject a From: line into the commit messages.
>> That makes you independent of those manglings.
> 
> How do you force git? I am using my own force since a couple of years
> ... not sure why it failed this time.
> 
> https://github.com/henning-schild/git/commit/ca44f026a31537477e66559f0bf0f3acd2deecdf
> 
> I should probably go ahead and mainline that or something similar.

git format-patch --form="bla"
  -> adds "From:" to body (unless you committed as "bla")
git send-email --from="real@user.com"

> 
>> BTW, my local maintainer tool tries to detect such cases, at least
>> when there is also a signed-off line, and that one differs from the
>> author's line.
> 
> Maybe such a tool should not remain "local", but really it should not
> be required if mail servers would simply send what they are told to.

https://addons.thunderbird.net/de/thunderbird/addon/copy-patch/

Jan

> 
> In fact i will likely switch to sending from "@hennsch.de" soon, not
> caring anymore.
> 
> regards,
> Henning
> 
>> Jan
>>
> 

-- 
Siemens AG, Technology
Competence Center Embedded Linux