Re: [PATCH 3/8] isar-events: Do not match on distro and arch

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2018-02-19 10:54, Alexander Smirnov wrote:
> On 02/16/2018 11:52 AM, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> There might be operations in flight that are mounting more for a
>> particular $distro-$arch when the completion event arrives. Simply
>> trying to umount everything under the TMPDIR increases the chance to
>> catch them later, e.g. because we have to wait for some mount point to
>> become free.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>   meta/classes/isar-events.bbclass | 6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta/classes/isar-events.bbclass
>> b/meta/classes/isar-events.bbclass
>> index 68208f1..29c7437 100644
>> --- a/meta/classes/isar-events.bbclass
>> +++ b/meta/classes/isar-events.bbclass
>> @@ -27,11 +27,9 @@ python isar_handler () {
>>         if isinstance(e, bb.event.BuildCompleted):
>>           tmpdir = d.getVar('TMPDIR', True)
>> -        distro = d.getVar('DISTRO', True)
>> -        arch = d.getVar('DISTRO_ARCH', True)
>>   -        if tmpdir and distro and arch:
>> -            basepath = tmpdir + '/work/' + distro + '-' + arch
>> +        if tmpdir:
>> +            basepath = tmpdir + '/work/'
> 
> It would be nice to comment your idea inline here.
> 
> In general commit message already contains the description, but I assume
> that there could be lots of new commits for this file in the future. So
> it will be unnecessary complication to find these clues. :-)

I agree when comments help explaining non-obvious parts of the code. I
disagree in this case. Morever, there is git blame.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux