From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6523072403514327040 X-Received: by 10.223.141.150 with SMTP id o22mr317448wrb.24.1519038517467; Mon, 19 Feb 2018 03:08:37 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.136.117 with SMTP id e50ls2145837wre.3.gmail; Mon, 19 Feb 2018 03:08:36 -0800 (PST) X-Google-Smtp-Source: AH8x225nY3H77zPLyZ5rdAXkDe4YjmpY4DzVrUrN1mK/Jd682WqzEt8vNq65VXClxwhwiJfr2gKm X-Received: by 10.223.141.150 with SMTP id o22mr317442wrb.24.1519038516853; Mon, 19 Feb 2018 03:08:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519038516; cv=none; d=google.com; s=arc-20160816; b=WI3Jd2d4hHOlg7eexiPJZKPqyG5JCJHnswjDs+NowXoYaUnDixwJ8wJMW2WPZgLsQ6 68Z+to4dIz5+JvQ3rDzWN20BmR9Khc30rJ5JLyK58AxzOb/sKSX2WztUtEJkzOe2zpBx AnNP00BlCCeLI7IFn2gasbn9kQ8Jiy2PyCdFXSN4krYnlhpfa0Q7QzfJaWbElrfYPrdH rPsXsBt5k0TzgklnsMmyh4Uju+cZaTskwLryDim8z4Qfp1TQQcrFxpwQCnHGyP1m4gVT qKCOOdPhEBpwbqSGoEoDRfLZ93FEvYtHitH1Usv1Kg4/Y6CO3+PddQeAm1gPldqfzNsr 5Q7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=numlcwvoKxyZYC9eOjZ6BnfBlEZAuJZlvDGE/IEtoD0=; b=W713dbR94/aZ0t9pyHBjyJupDyVcdINyMzFLymxzmydCMuiW3oNDTnxp3CXIpGoCm8 hQGAlLGvEXbnNCfNgpO+5mlajYBFiXdYVdnq3H/JPczIkmgd+C9q8gx1U7bZ0ruAU/AR G3jmeVn/v67VpYc4uzNX0nzOg3okYEnToemmVV2BDh2L9foPXBg18yfmi9KzIHGwGByP PcZbjEiymY+LalSstszRCAnuKUFntVGDNOh8kW3ovKPky+00Apj7cX/jv7t9JrFpfztR 6QaZyOUbeFj0mybCIF9HR2tdcHTEbGTryZDVuEegIrVhlew/DxpevlBc7sjuvghx9dMp GOJA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id s81si1327031wmd.2.2018.02.19.03.08.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Feb 2018 03:08:36 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w1JB8amY024074 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Feb 2018 12:08:36 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w1JB8aXI017941; Mon, 19 Feb 2018 12:08:36 +0100 Subject: Re: [PATCH 3/8] isar-events: Do not match on distro and arch To: Alexander Smirnov , isar-users References: <2fe1c09e-a28e-58c8-559b-135a7005584f@ilbers.de> From: Jan Kiszka Message-ID: Date: Mon, 19 Feb 2018 12:08:35 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <2fe1c09e-a28e-58c8-559b-135a7005584f@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: awrWWDmHfMSp On 2018-02-19 10:54, Alexander Smirnov wrote: > On 02/16/2018 11:52 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> There might be operations in flight that are mounting more for a >> particular $distro-$arch when the completion event arrives. Simply >> trying to umount everything under the TMPDIR increases the chance to >> catch them later, e.g. because we have to wait for some mount point to >> become free. >> >> Signed-off-by: Jan Kiszka >> --- >>   meta/classes/isar-events.bbclass | 6 ++---- >>   1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/meta/classes/isar-events.bbclass >> b/meta/classes/isar-events.bbclass >> index 68208f1..29c7437 100644 >> --- a/meta/classes/isar-events.bbclass >> +++ b/meta/classes/isar-events.bbclass >> @@ -27,11 +27,9 @@ python isar_handler () { >>         if isinstance(e, bb.event.BuildCompleted): >>           tmpdir = d.getVar('TMPDIR', True) >> -        distro = d.getVar('DISTRO', True) >> -        arch = d.getVar('DISTRO_ARCH', True) >>   -        if tmpdir and distro and arch: >> -            basepath = tmpdir + '/work/' + distro + '-' + arch >> +        if tmpdir: >> +            basepath = tmpdir + '/work/' > > It would be nice to comment your idea inline here. > > In general commit message already contains the description, but I assume > that there could be lots of new commits for this file in the future. So > it will be unnecessary complication to find these clues. :-) I agree when comments help explaining non-obvious parts of the code. I disagree in this case. Morever, there is git blame. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux