Re: [PATCH 0/3] umount fixes and cleanups

[Jan Kiszka <jan.kiszka@siemens.com>]

On 05.12.18 13:48, Hombourger, Cedric wrote:
> Hi Jan,
> 
> In my testing, the only mounts that were really needed for the go packages I was building are:
> 
> /dev		# was already mounted before our changes
> /dev/pts	# was not mounted before
> /sys		# was not mounted before
> 
> I have some doubts about /dev/shm; I cannot recall if that one was truly needed

OK, but then I would suggest, when reverting the bind mount, to add /dev/pts and 
(to be safe) maybe also /dev/shm explicitly and umount them also explicitly.

And then we should finally consolidate common mount and umount for chroots into 
one central helper each.

> 
> Regarding ordering, this brute force umount command will produce errors for sub-mounts (e.g. when trying to umount /sys/fs/cgroup before /sys/fs/cgroup/blkio)
> I seem to remember that in the early days Isar would just loop over its mounts until it got rid of everything

OK, so this targets isar_handler() only. But we also have (and need) umounts 
elsewhere.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux