From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6631438923266523136 X-Received: by 2002:a1c:55c8:: with SMTP id j191mr2649896wmb.13.1544014456382; Wed, 05 Dec 2018 04:54:16 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:149:: with SMTP id r9ls6261523wrx.7.gmail; Wed, 05 Dec 2018 04:54:15 -0800 (PST) X-Google-Smtp-Source: AFSGD/WOCnvg+6Fdwx9zc7XuuByzSSC4qUbs28PevGxpnXlDq9ny9Bzn1DPjy0tw6adBH/1AG2C7 X-Received: by 2002:a5d:50c6:: with SMTP id f6mr2377488wrt.10.1544014455807; Wed, 05 Dec 2018 04:54:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544014455; cv=none; d=google.com; s=arc-20160816; b=scGfhzdVeU6peX1GShnbqzWb4kR+IRVwdAnAqwX5uzGNv3bxBx/Gluw4VFTfTpxub5 xR1tJvIwODIL2ZMWln0PR+hOmxzkxu+8/DA7/34ULlfmFkLOs9vqQJX1OKIfnwokltrM nGXx8OLDc7+jf2w2UGip/FBKC8sEbLMrMs+apupJ7ejkVNFuiiRRpOTwpRdl7MfznyqB bT0PXhtVM5YKKifANmp5KRbLbuCsO5moz7Aq/jYFhStMsNfe9PHl5VbJPnuFedCJ/V0G ZOHnoBnFSkhIWXqSFutQZFnA9qBeTCru6ZMJptEMJOHyHfKzkXVrF+W1pbaO3sWHpqst fx/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=oLmlHHhjNNPEhnQGZMGzpuVADD/ZD7er8Y5Ueq3u1dE=; b=bGh5qIoCIphbEMcv1ztvA5fRmnDpFbShN1EbxsSsclufaT2PAngd71AmWnXhA19Sr4 6MDS7WgTQ2kxnBsV9fsExtRfOybXj3e9raUEZF3sL+IsWEPmL7NgN3mRnQwRKg5GCX+E OwwlG9k6r1TkDmHbXCOCbtPjAn9LjDxjsWA3eQumFeRqxhtrMWsVm7Gykr1dLIPKRrtw q7V0Jb9TVIqG5yPWAGeNKL/ZeZ9WL6jsuDAg+tCB9ZEyr3XX2gCY0wAFaEd9hgufeO16 RGZWDm2imOUv84ZCdNeAKSWA1emk/5zv1O8xTFxmARpYImbIYEEEhnrRhHOYc41Gp75p 4hnw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id p19si633492wmc.0.2018.12.05.04.54.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 04:54:15 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id wB5CsFgK028008 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Dec 2018 13:54:15 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wB5CsFJQ019881; Wed, 5 Dec 2018 13:54:15 +0100 Subject: Re: [PATCH 0/3] umount fixes and cleanups To: "Hombourger, Cedric" , "Maxim Yu. Osipov" , isar-users References: <02edaac4-fc2d-44ea-6471-52ad8fc3d421@siemens.com> <32728b629b094f79ad589524d097ffb2@svr-ies-mbx-02.mgc.mentorg.com> <814cc058724f4b2ea6e4b854afafc73e@svr-ies-mbx-02.mgc.mentorg.com> From: Jan Kiszka Message-ID: Date: Wed, 5 Dec 2018 13:54:14 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <814cc058724f4b2ea6e4b854afafc73e@svr-ies-mbx-02.mgc.mentorg.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: TWWIWGphncer On 05.12.18 13:48, Hombourger, Cedric wrote: > Hi Jan, > > In my testing, the only mounts that were really needed for the go packages I was building are: > > /dev # was already mounted before our changes > /dev/pts # was not mounted before > /sys # was not mounted before > > I have some doubts about /dev/shm; I cannot recall if that one was truly needed OK, but then I would suggest, when reverting the bind mount, to add /dev/pts and (to be safe) maybe also /dev/shm explicitly and umount them also explicitly. And then we should finally consolidate common mount and umount for chroots into one central helper each. > > Regarding ordering, this brute force umount command will produce errors for sub-mounts (e.g. when trying to umount /sys/fs/cgroup before /sys/fs/cgroup/blkio) > I seem to remember that in the early days Isar would just loop over its mounts until it got rid of everything OK, so this targets isar_handler() only. But we also have (and need) umounts elsewhere. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux