From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6460145516460113920 X-Received: by 10.25.72.144 with SMTP id v138mr122774lfa.35.1504543538141; Mon, 04 Sep 2017 09:45:38 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.88.23 with SMTP id m23ls54130ljb.32.gmail; Mon, 04 Sep 2017 09:45:37 -0700 (PDT) X-Google-Smtp-Source: ADKCNb7gwFRrUNX6Axs0OGmpfwdw9SgOQo7ukwQcJbj62IjGzEsdMtc/MXOXO8zW2rlhz+6+EN6x X-Received: by 10.46.85.22 with SMTP id j22mr155521ljb.29.1504543537720; Mon, 04 Sep 2017 09:45:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504543537; cv=none; d=google.com; s=arc-20160816; b=XM1Rl0v3YPuBynlM0n653WL2Esy0/laR3N/DJVsvn3Z4Px3hQbsmiHZtZyXoBpm0Jo Oc49Nwb77rjVOFTXzqi/Cy22G7vji/9MLfQVIK5hOG4rtGYGI9NvL+E+4sIk1ZdzK39n 19/iwnzigDsDHCp/tSmz6UVT7aflzDaw1N7p4K+k5SO7Xp9a09e57nBks/U4PgXqEZ2x EhYITjK++9sx9sHykKw4cF/8sl5ZaCRp/tX6XzXUqCqlHjTSHKq+gE40UJLc+CI0578T dpHVObWXhvtXOTa0tInZ8a6N3qvBIx3L8gxTlb6/PXb5suGe4vSGccU7OdgNF+Smhi/3 PLWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=XvmEdUX0uFAa2HMYsXqpN5ly1bqDCcanIL3tEaVtjk4=; b=xV+CF0vmCCCALOucoRZp20JLYSjuuLsWREXzX8Sodr+bMYiWvgVotA8HsfsIS+sHVv gjy8eR5ug1UE8JCMbkRVrCNHWCrmEcms8DzcbO7Fpo/PsmOXD6qDfRwMF1q/gc0wrVbY rKXJkWvyBTZjS/4ikRyxJWh0K8mecgI8KPe0bbcWdqEs5FUpx7wOpt20PtxD9XlwQf5s OcbGvvjLi04np3EiQMWrWySs+2LxyJxtodgSu8hZO7uRspagFXIqru688kSx78W/bHTr LyH/2R11rDWcLxwHWS0E68LO0J1rON8DxsFF4zAo9pTRvB4dhDt61lbE1bRtLFfkx9uA fEvw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of jan.kiszka@siemens.com) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id i90si618115wmh.5.2017.09.04.09.45.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Sep 2017 09:45:37 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of jan.kiszka@siemens.com) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of jan.kiszka@siemens.com) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v84GjbHx001573 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Sep 2017 18:45:37 +0200 Received: from md1f2u6c.ww002.siemens.net ([139.25.68.37]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id v84Gjb1r012655; Mon, 4 Sep 2017 18:45:37 +0200 Subject: Re: [PATCH 2/6] meta: Move 'do_fetch' and 'do_unpack' to base-class To: Alexander Smirnov , isar-users@googlegroups.com References: <1d3a315a8ac98ba02800168b6f8bc50d95a96bb4.1504119538.git.henning.schild@siemens.com> <70c40785-daa4-e186-5b00-1d6081d1c288@siemens.com> <2bd3f3aa-2259-f074-adb6-87816b6a229a@ilbers.de> From: Jan Kiszka Message-ID: Date: Mon, 4 Sep 2017 18:45:36 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <2bd3f3aa-2259-f074-adb6-87816b6a229a@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: YHnOlVXo7U/S On 2017-09-04 18:39, Alexander Smirnov wrote: > On 09/04/2017 07:11 PM, Jan Kiszka wrote: >> On 2017-09-04 18:10, Alexander Smirnov wrote: >>> On 09/04/2017 07:03 PM, Jan Kiszka wrote: >>>> On 2017-09-04 17:14, Alexander Smirnov wrote: >>>>> On 08/30/2017 10:03 PM, Henning Schild wrote: >>>>>> Issues: >>>>>> unpack and fetch can only be used if you inherit dpkg, they should be >>>>>> available to others i.e. classes and images >>>>> >>>>> For me it's ok to move fetch to base class. Unpack has dependency from >>>>> dpkg class. >>>>> >>>> >>>> What is that dependency? >>>> >>> >>> Commented in previous patch. >> >> The previous patch makes it generic, thus independent of dpkg. I cannot >> follow you, sorry. > > Ok. Currently task unpack depends on dpkg class, because it uses > BUILDROOT variable which is defined locally in dpkg.class. So the > current task is also generic, and can be moved to base class but with > BUILDROOT variable definition. Or BUILDROOT could be defined in > bitbake.conf. > > My concern about previous patch that it doesn't make task more generic - > the content stays the same, but it changes the WORKDIR, what affects > whole Isar design. Your comment on patch 1 was delayed in my inbox, that destroyed the context for me. Well if both WORKDIR AND BUILDROOT are well defined variables, just make them omnipresent and be fine, agreed. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux