public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: "Moessbauer, Felix" <felix.moessbauer@siemens.com>,
	"Schild, Henning" <henning.schild@siemens.com>
Cc: "isar-users@googlegroups.com" <isar-users@googlegroups.com>,
	"Bezdeka, Florian" <florian.bezdeka@siemens.com>,
	"ubely@ilbers.de" <ubely@ilbers.de>
Subject: Re: [PATCH] override HOME to isolate sbuild configuration
Date: Fri, 23 Sep 2022 12:17:44 +0300	[thread overview]
Message-ID: <ec6d000d-014b-2845-75cf-e5204aa8533c@ilbers.de> (raw)
In-Reply-To: <AM9PR10MB4869F0CC974D5B9849FAE2BB894C9@AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM>

20.09.2022 14:22, Moessbauer, Felix wrote:
> I had the funny side effect that I could not build with ISAR on my sbuild + unshare enabled host.
> Had a hard time to figure out why this did not work, especially as the sbuild man page is not very precise on the effect of the SBUILD_CONFIG env var.
>
> Setting HOME there is only relevant for the sbuild invocation and also there, the HOME variable is set but quite pointless as everything happens inside the schroot.
> AFAIK there is no statement in the user_manual.md regarding the configuration of host tools.
>
> Let's put Anton in CC to get a statement from an maintainer of ISAR.
>
> Felix

Hello, Felix.

Thanks for pinging, I was sick a little bit this week, so unable to 
answer fast.

I think we can try to enable HOME override in the way like:

ISAR_BUILD_HOME ?= "${HOME}"
...
export HOME="${ISAR_BUILD_HOME}"

This will allow user to override the value if needed, but still use the 
old one by default.
And this should be also documented.


  reply	other threads:[~2022-09-23  9:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20  9:26 Felix Moessbauer
2022-09-20 10:58 ` Henning Schild
2022-09-20 11:22   ` Moessbauer, Felix
2022-09-23  9:17     ` Anton Mikanovich [this message]
2022-09-25  8:13       ` Moessbauer, Felix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec6d000d-014b-2845-75cf-e5204aa8533c@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    --cc=florian.bezdeka@siemens.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=ubely@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox