From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH v6 12/27] Detect false sharing of recipes
Date: Mon, 30 Sep 2019 18:34:02 +0200 [thread overview]
Message-ID: <ecb6c3de-c14b-0866-f68f-27c347ed4f8a@siemens.com> (raw)
In-Reply-To: <20190930153937.n4rvim46yz7k2vc4@yssyq.m.ilbers.de>
On 30.09.19 17:39, Baurzhan Ismagulov wrote:
> On Mon, Sep 30, 2019 at 05:26:07PM +0200, Jan Kiszka wrote:
>>> Ok, thanks for the explanation. You unshared the host rootfses for Debian armhf
>>> and Raspbian armhf. After that, the locks in isar_bootstrap() and
>>> do_apt_config_prepare() are indeed not necessary.
>>>
>>> Actually, sharing both was an intended optimization because the resulting host
>>> rootfses are identical. However, the implementation drops one via locking and
>>> not via bitbake pipeline, and isn't executed on config change. Not sure how
>>> difficult it would be to do that right. I can merge #9 and #10 for now.
>>
>> As the commit log stated, this assumption ("are identical") was wrong in the
>> first place.
>
> To make it clear, that was just an explanation why it had been done, I didn't
> intend to challenge your motivation.
>
> With stock Isar and your both series applied, a quick cd tmp/deploy/bootstrap;
> sudo diff -Nrq debian-stretch-host_debian-stretch-armhf
> debian-stretch-host_raspbian-stretch-armhf results in:
>
> diff: debian-stretch-host_debian-stretch-armhf/lib64/ld-linux-x86-64.so.2: No such file or directory
> diff: debian-stretch-host_raspbian-stretch-armhf/lib64/ld-linux-x86-64.so.2: No such file or directory
> Files debian-stretch-host_debian-stretch-armhf/var/cache/apt/pkgcache.bin and debian-stretch-host_raspbian-stretch-armhf/var/cache/apt/pkgcache.bin differ
> Files debian-stretch-host_debian-stretch-armhf/var/cache/apt/srcpkgcache.bin and debian-stretch-host_raspbian-stretch-armhf/var/cache/apt/srcpkgcache.bin differ
> Files debian-stretch-host_debian-stretch-armhf/var/cache/ldconfig/aux-cache and debian-stretch-host_raspbian-stretch-armhf/var/cache/ldconfig/aux-cache differ
> Files debian-stretch-host_debian-stretch-armhf/var/log/alternatives.log and debian-stretch-host_raspbian-stretch-armhf/var/log/alternatives.log differ
> Files debian-stretch-host_debian-stretch-armhf/var/log/apt/history.log and debian-stretch-host_raspbian-stretch-armhf/var/log/apt/history.log differ
> Files debian-stretch-host_debian-stretch-armhf/var/log/apt/term.log and debian-stretch-host_raspbian-stretch-armhf/var/log/apt/term.log differ
> Files debian-stretch-host_debian-stretch-armhf/var/log/bootstrap.log and debian-stretch-host_raspbian-stretch-armhf/var/log/bootstrap.log differ
> Files debian-stretch-host_debian-stretch-armhf/var/log/dpkg.log and debian-stretch-host_raspbian-stretch-armhf/var/log/dpkg.log differ
>
> I.e., no differences. For my understanding, do you have host bootstrap
> differences downstream? What are they? Maybe we could add a test case for that.
The differences can come from different HOST_DISTRO_* settings. Those are
applied on a per target distro/arch basis. Locking papered over this. And it
broke rebuilding on changes.
We didn't trigger that issue with CI, well, maybe except for the case when you
activated the bananapi.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2019-09-30 16:34 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-22 18:16 [PATCH v5 00/27] Pending patches, fix for isar-bootstrap, devshell Jan Kiszka
2019-09-22 18:16 ` [PATCH v5 01/27] buildchroot: Properly deploy the build result Jan Kiszka
2019-09-22 18:16 ` [PATCH v5 02/27] sdk: Use clean-package-cache rather than open-coded cleanup Jan Kiszka
2019-09-22 18:16 ` [PATCH v5 03/27] sdk: Deploy earlier Jan Kiszka
2019-09-22 18:16 ` [PATCH v5 04/27] Remove unneeded PF tweakings Jan Kiszka
2019-09-22 18:16 ` [PATCH v5 05/27] image: Stop changing PF, tune WORKDIR and STAMP directly Jan Kiszka
2019-09-25 12:47 ` [PATCH v6 " Jan Kiszka
2019-09-22 18:16 ` [PATCH v5 06/27] image: Make WORKDIR and STAMPs IMAGE_TYPE-specific Jan Kiszka
2019-09-22 18:16 ` [PATCH v5 07/27] Adjust STAMP variables to use PN, rather than PF Jan Kiszka
2019-09-22 18:16 ` [PATCH v5 08/27] Align WORKDIR structure with OE Jan Kiszka
2019-09-22 18:16 ` [PATCH v5 09/27] isar-bootstrap: Unshare host bootstraps across different target distros Jan Kiszka
2019-09-22 18:16 ` [PATCH v5 10/27] isar-bootstrap: Clean up and fix rebuild Jan Kiszka
2019-09-22 18:16 ` [PATCH v5 11/27] gitlab-ci: Keep logs as artifacts on failure Jan Kiszka
2019-09-22 18:16 ` [PATCH v5 12/27] Detect false sharing of recipes Jan Kiszka
2019-09-24 18:02 ` [PATCH v6 " Jan Kiszka
2019-09-29 14:57 ` Baurzhan Ismagulov
2019-09-30 6:00 ` Jan Kiszka
2019-09-30 9:56 ` Baurzhan Ismagulov
2019-09-30 10:14 ` Jan Kiszka
2019-09-30 14:53 ` Baurzhan Ismagulov
2019-09-30 15:26 ` Jan Kiszka
2019-09-30 15:39 ` Baurzhan Ismagulov
2019-09-30 16:34 ` Jan Kiszka [this message]
2019-09-30 17:20 ` Baurzhan Ismagulov
2019-09-30 17:26 ` Jan Kiszka
2019-09-30 20:29 ` Baurzhan Ismagulov
2019-09-22 18:16 ` [PATCH v5 13/27] dpkg-base: Move do_deploy_deb before do_build Jan Kiszka
2019-10-02 7:09 ` Baurzhan Ismagulov
2019-09-22 18:16 ` [PATCH v5 14/27] base-apt: Move do_cache_config " Jan Kiszka
2019-09-22 18:16 ` [PATCH v5 15/27] wic-img: Use private tmp dir Jan Kiszka
2019-09-22 18:17 ` [PATCH v5 16/27] rootfs: Take isar-apt shared lock during repository operations Jan Kiszka
2019-09-22 18:17 ` [PATCH v5 17/27] Use deb.debian.org mirrors Jan Kiszka
2019-09-23 10:03 ` Baurzhan Ismagulov
2019-09-23 10:09 ` Jan Kiszka
2019-10-02 11:13 ` Baurzhan Ismagulov
2019-09-22 18:17 ` [PATCH v5 18/27] linux-custom: Control linux-libc-dev deployment manually Jan Kiszka
2019-09-22 18:17 ` [PATCH v5 19/27] dpkg-base: Wait for umount to succeed Jan Kiszka
2019-09-30 11:07 ` Baurzhan Ismagulov
2019-09-30 12:22 ` Jan Kiszka
2019-09-30 13:33 ` Baurzhan Ismagulov
2019-10-07 15:48 ` Baurzhan Ismagulov
2019-09-22 18:17 ` [PATCH v5 20/27] dpkg-base: Permit multiple clean runs Jan Kiszka
2019-09-22 18:17 ` [PATCH v5 21/27] buildchroot: Factor out common packages Jan Kiszka
2019-09-22 18:17 ` [PATCH v5 22/27] buildchroot: Do not build cross when there are no arch-specific outputs Jan Kiszka
2019-09-22 18:17 ` [PATCH v5 23/27] Add git-buildpackage support Jan Kiszka
2019-09-22 18:17 ` [PATCH v5 24/27] dbpg-raw: Only list top-level files in <pn>.install Jan Kiszka
2019-09-23 9:52 ` Baurzhan Ismagulov
2019-09-23 10:29 ` Jan Kiszka
2019-09-23 10:30 ` Baurzhan Ismagulov
2019-09-22 18:17 ` [PATCH v5 25/27] Add OE class and library elements for terminal support Jan Kiszka
2019-09-22 18:17 ` [PATCH v5 26/27] dpkg-base: Add devshell target Jan Kiszka
2019-09-22 18:17 ` [PATCH v5 27/27] linux-custom: Add libncurses-dev to KBUILD_DEPENDS Jan Kiszka
2019-09-23 6:33 ` [PATCH v5 00/27] Pending patches, fix for isar-bootstrap, devshell Baurzhan Ismagulov
2019-09-23 7:33 ` Jan Kiszka
2019-09-23 7:50 ` Baurzhan Ismagulov
2019-09-23 9:50 ` Baurzhan Ismagulov
2019-09-23 10:07 ` Jan Kiszka
2019-09-23 10:23 ` Baurzhan Ismagulov
2019-09-23 10:28 ` Jan Kiszka
2019-09-25 8:41 ` Baurzhan Ismagulov
2019-09-25 8:51 ` Jan Kiszka
2019-09-25 9:22 ` Baurzhan Ismagulov
2019-09-25 9:26 ` Jan Kiszka
2019-09-25 9:35 ` Baurzhan Ismagulov
2019-09-25 9:35 ` Jan Kiszka
2019-09-25 10:52 ` Baurzhan Ismagulov
2019-09-25 11:05 ` Jan Kiszka
2019-09-25 12:08 ` Baurzhan Ismagulov
2019-09-25 12:29 ` Jan Kiszka
2019-09-25 12:44 ` Baurzhan Ismagulov
2019-09-23 14:24 ` Henning Schild
2019-09-28 15:46 ` Baurzhan Ismagulov
2019-09-25 10:23 ` Henning Schild
2019-09-25 11:41 ` Jan Kiszka
2019-09-30 9:29 ` Baurzhan Ismagulov
2019-09-30 10:02 ` Jan Kiszka
2019-09-30 13:00 ` Baurzhan Ismagulov
2019-10-01 14:47 ` Baurzhan Ismagulov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecb6c3de-c14b-0866-f68f-27c347ed4f8a@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox