public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Zhihang Wei <wzh@ilbers.de>
To: Rakesh Kumar <kumar.rakesh@siemens.com>, isar-users@googlegroups.com
Subject: Re: [PATCH v2] dracut: quote DRACUT_EXTRA_MODULES/DRIVERS for --add
Date: Thu, 9 Jul 2026 17:51:17 +0200	[thread overview]
Message-ID: <ed78935d-41cd-457d-a473-0cbe8f7d6568@ilbers.de> (raw)
In-Reply-To: <20260701063504.3110-1-kumar.rakesh@siemens.com>

Applied to next, thanks.

Zhihang

On 7/1/26 08:35, 'Rakesh Kumar' via isar-users wrote:
> extend_dracut_cmdline() joined multiple modules/drivers into the
> --add / --add-drivers arguments without quoting. With more than one
> entry the shell split the list, so dracut consumed only the first
> module and treated the rest as positional arguments (the output image
> path), breaking initramfs generation. Quote the lists so they are
> passed as a single argument.
>
> Fixes: f785cd0 (Add class to generate custom dracut initramfs)
>
> Signed-off-by: Rakesh Kumar <kumar.rakesh@siemens.com>
> ---
>   meta/classes-recipe/initrd-dracut.bbclass | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes-recipe/initrd-dracut.bbclass b/meta/classes-recipe/initrd-dracut.bbclass
> index bb4b50b7..542b1fbe 100644
> --- a/meta/classes-recipe/initrd-dracut.bbclass
> +++ b/meta/classes-recipe/initrd-dracut.bbclass
> @@ -48,9 +48,9 @@ def extend_dracut_cmdline(d):
>       if config_path:
>           cmdline.append(f"--conf {config_path}")
>       if extra_drivers:
> -        cmdline.append(f"--add-drivers {extra_drivers}")
> +        cmdline.append(f'--add-drivers "{extra_drivers}"')
>       if extra_modules:
> -        cmdline.append(f"--add {extra_modules}")
> +        cmdline.append(f'--add "{extra_modules}"')
>       return ' '.join(cmdline)
>   
>   ROOTFS_INITRAMFS_GENERATOR_CMDLINE:append = " ${@ extend_dracut_cmdline(d)}"

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/ed78935d-41cd-457d-a473-0cbe8f7d6568%40ilbers.de.

  reply	other threads:[~2026-07-09 15:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01  6:35 'Rakesh Kumar' via isar-users
2026-07-09 15:51 ` Zhihang Wei [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-06-30 11:43 [PATCH] " 'Rakesh Kumar' via isar-users
2026-07-01  6:42 ` [PATCH v2] " 'Rakesh Kumar' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed78935d-41cd-457d-a473-0cbe8f7d6568@ilbers.de \
    --to=wzh@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=kumar.rakesh@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox