From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6519112020741062656 X-Received: by 10.46.85.4 with SMTP id j4mr2596571ljb.43.1517850988390; Mon, 05 Feb 2018 09:16:28 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.226.25 with SMTP id z25ls868753lfg.11.gmail; Mon, 05 Feb 2018 09:16:27 -0800 (PST) X-Google-Smtp-Source: AH8x227WubYvCrOT40pLcJ7N74KNJ1Vnl9asmsuyGU76kqeggagnOnct2nU4yJw/utqKLbKGmVak X-Received: by 10.25.79.74 with SMTP id a10mr3709764lfk.40.1517850987698; Mon, 05 Feb 2018 09:16:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517850987; cv=none; d=google.com; s=arc-20160816; b=GvwEKJpfVJ/Kjx4qQICucL9BAwEjIX7VAA6fDlSMF6cubduq7KAVqwOYcaKUg23HFG gAZgknQTgPLffhU1aVcbwTf1r/m46/ZMDusWvjoex2IV12hUuXN9IM29OQnvKHhYCKDL VzF6FoFG7pP8QMZ+2CueiRS2xUJQkwXXlujTtrc6SqWkRsj4pzb7Gkxng5lAwDerqP6o 7qjePTGa0cuHh2EdLqpFEINYm9NHX6K3QXUBfzJ26t2tQ/qGH31550tHtQlzfT905IBO eSLj2hJx4cg+Gb25nJg2kVMJ8CVsHpMhM0ciq32M4sdtSB+xKggU+F0w+90px94AtnZB e5jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=x0O1DpXoJPYXecl4w4b7rqho82lOhed8WO1heERsJJ4=; b=ckTRx5SqrDtsgrHQ3o8oDtupB98kdUl4kSD7NLmznQNSxIff2eW6a4MT/Hre7TeKgu ih/+7Sgzc3jN6EAI4NneV149mrdzqSGXB3MCBKqCrNidwFtiQ9Jp4LQg2gEjbZZM8u6v exnRlKY6YaB13FM+ILMZzah/1RoyMvvoH1NzPwLgdI0vmrHC0e0kQ86/9ryFWf6VxsrW JCFHm2MzlggFCqBC+B6dwdT7u9sYthAx4UH3K1lzRulgOwAui58KOhh00mPIT3jqn3wf vyGNkrW8GyD0oPlV0aAiOLQ1VCg5iro3aUvFqrOyfKQqE1RuesuKhDuAIJeLnza6XaPV 6dqQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id j81si606022ljb.5.2018.02.05.09.16.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Feb 2018 09:16:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w15HGOws025568 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 5 Feb 2018 18:16:25 +0100 Subject: Re: [PATCH 2/2] buildchroot: Permanently mount '/dev', '/sys' and '/proc' To: Jan Kiszka , isar-users@googlegroups.com References: <20180205164347.28375-1-asmirnov@ilbers.de> <20180205164347.28375-3-asmirnov@ilbers.de> <604637ca-63f4-524a-0484-34f38f706919@siemens.com> From: Alexander Smirnov Message-ID: Date: Mon, 5 Feb 2018 20:16:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <604637ca-63f4-524a-0484-34f38f706919@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: wAliQ/hXond9 On 02/05/2018 07:53 PM, Jan Kiszka wrote: > On 2018-02-05 17:43, Alexander Smirnov wrote: >> Mount these folders permanently before creating buildchroot. Mounts are >> performed in dedicated task do_prepare, so it will also work if you run >> build with already existing buildchroot. >> >> BuildCompleted event is used for clean up, so we should not take care >> about this manually. >> >> Signed-off-by: Alexander Smirnov >> --- >> meta/classes/isar-events.bbclass | 3 +++ >> meta/recipes-devtools/buildchroot/buildchroot.bb | 21 +++++++-------------- >> .../buildchroot/files/configscript.sh | 4 ---- >> .../buildchroot/files/download_dev-random | 13 ------------- >> 4 files changed, 10 insertions(+), 31 deletions(-) >> delete mode 100644 meta/recipes-devtools/buildchroot/files/download_dev-random >> >> diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass >> index 55fc106..9f581a6 100644 >> --- a/meta/classes/isar-events.bbclass >> +++ b/meta/classes/isar-events.bbclass >> @@ -15,6 +15,9 @@ python isar_handler () { >> >> # Clean up buildchroot >> subprocess.call('/usr/bin/sudo /bin/umount ' + bchroot + '/isar-apt || /bin/true', stdout=devnull, stderr=devnull, shell=True) >> + subprocess.call('/usr/bin/sudo /bin/umount ' + bchroot + '/dev || /bin/true', stdout=devnull, stderr=devnull, shell=True) >> + subprocess.call('/usr/bin/sudo /bin/umount ' + bchroot + '/proc || /bin/true', stdout=devnull, stderr=devnull, shell=True) >> + subprocess.call('/usr/bin/sudo /bin/umount ' + bchroot + '/sys || /bin/true', stdout=devnull, stderr=devnull, shell=True) >> >> devnull.close() >> } >> diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb >> index 0044a71..b8aaf28 100644 >> --- a/meta/recipes-devtools/buildchroot/buildchroot.bb >> +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb >> @@ -12,7 +12,6 @@ FILESPATH =. "${LAYERDIR_core}/recipes-devtools/buildchroot/files:" >> SRC_URI = "file://multistrap.conf.in \ >> file://configscript.sh \ >> file://setup.sh \ >> - file://download_dev-random \ >> file://build.sh" >> PV = "1.0" >> >> @@ -32,16 +31,21 @@ BUILDCHROOT_PREINSTALL ?= "gcc \ >> WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}" >> >> do_prepare[nostamp] = "1" >> -do_prepare[dirs] = "${BUILDCHROOT_DIR}/isar-apt" >> +do_prepare[dirs] = "${BUILDCHROOT_DIR}/isar-apt \ >> + ${BUILDCHROOT_DIR}/dev \ >> + ${BUILDCHROOT_DIR}/proc \ >> + ${BUILDCHROOT_DIR}/sys" >> >> do_prepare() { >> sudo mount --bind ${DEPLOY_DIR_APT}/${DISTRO} ${BUILDCHROOT_DIR}/isar-apt >> + sudo mount --bind /dev ${BUILDCHROOT_DIR}/dev >> + sudo mount -t proc none ${BUILDCHROOT_DIR}/proc >> + sudo mount -t sysfs none ${BUILDCHROOT_DIR}/sys >> } >> >> addtask prepare before do_build after do_unpack >> >> do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" >> -do_build[dirs] = "${WORKDIR}/hooks_multistrap" >> do_build[depends] = "isar-apt:do_cache_config" >> >> do_build() { >> @@ -49,7 +53,6 @@ do_build() { >> >> chmod +x "${WORKDIR}/setup.sh" >> chmod +x "${WORKDIR}/configscript.sh" >> - install -m 755 "${WORKDIR}/download_dev-random" "${WORKDIR}/hooks_multistrap/" >> >> # Multistrap accepts only relative path in configuration files, so get it: >> cd ${TOPDIR} >> @@ -68,15 +71,6 @@ do_build() { >> -e 's|##DIR_HOOKS##|./'"$WORKDIR_REL"'/hooks_multistrap|g' \ >> "${WORKDIR}/multistrap.conf.in" > "${WORKDIR}/multistrap.conf" >> >> - [ ! -d ${BUILDCHROOT_DIR}/proc ] && install -d -m 555 ${BUILDCHROOT_DIR}/proc >> - sudo mount -t proc none ${BUILDCHROOT_DIR}/proc >> - _do_build_cleanup() { >> - ret=$? >> - sudo umount ${BUILDCHROOT_DIR}/proc 2>/dev/null || true >> - (exit $ret) || bb_exit_handler >> - } >> - trap '_do_build_cleanup' EXIT >> - >> # Create root filesystem >> sudo -E multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f "${WORKDIR}/multistrap.conf" >> >> @@ -85,5 +79,4 @@ do_build() { >> >> # Configure root filesystem >> sudo chroot ${BUILDCHROOT_DIR} /configscript.sh >> - _do_build_cleanup >> } >> diff --git a/meta/recipes-devtools/buildchroot/files/configscript.sh b/meta/recipes-devtools/buildchroot/files/configscript.sh >> index 458c94b..a5942b5 100644 >> --- a/meta/recipes-devtools/buildchroot/files/configscript.sh >> +++ b/meta/recipes-devtools/buildchroot/files/configscript.sh >> @@ -39,9 +39,5 @@ export LC_ALL=C LANGUAGE=C LANG=C >> #run pre installation script >> /var/lib/dpkg/info/dash.preinst install >> >> -# apt-get http method, gpg require /dev/null >> -mount -t devtmpfs -o mode=0755,nosuid devtmpfs /dev >> - >> #configuring packages >> dpkg --configure -a >> -umount /dev >> diff --git a/meta/recipes-devtools/buildchroot/files/download_dev-random b/meta/recipes-devtools/buildchroot/files/download_dev-random >> deleted file mode 100644 >> index 5b5b96b..0000000 >> --- a/meta/recipes-devtools/buildchroot/files/download_dev-random >> +++ /dev/null >> @@ -1,13 +0,0 @@ >> -#!/bin/sh >> - >> -set -e >> - >> -readonly ROOTFS="$1" >> - >> -mknod "${ROOTFS}/dev/random" c 1 8 >> -chmod 640 "${ROOTFS}/dev/random" >> -chown 0:0 "${ROOTFS}/dev/random" >> - >> -mknod "${ROOTFS}/dev/urandom" c 1 9 >> -chmod 640 "${ROOTFS}/dev/urandom" >> -chown 0:0 "${ROOTFS}/dev/urandom" >> > > That should finally obsolete my /dev/null fix. But after the problem > with my bind-mount attempt for /dev, I'd like to validate. What is the > baseline this patch should go upon? > Rebased patch to the latest 'next', please try 'asmirnov/devel' branch. Also it would be helpful if you could test double ^C and broken build. It would be perfect if it works :-) NOTE: umounts are done within next 2-3 seconds after your build stopped It seems this time is needed to stop bitbake server context. Alex