public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Maxim Yu. Osipov" <mosipov@ilbers.de>
To: Cedric Hombourger <Cedric_Hombourger@mentor.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH] isar-image: use a per-machine WORKDIR for image builds
Date: Tue, 12 Mar 2019 11:45:31 +0100	[thread overview]
Message-ID: <ee87a4a7-9335-f620-abf2-9b401de19c63@ilbers.de> (raw)
In-Reply-To: <1552370262-1572-1-git-send-email-Cedric_Hombourger@mentor.com>

Hi Cedric,

1) I applied it and run 'ci_build -q -f' and build failed:

http://isar-build.org:8080/job/isar_mosipov_develop/52/

2) If we really want to move towards aligning with the OE as you suggest:

 >should we align with OE and have tmp/work/${DISTRO_ARCH}-${DISTRO}, 
 >tmp/work/all-${DISTRO} and tmp/work/${MACHINE}-${DISTRO} instead of
 > having everything land under tmp/work/${DISTRO}-${DISTRO_ARCH}/?

this is the only first and partial step.

This time I will follow the way suggested by Jan by appending ${MACHINE} 
to affected recipes.


Thanks,
Maxim.


On 3/12/19 6:57 AM, Cedric Hombourger wrote:
> Maxim Yu. Osipov reported that the "rootfs" directory created by
> Isar to build images gets overwritten when running for two targets
> with the same pair DISTRO and DISTRO_ARCH. It became obvious after
> looking at start_vm script failures. Place all image build artifacts
> in $DISTRO-$MACHINE instead of $DISTRO-$DISTRO_ARCH. This change
> remains compatible with multiconfig builds (validated with a CI
> build).
> 
> Reported-by: Maxim Yu. Osipov <mosipov@ilbers.de>
> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>   meta/classes/isar-image.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass
> index cdd1651..a7f71a4 100644
> --- a/meta/classes/isar-image.bbclass
> +++ b/meta/classes/isar-image.bbclass
> @@ -19,7 +19,7 @@ DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}"
>   
>   IMAGE_TRANSIENT_PACKAGES += "isar-cfg-localepurge isar-cfg-rootpw"
>   
> -WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}"
> +WORKDIR = "${TMPDIR}/work/${DISTRO}-${MACHINE}/${PN}"
>   
>   ISAR_RELEASE_CMD_DEFAULT = "git -C ${LAYERDIR_core} describe --tags --dirty --match 'v[0-9].[0-9]*'"
>   ISAR_RELEASE_CMD ?= "${ISAR_RELEASE_CMD_DEFAULT}"
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

  reply	other threads:[~2019-03-12 10:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11 17:03 [PATCH 0/1] Separate image rootfs for machines Maxim Yu. Osipov
2019-03-11 17:03 ` [PATCH 1/1] classes/image: " Maxim Yu. Osipov
2019-03-11 18:00   ` Jan Kiszka
2019-03-11 19:43     ` cedric_hombourger
2019-03-12  5:13       ` Jan Kiszka
2019-03-12  5:57         ` [PATCH] isar-image: use a per-machine WORKDIR for image builds Cedric Hombourger
2019-03-12 10:45           ` Maxim Yu. Osipov [this message]
2019-03-14 10:54       ` [PATCH 1/1] classes/image: Separate image rootfs for machines Baurzhan Ismagulov
2019-03-12  8:30     ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee87a4a7-9335-f620-abf2-9b401de19c63@ilbers.de \
    --to=mosipov@ilbers.de \
    --cc=Cedric_Hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox