public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>
To: "isar-users@googlegroups.com" <isar-users@googlegroups.com>,
	"Kiszka, Jan" <jan.kiszka@siemens.com>
Subject: Re: [PATCH 1/4] rootfs: Implement update-initramfs stubs via symlink
Date: Mon, 15 Sep 2025 10:32:59 +0000	[thread overview]
Message-ID: <eeaa04c2b665c1e386fcc6dc34f1bff149084bdb.camel@siemens.com> (raw)
In-Reply-To: <d12f94da01822c39f405950cb4390f8e39123e09.1757930833.git.jan.kiszka@siemens.com>

On Mon, 2025-09-15 at 12:07 +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Avoid needless copying of any files. Consolidate the sudo calls into one
> at this chance.

Thanks!

Acked-by: Felix Moessbauer <felix.moessbauer@siemens.com>

> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  meta/classes/rootfs.bbclass | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
> index 7b7859b9..d91fecb0 100644
> --- a/meta/classes/rootfs.bbclass
> +++ b/meta/classes/rootfs.bbclass
> @@ -182,8 +182,12 @@ ROOTFS_CONFIGURE_COMMAND += "rootfs_disable_initrd_generation"
>  rootfs_disable_initrd_generation[weight] = "1"
>  rootfs_disable_initrd_generation() {
>      # fully disable initrd generation
> -    sudo mkdir -p "${ROOTFSDIR}${ROOTFS_STUBS_DIR}"
> -    sudo cp -a ${ROOTFSDIR}/usr/bin/true ${ROOTFSDIR}${ROOTFS_STUBS_DIR}/update-initramfs
> +    sudo -s <<'EOSUDO'
> +    set -e
> +
> +    mkdir -p "${ROOTFSDIR}${ROOTFS_STUBS_DIR}"
> +    ln -s /usr/bin/true ${ROOTFSDIR}${ROOTFS_STUBS_DIR}/update-initramfs
> +EOSUDO
>  }
>  
>  ROOTFS_INSTALL_COMMAND += "rootfs_install_pkgs_update"
> -- 
> 2.51.0

-- 
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/eeaa04c2b665c1e386fcc6dc34f1bff149084bdb.camel%40siemens.com.

  reply	other threads:[~2025-09-15 10:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-15 10:07 [PATCH 0/4] Several micro-optimizations 'Jan Kiszka' via isar-users
2025-09-15 10:07 ` [PATCH 1/4] rootfs: Implement update-initramfs stubs via symlink 'Jan Kiszka' via isar-users
2025-09-15 10:32   ` 'MOESSBAUER, Felix' via isar-users [this message]
2025-09-15 10:07 ` [PATCH 2/4] sbuild-chroot: Skip initramfs generation while installing build dependencies 'Jan Kiszka' via isar-users
2025-09-15 10:33   ` 'MOESSBAUER, Felix' via isar-users
2025-09-15 10:07 ` [PATCH 3/4] rootfs: Avoid unneeded commands inside chroot 'Jan Kiszka' via isar-users
2025-09-15 10:07 ` [PATCH 4/4] image-locales-extension: Optimize package removal 'Jan Kiszka' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eeaa04c2b665c1e386fcc6dc34f1bff149084bdb.camel@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox