Re: [PATCH v5 1/5] meta/image.bbclass: add image_do_mounts for image specific mounts

[chombourger@gmail.com]

[-- Attachment #1.1: Type: text/plain, Size: 1805 bytes --]

Hi Claudius,

So the idea is that platform developers wanting to add their own mounts 
would use a bbappend to do something like?

image_do_mounts_append() {
    sudo mount <foo> <bar>
}

is this something we would want to add to the documentation?

Cedric

On Monday, February 11, 2019 at 10:09:24 AM UTC+1, claudius....@siemens.com 
wrote:
>
> From: Claudius Heine <c...@denx.de <javascript:>> 
>
> Signed-off-by: Claudius Heine <c...@denx.de <javascript:>> 
> --- 
>  meta/classes/image.bbclass | 21 +++++++++++++++++++++ 
>  1 file changed, 21 insertions(+) 
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass 
> index d8fbfd5..bec62cd 100644 
> --- a/meta/classes/image.bbclass 
> +++ b/meta/classes/image.bbclass 
> @@ -14,6 +14,27 @@ IMAGE_FULLNAME = "${PN}-${DISTRO}-${MACHINE}" 
>  KERNEL_IMAGE ?= "${@get_image_name(d, 'vmlinuz')[1]}" 
>  INITRD_IMAGE ?= "${@get_image_name(d, 'initrd.img')[1]}" 
>   
> +# Useful variables for imager implementations: 
> +PP = "/home/builder/${PN}" 
> +PP_DEPLOY = "${PP}/deploy" 
> +PP_ROOTFS = "${PP}/rootfs" 
> +PP_WORK = "${PP}/work" 
> + 
> +BUILDROOT = "${BUILDCHROOT_DIR}${PP}" 
> +BUILDROOT_DEPLOY = "${BUILDCHROOT_DIR}${PP_DEPLOY}" 
> +BUILDROOT_ROOTFS = "${BUILDCHROOT_DIR}${PP_ROOTFS}" 
> +BUILDROOT_WORK = "${BUILDCHROOT_DIR}${PP_WORK}" 
> + 
> +image_do_mounts() { 
> +    sudo flock ${MOUNT_LOCKFILE} -c ' \ 
> +        mkdir -p "${BUILDROOT_DEPLOY}" "${BUILDROOT_ROOTFS}" 
> "${BUILDROOT_WORK}" 
> +        mount --bind "${DEPLOY_DIR_IMAGE}" "${BUILDROOT_DEPLOY}" 
> +        mount --bind "${IMAGE_ROOTFS}" "${BUILDROOT_ROOTFS}" 
> +        mount --bind "${WORKDIR}" "${BUILDROOT_WORK}" 
> +    ' 
> +    buildchroot_do_mounts 
> +} 
> + 
>  inherit ${IMAGE_TYPE} 
>   
>  # Extra space for rootfs in MB 
> -- 
> 2.20.1 
>
>

[-- Attachment #1.2: Type: text/html, Size: 2837 bytes --]