From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6618191789727678464 X-Received: by 2002:a2e:165c:: with SMTP id 28-v6mr678331ljw.25.1541502373961; Tue, 06 Nov 2018 03:06:13 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:874e:: with SMTP id q14-v6ls1667624ljj.24.gmail; Tue, 06 Nov 2018 03:06:13 -0800 (PST) X-Google-Smtp-Source: AJdET5dd/7QPreM5WzRAw/uzHYuaXhe0rECmQcUtAxhrsJabJp2yUeDWjheRVqGcMrFoQaoQtoMb X-Received: by 2002:a2e:9e4a:: with SMTP id g10-v6mr2355563ljk.26.1541502373438; Tue, 06 Nov 2018 03:06:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541502373; cv=none; d=google.com; s=arc-20160816; b=hulltXFzbQbp04NG8J5SS8p5kUrkO25g7+zZy0G+IYwWAqEVlAta6Be2qVGV9daXhW NZoENex9uF6m0mrpLWqeJdNfVE2jj1FHlxzBODb8hr8oEcBv9jhUk2HS3lIfOE7qJNxt QyEIltOkqb9cNCdN5VJSV5cZVi1YMM6kQTz+Us+lvWy/2xq2l0ji34uuZabrKlhusL5a 7yPSrRp3i88RKxQs7DvTPMHAhrKZXC7SNeQ/5lHqrhEpEGQwwTuVJmVYhd5XRgstA1ub 5Cuz2XcXGaIMv0ehD2G5mwQ2t2zCPhrF1/DgBT1hngYj7RWSp22HzS6iU+RuWSgxtiOk CT+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:to:from:subject:message-id; bh=KMc0MgbX6fUgatbl99gvNY6Ai8Q0/FdSvbW7XGXnifU=; b=AUUx3JNVg2KXxmGjY+fWXEfPKGghZUjt25GW4lkOoumyF0vVlSgCdAzm88Yk5OdSeZ dSB0eBaTe6oSBB42rfj9U6qAyY/ccaFlVWkJ9qL7ZjnfXWcPaAJfGckzfEcArikgiPQh 1EtEgr6SrUbT6wK7DEokBQyMowt3N2sDnyA4zsSVhWcs4NV53X7gp+vyIRCTY7RV8LUZ BPDiGzKZ0IE2iz2H2OC/l0uVq6ojNfqlknSUZD6f2L/nwlvQcwXmMYO5c2we0Hqi5QKI Emyx3C9cnmUsRFP6C3AMXmYDLvgDTeoalZwxcrT0SFH60dagiTC4BeL1WE+TXPMPD81I fXUg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of hws@denx.de) smtp.mailfrom=hws@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id w13-v6si1666672lfe.3.2018.11.06.03.06.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 03:06:13 -0800 (PST) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of hws@denx.de) client-ip=212.18.0.9; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of hws@denx.de) smtp.mailfrom=hws@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 42q6DN5t0hz1qwQv; Tue, 6 Nov 2018 12:06:12 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 42q6DN5gTvz1qtfm; Tue, 6 Nov 2018 12:06:12 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id q9xH3BeuyYI0; Tue, 6 Nov 2018 12:06:11 +0100 (CET) X-Auth-Info: Vx8D7cJ2jQd6sQLV+9IFBrE1b0FwCGIW7yqrvoxoiWc= Received: from sandvich (p5B04CB9B.dip0.t-ipconnect.de [91.4.203.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 6 Nov 2018 12:06:11 +0100 (CET) Message-ID: Subject: Re: [PATCH] bitbake: Allow setting DL_DIR from environment From: Harald Seiler To: Jan Kiszka , isar-users@googlegroups.com Date: Tue, 06 Nov 2018 12:06:10 +0100 In-Reply-To: References: <106c00a92881b8fefff5616e27c7c434c2c4983e.camel@denx.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUID: JEIQ8GMS9bnA On Wed, 2018-10-31 at 07:39 +0100, Jan Kiszka wrote: > On 30.10.18 17:44, Harald Seiler wrote: > > This patch allows adding DL_DIR to BB_ENV_EXTRAWHITE > > and then specifying a custom DL_DIR in the environment. > > > > This behavior mirrors the one in poky. > > > > Signed-off-by: Harald Seiler > > --- > > bitbake/conf/bitbake.conf | 2 +- > > We do not patch bitbake so far. Is this fix in upstream already? Then let's > fast-forward bitbake to that revision. If not, send it upstream first. Local, > isar-specific changes go to isar-bitbake.conf. Upstream (bitbake) does not have this fix. The reason it works in poky is that they have removed the `bitbake/conf/bitbake.conf` file completely and instead use their own config in `meta/conf/bitbake.conf`. I am not sure why this is done this way, though. > > > meta/conf/isar-bitbake.conf | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/bitbake/conf/bitbake.conf b/bitbake/conf/bitbake.conf > > index a460df4..ba0d68b 100644 > > --- a/bitbake/conf/bitbake.conf > > +++ b/bitbake/conf/bitbake.conf > > @@ -23,7 +23,7 @@ CVSDIR = "${DL_DIR}/cvs" > > DEPENDS = "" > > DEPLOY_DIR = "${TMPDIR}/deploy" > > DEPLOY_DIR_IMAGE = "${DEPLOY_DIR}/images" > > -DL_DIR = "${TMPDIR}/downloads" > > +DL_DIR ?= "${TMPDIR}/downloads" > > FILESPATH = "${FILE_DIRNAME}/${PF}:${FILE_DIRNAME}/${P}:${FILE_DIRNAME}/${PN}:${FILE_DIRNAME}/files:${FILE_DIRNAME}" > > FILE_DIRNAME = "${@os.path.dirname(d.getVar('FILE', False))}" > > GITDIR = "${DL_DIR}/git" > > diff --git a/meta/conf/isar-bitbake.conf b/meta/conf/isar-bitbake.conf > > index 666c4a3..39e73f6 100644 > > --- a/meta/conf/isar-bitbake.conf > > +++ b/meta/conf/isar-bitbake.conf > > @@ -19,7 +19,7 @@ > > # OTHER DEALINGS IN THE SOFTWARE. > > > > WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PF}" > > -DL_DIR = "${TOPDIR}/downloads" > > +DL_DIR ?= "${TOPDIR}/downloads" > > SSTATE_DIR ?= "${TMPDIR}/sstate-cache" > > BUILDCHROOT_HOST_DIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/buildchroot-host/rootfs" > > BUILDCHROOT_TARGET_DIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/buildchroot-target/rootfs" > > -- > > 2.14.1 > > > -- Harald DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-62 Fax: +49-8142-66989-80 Email: hws@denx.de