From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6562126013157867520 X-Received: by 2002:a5d:4906:: with SMTP id x6-v6mr313936wrq.12.1528096608531; Mon, 04 Jun 2018 00:16:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:ea0e:: with SMTP id i14-v6ls8684450wmh.4.gmail; Mon, 04 Jun 2018 00:16:48 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKe/htJoV6kVVMAjvl1kGLG95/thPJ4vHIZnkr5+TLcSpzzAQH+dKkJIoqITJQJtyTBbccO X-Received: by 2002:a1c:96ca:: with SMTP id y193-v6mr1446350wmd.16.1528096607878; Mon, 04 Jun 2018 00:16:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528096607; cv=none; d=google.com; s=arc-20160816; b=0+PgIcJLZuXzNgW2yrxbuOlLjDhIRQkS3bRL7WicMu3CeX/ByrM959AJ9dfclOlT5N K8SNC00hCYmGm2VhOOYAl0Iz+QhC9vdc2I9jv5IjVz/lFKQzQ+QEgjDysfJ7Ar6gcIah m9QBf88t04IlTSIyzf6MS00lRD9jTl+rcV9RCoAs2/X3fud2GjJZrW7vbMs3A11Y6PpE RczI+WA8VNC3n4CL0q8dgSGyycYlwzoYH0/DzCTmmooS7Ti2VC9fMpFxv0x+8P/3fWiU 0pbWXoUIe9EMJIxB+/SbqnZY5EBst6OIlEDqcEgkNADtDcY6/o6Yt7tHiymacVZpsaet LflA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:autocrypt:openpgp:from:references:to :subject:arc-authentication-results; bh=Sr9o7sksVRFpg+0ANSUj9p/Mo0UAOd2djqoQSw5qL/4=; b=gAHMzmVqCCTh8f6KT0XjnkaPXHuxoqEJ8+SOZxPI+2TopoDUbqJM2oVg96z9SsnEO8 XRwnZgQz7R3oML3QVbXKwOLJkXbi63apyO4M/SUB7vNtdGPaoZqFbZe97ntwBlmG1pBe owpDflIvTqqSHZt+HfBir3k4B3mkrQmp/kS5gSFEXewcA1SPhrQeQU7EtOyE55/oQUWb 5X0ZLuqfn++pN/06dabQplidjSLFyXLljQN3n1jARwv2aH4kNA04PU+Hgp0iSQ4FcByM S7dMZLDN6+8wV6Z/z91HDTLZ+Gb+zgAuRVVaciIkOPqJelA94v3USxgiPR5So2IKDHGD KSkw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id r7-v6si400383wmc.0.2018.06.04.00.16.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 00:16:47 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w547GlLB031500 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Jun 2018 09:16:47 +0200 Received: from [139.22.116.229] ([139.22.116.229]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id w547Gkn3013771; Mon, 4 Jun 2018 09:16:47 +0200 Subject: Re: IMAGE_TYPE vs IMAGE_TYPE(S) To: cedric_hombourger@mentor.com, isar-users References: <45b87a65-2efb-4652-8790-6b5726e1caef@googlegroups.com> From: Jan Kiszka Openpgp: preference=signencrypt Autocrypt: addr=jan.kiszka@siemens.com; prefer-encrypt=mutual; keydata= xsDhBEq0i8QRBAD2wOxlC9m/8t/vqjm1U9yQCT6OJ2Wbv/qys9DYM0CvcOTDMWQwmV1/VsZj KR5YgB5NPt+To7X6x5cjz15AGnx5Fb8Wnrq8EF9ZfHMwb7YMx1LdPYPDnXr37wE3XupFmkHB Mes4htyX7Dz8LvKDLnli4IsAmWG+kV1JI6LWKXLpSwCg8JRq4SWoB4VCQxbH3GjntgvwNc8D /2q5Dj0urJ7s7sdXhrH0hcFkpSFRmU5Yd6MCwcbFHm2paL5gqVjNNUUwDBKAL9eZaQVIHKwC 44BvNGO2gcQ26R3AuCHUQ+pZHg34tok1JCNZ6IEZccb+33Qq0qbcDMJJiDYp7ppp6ozifvc4 YaqJECX48IydxfE9+41oV7T5vNAzA/QL/UMJyTnu5jiOXcyn5iFQw535lXkwKsqeXzCowLho HICZ2jITJPdTT/+9pGWwMQqST/SS35Tx4EnS3z2BWsNMCLuXCPkxF1elaMJqMfMJxFD8rAgS 9GK6zP6fJlsA1wq/UvKSL8v4QPOnTNCVOsyqJVasGV0ZPcDfcj+ClNO4zR5KYW4gS2lzemth IDxqYW4ua2lzemthQHdlYi5kZT7CYwQTEQIAIwIbIwYLCQgHAwIEFQIIAwQWAgMBAh4BAheA BQJOpoNtAhkBAAoJEIrUrG965ecUOPUAoK+Rh12KgCjplHAS0AoiGKwGOuq7AKDEVnBtRAoy VRvp3lOlOx+P2Ay56M7BTQRKtIvEEAgA2/PlX6oyi7dToH0CJCHq0eKmZaa7CmGaVnxyeepK vIfiM8n8Td76AbG64fjREMwgSpb4F/UytF3z/03tj4e49W/zKjbBRB2/wmFRlZBC9crg22Q+ bgvMOsxnC6uHXaWN8fL+jVei/5OoHOoFqaMsX8EvploitlI/BPj+VgW26jksf3YZyk1hncls Z/IYhXzgRmVJo4RiTW/YLQAkwndwc+fKPa/IYLEDW1Jc4kNLoK0P90b45zju0hpl0C00pVOR TOtzFK9G5Ha7qOAWJfAVJORHKAkkvwftf3hkpPdLyvZUWRHXvUexmA61fLvDBAFhRxYGD8t5 gz88SF5Tzq+0ywADBQf/YSkaYrEslPWiCA2wU6EW0yaqBQAobFsOMvsufJ6o2ntq5Ncq37VI 3KCT67eHPE9x+zPcENoZWsRrC9S9PCf1LOsi7ybZsR13AJqDFlRzJZ4klh9QwgwFZxUBzOdI vttwzG1QkzHx06RKZluFYpPF3DRduSMukdIJ2wmWCU+ohB+mYefe65JGjYQfHVs8mgYVFOPx bRea9VJACCMuspoZWpj43UdR1lLLyIUFYz+jqcPW7Hd/GTIw4N67pYl0dwPDmFd4ohJ5g4Zp q61toNysBGEuEm5GCcn0VmGtQpSYnR5cVm5b2yPz4bIuFOSuZUo/l7vitdY0iy0/wvKbBC+N K8JJBBgRAgAJBQJKtIvEAhsMAAoJEIrUrG965ecULvAAoKGvxs5T3IhyQT8I8sMsyAvCE4wH AJ46S16yab+OxNkvOeoOEX0EnHVHaA== Message-ID: Date: Mon, 4 Jun 2018 09:16:46 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <45b87a65-2efb-4652-8790-6b5726e1caef@googlegroups.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: PnkOq8GZWmaV On 2018-06-01 16:40, cedric_hombourger@mentor.com wrote: > Hello! > > The documentation suggests that IMAGE_TYPE may be a list of images to be > built: > >    | The `IMAGE_TYPE` variable contains the list of image types to generate. > > (ref: https://github.com/ilbers/isar/blob/master/doc/user_manual.md#image-type-selection) > > It appears that one could set this to e.g. "ext4-img wic-img" to get > Isar to generate both an EXT4 image and a WIC image. > Alright. > > But then how about this code: > >    | if d.getVar('IMAGE_TYPE', True) == 'wic-img': >    |     d.appendVar('BUILDCHROOT_PREINSTALL', >    |                 d.getVar('BUILDCHROOT_PREINSTALL_WIC', True)) > > (ref: https://github.com/ilbers/isar/blob/master/meta/recipes-devtools/buildchroot/buildchroot.bb#L45) > > The condition would be False for the example provided above and our > buildchroot missing vital tools such mkdosfs > > We probably need to fix one or the other. What are your thoughts? While the above would be easy to adjust, it doesn't look to me like as if the rest of Isar is ready to support true IMAGE_TYPES semantic. I would suggest to adjust the doc for now so that it stops suggesting IMAGE_TYPE is like OE's IMAGE_TYPES. Patch welcome. Thanks for reporting! Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux