Re: [PATCH] rootfs: Report progress for postprocessing steps

[Jan Kiszka <jan.kiszka@siemens.com>]

On 01.07.20 16:38, Harald Seiler wrote:
> Use a ProgressHandler to report how far postprocessing has progressed.
> Because we can't know the exact timing of all postprocessing tasks, the
> percentages are split evenly for all steps.
> 
> Signed-off-by: Harald Seiler <hws@denx.de>
> ---
>  meta/classes/rootfs.bbclass | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
> index 806e824c825a..889272e7bee4 100644
> --- a/meta/classes/rootfs.bbclass
> +++ b/meta/classes/rootfs.bbclass
> @@ -248,12 +248,16 @@ python do_rootfs_postprocess() {
>      # removed on a previous execution of this task:
>      bb.build.exec_func('rootfs_do_qemu', d)
>  
> +    progress_reporter = bb.progress.ProgressHandler(d)
> +    progress_reporter.update(0)
> +
>      cmds = d.getVar("ROOTFS_POSTPROCESS_COMMAND")
>      if cmds is None or not cmds.strip():
>          return
>      cmds = cmds.split()
> -    for cmd in cmds:
> +    for i, cmd in enumerate(cmds):
>          bb.build.exec_func(cmd, d)
> +        progress_reporter.update(int(i / len(cmds) * 100))
>  }
>  addtask rootfs_postprocess before do_rootfs
>  
> 

Looks good to me, should be merged finally.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux