From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6844521397531705344 X-Received: by 2002:a2e:9a0e:: with SMTP id o14mr8477215lji.340.1602584777342; Tue, 13 Oct 2020 03:26:17 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:ad43:: with SMTP id s3ls856126lfd.2.gmail; Tue, 13 Oct 2020 03:26:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/77RH5AYfJn5qx1Kk6AOHSFiwaxAPW4hgf87QzuPqy590V7S1l6lJPk2OtsxkM2JqEnQ5 X-Received: by 2002:a19:383:: with SMTP id 125mr9851914lfd.356.1602584776107; Tue, 13 Oct 2020 03:26:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602584776; cv=none; d=google.com; s=arc-20160816; b=c9yKQHG2eSDxMrDFTgwJb0b0rPS8VS9HtRBIkI0vpwpOt/Cd1AQrpp+CtXva6VtVRI zF8OtzmMgtAEsjqTM6sogUx10x4i1AsjCj9EETioGVbbL9/F20b+EvYsQsNAqSsarKsA 4fgam7NSOUs39g4SszKmnsR61Ws/v7amBQSRU4kwQOrt3uwcRrIMGeoTwVn8lnV3oNEP rFUPryOxsl/GJcDGv7Aikc7rCLtsAbgYAxEPFK0g/R2aQP8iPNpL38ROgyRLnYb8HG+V Dr97O6ah5anOyYOxOS1VG8zBcJSj2dRj85HC7WbxtFaHjtIipELHHrBKpnUN8QuvIx1Y DNOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=xZBNHKRzQPLrxpjRCf3Tilmr9MzY78JzsX1bsYPIftw=; b=pmtFSKNKky+yugezocHxNFO9ot/bC+tALAcV5mBRSIB9ksUcmavCy4zWJlB3fPYLOm yxI1Eqe7wPnNb5SY0BN0t4u1La4gVc0DkqhuRLy4p8VieU4gkngyl+f1DAh/afNIIct/ /AFXcQK+3CSTjLpLT/gIkrSDQEDiZlv53RecwKM2P5X4Vn3UqN/thWFLmbj5LidTKNsD HimsA0rhieLRFFLSgZe+U3Duak7weWiXwZ19pTpSjsuAlJdPzzYMu7qWR/SS5vZeHnDI Wt7sT+IER/9zNbqKLe4UE+IS6vfacQ6tCePIi8Zy7uNUcV1SKzu0qcknO8SCD0VKlO9a CtiA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id 11si440395lfl.4.2020.10.13.03.26.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Oct 2020 03:26:15 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 09DAQEe5024191 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Oct 2020 12:26:14 +0200 Received: from [139.25.68.37] ([139.25.68.37]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 09DAQE6c025593; Tue, 13 Oct 2020 12:26:14 +0200 Subject: Re: [PATCH] rootfs: Report progress for postprocessing steps To: Baurzhan Ismagulov Cc: Harald Seiler , isar-users@googlegroups.com, Claudius Heine References: <20200701143832.1113534-1-hws@denx.de> From: Jan Kiszka Message-ID: Date: Tue, 13 Oct 2020 12:26:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200701143832.1113534-1-hws@denx.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: WGBoaDWQJv+O On 01.07.20 16:38, Harald Seiler wrote: > Use a ProgressHandler to report how far postprocessing has progressed. > Because we can't know the exact timing of all postprocessing tasks, the > percentages are split evenly for all steps. > > Signed-off-by: Harald Seiler > --- > meta/classes/rootfs.bbclass | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index 806e824c825a..889272e7bee4 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -248,12 +248,16 @@ python do_rootfs_postprocess() { > # removed on a previous execution of this task: > bb.build.exec_func('rootfs_do_qemu', d) > > + progress_reporter = bb.progress.ProgressHandler(d) > + progress_reporter.update(0) > + > cmds = d.getVar("ROOTFS_POSTPROCESS_COMMAND") > if cmds is None or not cmds.strip(): > return > cmds = cmds.split() > - for cmd in cmds: > + for i, cmd in enumerate(cmds): > bb.build.exec_func(cmd, d) > + progress_reporter.update(int(i / len(cmds) * 100)) > } > addtask rootfs_postprocess before do_rootfs > > Looks good to me, should be merged finally. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux