Re: [PATCH] meta-isar: Fix sdimage-efi wic script

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2018-09-07 19:52, Henning Schild wrote:
> Am Fri, 7 Sep 2018 15:02:52 +0200
> schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:
> 
>> In order to have the EFI partition reliably detected as such, we need
>> to set the right type.
>>
>> And as we are using GPT, the legacy boot flag plays no role anymore.
> 
> Could you check how the most recent wic in OE deals with that? I would
> like to keep the local diffs in the forked files as small as possible.
> 
> So if they have the same or a similar fix, we should just bump wic and
> merge our forked files.

This is not touching wic. It's our own wks file for which there is no 
direct correspondence in OE. There are a couple of efi-creating wks 
files in OE, but they got it wrong as well.

The funny story about this: The box I found the issue on was happily 
booting an USB stick with the imprecise format but rejected the very 
same image on an internal (AHCI-attached) disk.

Jan

> 
> Henning
>   
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>   meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks
>> b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks index
>> 580ad21..7aba8e3 100644 ---
>> a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks +++
>> b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks @@ -2,7 +2,7 @@
>>   # long-description: Creates a partitioned EFI disk image without any
>> swap that # the user can directly dd to boot media.
>>   
>> -part /boot --source bootimg-efi-isar
>> --sourceparams="loader=grub-efi" --ondisk sda --label msdos --active
>> --align 1024 +part /boot --source bootimg-efi-isar
>> --sourceparams="loader=grub-efi" --ondisk sda --label efi
>> --part-type=EF00 --align 1024 part / --source rootfs --ondisk sda
>> --fstype=ext4 --label platform --align 1024 --use-uuid
> 

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux