From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6598467239096090624 X-Received: by 2002:a50:b1db:: with SMTP id n27-v6mr2100919edd.10.1536343140869; Fri, 07 Sep 2018 10:59:00 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:d716:: with SMTP id t22-v6ls4212446edi.4.gmail; Fri, 07 Sep 2018 10:59:00 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYDkObTFLqd/ASvWjprrEBiFb02G6qQHUmWoQ/Ap9HHN6425/2839QmvYgPbGJsI5+uEJPE X-Received: by 2002:a50:b602:: with SMTP id b2-v6mr2125491ede.6.1536343140411; Fri, 07 Sep 2018 10:59:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536343140; cv=none; d=google.com; s=arc-20160816; b=K0z150vABqYaktUoDGxruZ4TgkDQ+QDn+jnGlgADteHzQ5uzTwkmh4XTvBppavMjHv 1Gg2tRN9lwRXiHr+kzw7QMVomFMz4A0X/5y+1kP+brBsVlNs2HzFoDtxEzto4ZU6VoEG IC3RqMtlulsaVMbTvkZaXkxTOTWf8cFI8IH6eo0teyhqvd6CP/4fk8pHpBfIbneraBWt GqJK2Yi4DMaSumgjHbGw2HVShqeFEvChdAmEcRF/vm8c9fJUZANriifEvEutDhBf+sGH qPsiIFpAtp/0hV62yIFUr00dq08Tmmhu7h58dQX/CL3vIYyMli7FHC54TVmXisvOEAEG UJNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=4Iup6GMcQysKn/J+pRUypKmoGZyahWRr0FC6xQBkJa4=; b=fwsR8Zmi3O8dSthUqFNHy49uPbTtp6myv+dljgUbbJPJSuZsVTSUgjakaulTfqyYJq h6dq+QTAIEQ6PcXrQRLOARG06GKHT+3svFSqtYmtTX2CNG5slcYh3+bQcOoYzTsY7enf xzG2k6zjL6GMb7pFPdbWH395z+mF6RvuP3vao2o78nbfD9/yr9Fz2y9Z0MAEHMaYSY4C Bc/04u4xdybUxRIqycFMkib69RMMoxD1saJzP80AOiJtklig051VI9Wt50KDdHXDfk7Q snXsfO3EPU+6/fkd0t4D+0jcgBcCimGrkR7O8JruiYDrTQcZ7nBx3BE2i7WxAzGUrUI0 eTCA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id b23-v6si279998edn.1.2018.09.07.10.59.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Sep 2018 10:59:00 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w87Hwxlp000458 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Sep 2018 19:58:59 +0200 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w87HwxoQ005043; Fri, 7 Sep 2018 19:58:59 +0200 Subject: Re: [PATCH] meta-isar: Fix sdimage-efi wic script To: Henning Schild Cc: isar-users , Andreas Reichel References: <3b047a67-7b34-49db-aeca-4cbbe0259ecc@siemens.com> <20180907195222.33e1b7a4@md1pvb1c.ad001.siemens.net> From: Jan Kiszka Message-ID: Date: Fri, 7 Sep 2018 19:58:58 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20180907195222.33e1b7a4@md1pvb1c.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: r7ClsMF2dNJK On 2018-09-07 19:52, Henning Schild wrote: > Am Fri, 7 Sep 2018 15:02:52 +0200 > schrieb "[ext] Jan Kiszka" : > >> In order to have the EFI partition reliably detected as such, we need >> to set the right type. >> >> And as we are using GPT, the legacy boot flag plays no role anymore. > > Could you check how the most recent wic in OE deals with that? I would > like to keep the local diffs in the forked files as small as possible. > > So if they have the same or a similar fix, we should just bump wic and > merge our forked files. This is not touching wic. It's our own wks file for which there is no direct correspondence in OE. There are a couple of efi-creating wks files in OE, but they got it wrong as well. The funny story about this: The box I found the issue on was happily booting an USB stick with the imprecise format but rejected the very same image on an internal (AHCI-attached) disk. Jan > > Henning > >> Signed-off-by: Jan Kiszka >> --- >> meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks >> b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks index >> 580ad21..7aba8e3 100644 --- >> a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks +++ >> b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks @@ -2,7 +2,7 @@ >> # long-description: Creates a partitioned EFI disk image without any >> swap that # the user can directly dd to boot media. >> >> -part /boot --source bootimg-efi-isar >> --sourceparams="loader=grub-efi" --ondisk sda --label msdos --active >> --align 1024 +part /boot --source bootimg-efi-isar >> --sourceparams="loader=grub-efi" --ondisk sda --label efi >> --part-type=EF00 --align 1024 part / --source rootfs --ondisk sda >> --fstype=ext4 --label platform --align 1024 --use-uuid > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux