From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6739560601010307072 X-Received: by 2002:adf:ecc6:: with SMTP id s6mr12151262wro.333.1569838480980; Mon, 30 Sep 2019 03:14:40 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:6889:: with SMTP id h9ls2850561wru.13.gmail; Mon, 30 Sep 2019 03:14:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqzu4IqIjxKKZ4PVNSKvT4MkrGRyV/8uSIN48TRhiZoRiuWx+IaOBTPVGu9/7haWrnbeT06V X-Received: by 2002:adf:ea12:: with SMTP id q18mr13180585wrm.378.1569838480405; Mon, 30 Sep 2019 03:14:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569838480; cv=none; d=google.com; s=arc-20160816; b=NcBLu6Ho2dwIzAnI+kVhaTA/uYWafjI73xPLKNPSMCrbaT/RAKiIqWP3JxY4vLATkC xDlIGWFbj5WIAhIdTfMBJWLv0n7Xa8XxjlzDDsYbl8uxl0gAnRb1w8U8EBMpJu5TC+Hl F2mZZlvVOPeBD9l11znpvJQceCCBRPOzqfR+K/k2L2kKb66pErX2W7Ow1qMle58Thw+7 uxdhJAskozHJNi2Li7+pkyxqqu11Wr3Z1euwpV5KfDZhsayAdQUZ5Ekp8sIHV33Dr38P h4Tub1kp1c4QIGT4N9K2aPDRYWcIYeneywT4FVW/zv35RQUuHj+mBdlrEpoPbr+Fe7uy yzNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=UZUWH+xPk8/OldLk8p0xCVBx7ieLfCSIKhfnNEhevdc=; b=HgqOUo9Po3nQPFz3yRyHj/xWG08wlwH5QFTP2C1skJ5bB+97gmUHoVRuqvsJL/IxsP /vYFbZVWpfwxbl4KZmleiLM/3XmsC9Sbi1j5DmihmW8fDJDNVKFBEvxNzQ1Yf1j4GDjj 0O8hdGrjgAT659nd/RLiM/lvNLGmIyIgdQqfjQx4OuGCtpPriEE5VH8qSekVmLKRlWkA 1wKvVv1UQi5eamWeRUzZsErE69AGno9CMrd8OdYeMbFqm8AwurQNJtM324NRZQnlee+q KP8/dv4JKqX+suPgQwxmXkls39NDU4rLG3gkuczkLckyY2+VMD5OU/3YwuzRAZ9iRIxz CpoQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id p5si654573wmg.0.2019.09.30.03.14.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Sep 2019 03:14:40 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x8UAEeYx027675 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 30 Sep 2019 12:14:40 +0200 Received: from [167.87.40.9] ([167.87.40.9]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x8UAEdrb018530 for ; Mon, 30 Sep 2019 12:14:39 +0200 Subject: Re: [PATCH v6 12/27] Detect false sharing of recipes To: isar-users References: <5a2e329b881ec0b392d0f1abd116f1deeee0f66f.1569176231.git.jan.kiszka@siemens.com> <20190929145700.ads3zbq7hz77olcw@yssyq.m.ilbers.de> <248aa6db-6327-9604-40b6-e7135a5f9961@siemens.com> <20190930095610.shyewhozb46dautr@yssyq.m.ilbers.de> From: Jan Kiszka Message-ID: Date: Mon, 30 Sep 2019 12:14:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190930095610.shyewhozb46dautr@yssyq.m.ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: P/tmAbMfnXl/ On 30.09.19 11:56, Baurzhan Ismagulov wrote: > On Mon, Sep 30, 2019 at 08:00:21AM +0200, Jan Kiszka wrote: >> isar-bootstrap had two issue: >> >> 1. Not rebuilding when it should (on changes to its configuration) > > Was this due to the PF tweaking before your series, and is now fixed by your PF > changes? https://groups.google.com/d/msg/isar-users/nciPZ484-nI/kf9C-_9tAQAJ (finding the right messing in googlegroups is a horrific mess...) > > >> 2. False sharing of it deployment directory > > Do you mean e.g. using tmp/deploy/bootstrap/debian-stretch-armhf for > qemuarm-stretch and bananapi, in fact having different configurations (bananapi > requesting the buster kernel)? > https://groups.google.com/d/msg/isar-users/nciPZ484-nI/vjjYVf9tAQAJ That bananapi was requesting a different bootstrap setting was a bug of its own, fixed by no longer doing that. Not triggered in CI because that target is not built. > >> None of them were or could have been detected by this instrumentation. > > I meant your whole series including the PF changes and bundled the questions in > this reply, sorry for confusion. > > >> What would have been detected AFTER removing that improper rebuild >> prevention (https://groups.google.com/d/msgid/isar-users/ccad9eb9-fce5-89d1-3188-7043f003ea7e%40siemens.com) >> is https://groups.google.com/d/msgid/isar-users/ccad9eb9-fce5-89d1-3188-7043f003ea7e%40siemens.com >> - which is still not in your queue. Lost in your staging tree? > > Not lost, no worries; two patches from the first series are still pending. I'd > like to understand the failure mode because I'm also struggling with a race. > Does the URL refer to [PATCH v2 09/26] meta-isar: Move bananapi to buster, > remove bogus example? My browser opens the URL in the middle of a message. > Yes, sorry, googlegroups... I thought the links you find at the bottom of each message would work, but they don't, at least in this thread. > >>> 3. Where does this delete the once.* file w.r.t. e.g. do_dpkg_build for >>> different multiconfigs? >> >> At the beginning of the new build (parse_completed) or when a recipe failed >> to build (task_failed). > > Yes, this is what I also read from the patch. If I build hello-isar for e.g. > qemuarm-buster and qemuamd64-buster, its do_dpkg_build is called for each > multiconfig. Why doesn't it fail on once.do_dpkg_build? IIUC, parse_completed If two multiconfs have the same common dependency, that one is only built once. Well, except when not. And when not, my instrumentation will tell you that there is a fundamental multiconf bug. > has finished in the beginning and no recipes fail. The following output was > taken with your instrumentation: > > + bitbake -v multiconfig:qemuarm-stretch:isar-image-base multiconfig:qemuarm64-stretch:isar-image-base multiconfig:qemuamd64-stretch:isar-image-base multiconfig:qemuarm-buster:isar-image-base > NOTE: Running task 306 of 404 (multiconfig:qemuarm-stretch:/workspace/build/isar_ibr_devel_fast/24/meta-isar/recipes-app/hello-isar/hello-isar.bb:do_dpkg_build) > NOTE: recipe hello-isar-0.3-a18c14c-r0: task do_dpkg_build: Started > NOTE: Running task 310 of 404 (multiconfig:qemuarm64-stretch:/workspace/build/isar_ibr_devel_fast/24/meta-isar/recipes-app/hello-isar/hello-isar.bb:do_dpkg_build) > NOTE: recipe hello-isar-0.3-a18c14c-r0: task do_dpkg_build: Started > NOTE: recipe hello-isar-0.3-a18c14c-r0: task do_dpkg_build: Succeeded > NOTE: recipe hello-isar-0.3-a18c14c-r0: task do_dpkg_build: Succeeded > > > With kind regards, > Baurzhan. > Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux