Re: [PATCH 1/2] start_vm: Fix quotes usage

[Alexander Smirnov <asmirnov@ilbers.de>]

On 04/27/2018 02:06 PM, Henning Schild wrote:
> Am Fri, 27 Apr 2018 13:28:52 +0300
> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> 
>> According to the following chapter:
>>
>> http://wiki.bash-hackers.org/syntax/quoting#quotes_and_escaping
>>
>>    MYARG="\"my multiword argument\""
>>    somecommand $MYARG
>>
>> is NOT the same as:
>>
>>    command "my multiword argument"
>>
>> So this patch splits kernel params to separate variable for correct
>> interpretation.
>>
>> Tested with bash and dash in Debian jessie.
>>
>> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
>> ---
>>   scripts/start_vm | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/start_vm b/scripts/start_vm
>> index cfb2bea..7eb633e 100755
>> --- a/scripts/start_vm
>> +++ b/scripts/start_vm
>> @@ -28,6 +28,7 @@ start_qemu() {
>>   	$QCPU \
>>   	-nographic \
>>   	$EXTRA_ARGS \
>> +        "$KARGS" \
> 
> How about?
>   -append "$KARGS"

If I understand this correctly, $KARGS could be empty for some cases. 
Does it work with empty $KARGS? Let me check this. But in general I like 
your suggestion.

> 
>>   	$root
>>       [ $had_x -eq 0 ] && set +x
>>   }
>> @@ -123,7 +124,8 @@ case "$IMAGE_TYPE" in
>>       EXTRA_ARGS="$EXTRA_ARGS \

                     ^
Here is opening one.

>>   	-kernel $QKERNEL \
>>   	-initrd $QINITRD \
>> -	-append \"console=$MACHINE_SERIAL root=/dev/$ROOTFS_DEV rw\""
>> +	-append "
                 ^
This one is closing.

> 
> Where are the closing quotes?

Alex

> 
> Henning
> 
>> +    KARGS="console=$MACHINE_SERIAL root=/dev/$ROOTFS_DEV rw"
>>       ;;
>>       wic-img)
>>       readonly
>> ROOTFS_IMAGE=isar-image-base-debian-$DISTRO-qemu$ARCH.wic.img
> 

-- 
With best regards,
Alexander Smirnov

ilbers GmbH
Baierbrunner Str. 28c
D-81379 Munich
+49 (89) 122 67 24-0
http://ilbers.de/
Commercial register Munich, HRB 214197
General manager: Baurzhan Ismagulov