From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6621956091070644224 X-Received: by 2002:aa7:dc56:: with SMTP id g22mr194804edu.10.1543481330349; Thu, 29 Nov 2018 00:48:50 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:a843:: with SMTP id dx3-v6ls258956ejb.7.gmail; Thu, 29 Nov 2018 00:48:49 -0800 (PST) X-Google-Smtp-Source: AFSGD/WOIGLQoe15Nq0m/IWv1IJh2SXONhJt6/I9TEYg4xDjDNjmcSO3dh0LxxEu/uiWbzP1F3Si X-Received: by 2002:a17:906:1c45:: with SMTP id l5-v6mr178101ejg.3.1543481329864; Thu, 29 Nov 2018 00:48:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543481329; cv=none; d=google.com; s=arc-20160816; b=EhOCP7LOFFPc2ls72e0kMppb5b+dPzPFhOwHIY+9mrnhSDtGNspgJcwqPyZLk2gqkz YCy9nfsjvV5eb7p7bheCE9sm36j+PW7RvM5tLAWqjdoyiSjeAfTSYN1H8/KPzxBCi9MT z8eXKjqzM0d47zJ0x1aMgJ4v4OKUJYSMObVYHHJqiyAP4UDHUU+/AQUJWcHY1IlDzrPQ KC0tUyt5USepqRw2olmqAgxpbUrgSQrzH/RDvLmpbrdVhQdo9sz4xOWrbSVpGqTDF9XR 6+sbwjETtWacKwfbCLxBegOfhkNhO6dIeDbk2jpUGrZWmll79u8fP4bD7WOXd+AExgq3 r75A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=c2y9dtt3LL8Umu3DNd9HU+qCZsEaqpskRF9l/vT5X+0=; b=KRFG/J9DUyFr8ZpivSkwZf3SgNMXnNKc8hjZ5aLf+EiX52rRlH33dg4JvKZRbJ23vD uoQSS91ncKZcwFdbtNrW6Y9IuOyFvB5649qq1WYgBcL/Gf+jz8/86U/3YPDYFCi1SoZA 9QeHBLCIXcU0Fy/kTWnTKk7HvJ8AKoOTa6UC04WklDMR5HiqQh1N4xJeipZa4qzXgdBB ORz3Fcv8V/dwiu7icsDETNjZeyWGffw7/eCvSM6FDQ8SMfAa7Zq5BEb49BaswL80MPa3 AcaEbFE5ztUlSTN65gWhL60vypkLGSMfo61hi2bo/9GqqWhNZmoSGPs4ruVLo87b1HLU Nf4A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id i17si50191edg.2.2018.11.29.00.48.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Nov 2018 00:48:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.180] (nat-ppp-217.71.235.199-satnet-spb.ru [217.71.235.199] (may be forged)) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id wAT8ml03016548 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 29 Nov 2018 09:48:48 +0100 Subject: Re: [PATCH v6 0/2] rbind mounts for /dev and /sys To: "Hombourger, Cedric" Cc: "isar-users@googlegroups.com" References: <20181119102407.0903d847@md1za8fc.ad001.siemens.net> <1542717658-157-1-git-send-email-Cedric_Hombourger@mentor.com> <59566b71-f70a-ba1a-fd63-d6ea6d24c84d@ilbers.de> <2796c60503e14c2aa1172083cf11a5a7@svr-ies-mbx-02.mgc.mentorg.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: Date: Thu, 29 Nov 2018 11:48:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <2796c60503e14c2aa1172083cf11a5a7@svr-ies-mbx-02.mgc.mentorg.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: CRhtmihnAInh Hi Cedric, On 11/29/18 11:28 AM, Hombourger, Cedric wrote: > Hi Maxim, > > No worries - I was also busy here in St Petersburg because of an accident and now have a broken ankle :( Sad to hear :(... So you are the victim of Russian winter and you learned the Russian word 'gololed' (iced surface)... > Yes I had tested with regular mounts (patch series v1/v2) and it worked just fine. I can submit a patch this week Yes, I've re-read the thread. My concern on v2 was to double check that all /sys are properly unmounted (this is a problem we experience in 'next'). I wish you to recover and take care, Maxim. > Cedric > > -----Original Message----- > From: Maxim Yu. Osipov [mailto:mosipov@ilbers.de] > Sent: Thursday, November 29, 2018 11:23 AM > To: Hombourger, Cedric > Cc: isar-users@googlegroups.com > Subject: Re: [PATCH v6 0/2] rbind mounts for /dev and /sys > > Hi Cedric, > > On 11/27/18 5:48 PM, Hombourger, Cedric wrote: >> Hi Maxim, >> >> We may need to revert Henning's suggestion to rbind /sys and mount >> /sys as a regular mount (the chroot may not need all of the sub-mounts from /sys) What do people think? > > My apologies for late reply (was busy with other urgent topics). > Have you tested the version with regular mounts? > > Kind regards, > Maxim. > > >> Cedric >> >> -----Original Message----- >> From: Maxim Yu. Osipov [mailto:mosipov@ilbers.de] >> Sent: Tuesday, November 27, 2018 5:45 PM >> To: Hombourger, Cedric ; >> isar-users@googlegroups.com >> Subject: Re: [PATCH v6 0/2] rbind mounts for /dev and /sys >> >> Hi Cedric, >> >> After applying these patches I've recognized that after running ci_build.sh script, the number of mounts significantly increases. >> >> On my PC it looks like that >> >> $ mount | wc -l >> 34 >> isar$ ./scripts/ci_build.sh -q -f >> ... >> $ mount | wc -l >> 100 >> >> If I revert these patches the number of mount points stays the same after running ci_build.sh script. >> >> This behavior significantly affects CI - builds start to fail. This is a blocking point for CI and if we don't find a quick solution I will have to revert these patches in 'next'. >> >> Thanks, >> Maxim. >> >> On 11/20/18 3:40 PM, Cedric Hombourger wrote: >>> Some of the packages I have been rebuilding within Isar require /sys mounted. >>> For instance, golang-google-grpc runs some package tests after it >>> builds itself and reads properties from /sys/class/dmi. >>> >>> The initial version of this patch series only added a mount of /sys. >>> Henning then suggested that we follow Gentoo's guidelines for chroots. >>> As such, this patch series is now mounting /dev and /sys as rbind >>> mounts but leaves /proc as a regular procfs mount (like Gentoo does). >>> >>> ChangeLog: >>> >>> v6: remove unnecessary mkdir for /sys >>> v5: cover letter added as suggested by Jan (private e-mail) >>> v4: limit rbind mounts to /dev and /sys, leave /proc as a regular >>> mount >>> v3: rbind mounts for /dev, /proc and /sys, add explicit umount calls >>> v2: create /sys directory >>> v1: initial submission, simply mount /sys >>> >>> Cedric Hombourger (2): >>> buildchroot+bootstrap: rbind mount for /dev >>> buildchroot: add sysfs mount since expected by some packages >>> >>> meta/classes/buildchroot.bbclass | 5 ++++- >>> meta/classes/image.bbclass | 3 ++- >>> meta/classes/isar-bootstrap-helper.bbclass | 6 +++++- >>> meta/classes/isar-image.bbclass | 3 ++- >>> meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 8 ++++++-- >>> 5 files changed, 19 insertions(+), 6 deletions(-) >>> >> >> >> -- >> Maxim Osipov >> ilbers GmbH >> Maria-Merian-Str. 8 >> 85521 Ottobrunn >> Germany >> +49 (151) 6517 6917 >> mosipov@ilbers.de >> http://ilbers.de/ >> Commercial register Munich, HRB 214197 General Manager: Baurzhan >> Ismagulov >> > > > -- > Maxim Osipov > ilbers GmbH > Maria-Merian-Str. 8 > 85521 Ottobrunn > Germany > +49 (151) 6517 6917 > mosipov@ilbers.de > http://ilbers.de/ > Commercial register Munich, HRB 214197 > General Manager: Baurzhan Ismagulov > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov