From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7235862407233404928 X-Received: by 2002:a50:9b57:0:b0:502:4c87:7981 with SMTP id a23-20020a509b57000000b005024c877981mr3961420edj.4.1684732580041; Sun, 21 May 2023 22:16:20 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:d783:0:b0:50b:f4e3:a863 with SMTP id s3-20020aa7d783000000b0050bf4e3a863ls1012139edq.1.-pod-prod-01-eu; Sun, 21 May 2023 22:16:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ57rIHJC2ZfcdDqpptFswl1QFoixcpV5OsHGTfEBHHX/g6/L2Oo3BL3RpBY+ZbT3r2eqmuP X-Received: by 2002:aa7:c785:0:b0:50d:9e7c:2646 with SMTP id n5-20020aa7c785000000b0050d9e7c2646mr4547589eds.7.1684732578377; Sun, 21 May 2023 22:16:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1684732578; cv=pass; d=google.com; s=arc-20160816; b=toUCSg5GFyif4Igf/JKHGQ65yxt/FtfsHxUSp5VmDDqeKtZW0HsShSAyKwvm9dDAMV FqGTh2ogm6blvFo9bIXjrc69OEau8W0CdBEc/ksY6rqLry+P1aknc/9WdmIaWWvt0c4r AVh5SJBE2H74apndt+78PIracBzCKu1VZ1EmLqNmju/fUxhDNHByF73DAgT0U8vKX/hf 08yeCNiru4o+OQF9QuZQgsylXRDDnokpHkbTb6Ab4znh0gKUFMF5AvoA3oi8GE+b/Ki4 I3QyHvEcdivyXOYXQPPZYLmemCT+Pgs/oHy7jJkorKGGWF/7RzOCEs6xh58Z9yht9usC sHmA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :cc:to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=+zXePb56MQFOWCm5hEK1hvx4yxZCqJi8EJS8gimEzyE=; b=j57FFV44EakqtdxhC5Xz9hA/rRiDoqlw7mt+2Wj5b3dhiDPnOV8lW/VwsQQtAg7xtV gJ+D1LkMnyl1dTG4L30jFpaTOa3JhYvQgYxbytGd4Z1JUx9+GrLlpykdP7T8pDv8OtNy NbFleXo1CRrqRheHYsX55ht3ci25Ron9rx9zHtKUOY1RpZO/dkR4OfD2qDSykYuPMSAG mE7Worad7LMUh9nYnHDUGnLkwOiIVrVwKSfPazFMKdgeH8ZhCVb0iaA7XXT8/w1UvqA3 5vQQY4E5Zrz9SwT5FpcgPpQ9J4Fr22zilXraP41dW2EFbCZ/G6O5VCMZ/SxCRmJ69eUH tKFg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=HTUF1NYk; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0c::60b as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on060b.outbound.protection.outlook.com. [2a01:111:f400:fe0c::60b]) by gmr-mx.google.com with ESMTPS id g26-20020aa7c85a000000b00510cd4eed58si378071edt.2.2023.05.21.22.16.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 May 2023 22:16:18 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0c::60b as permitted sender) client-ip=2a01:111:f400:fe0c::60b; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=HTUF1NYk; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0c::60b as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DqLNJdiyFFSWf4snnGGjb3pDkobLUxo4KK8Vq+J99pobyFnn7TS4eUC/fJ/0SFvqmhk/yRcEV00vsgEt9bKwzHQDnFkKBwDS18tJaRexuIt+a7Oe8nM32IJL7XWCcMr74mJQFQIm2p6PHL5Es8kq3uhZsaR6+Vm5GjU3sZ9MXbac3r4+akCMOX1b/Q6BKboKEi7dMtprhuT4m29ZMIgu7sLZ/wDKlAaUQZWbagt0mBLwPM+1F0tuC4TC3uwVPwViqPZVAcsx+YtPwXpb7liLLuhoq/ZxWbJ+i6BbYFMg5JyEQi3ztOz0EcPiV5xbfzysMEPGfhd39ehSilCKFahTPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+zXePb56MQFOWCm5hEK1hvx4yxZCqJi8EJS8gimEzyE=; b=eR2cFe8YvpvFix7ikiQHNp6zZxZIudIpnyVCJU28OJbTZT/OiLIK8EqjU0xFYHXSsRxRoRVeTtgQknBZVllLbutDIlRDFFzoSDJg6oYXQQ/SYES3MIUDoXZOZnRcAzC+SGsZljDaZFIOcJzTHFu0TLeFzYyYvqAHAJ9C05kj/iv6113wu2p1YB3W2phgkBIpGLlF3O1YLPeeALtd2a7DO9yQdDK6/wtK4T6ULbymPtBsEEq9LnTiPhrAxYWG/sqb+srzKkjYI/xhofmNTzUj7zJs85ZYVJWRjMTvFSkcD8U22uPFy0dBiS17s+UhRVkmBNv3iWJ2nmlappsb08dA8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+zXePb56MQFOWCm5hEK1hvx4yxZCqJi8EJS8gimEzyE=; b=HTUF1NYkwwYMWLlK5J9GaUZ8G5U6MS+NnJfCSW22CV7RNbn/a4uoDHg0/SaWRphmgUoQgzgb9v+zZnuvbMaVr/9U+iTKUtioUGz9PJkla/fKTx664QWldjjROalrrfkQhe8ZSUmVgLPeavTHshPTMCvWoZLpYbHeZfJe5Hk/BKGm/7hIVy0Uf3opIc6XKuOHB2HLyuPUHh6l4zIlqkS4jWVz34fwCncQ5i7sbLsbdIQA5j8FqsE0RgFV906PtQnq4OkGpP8VXm54drKCp1OBHEd1dqtxcxOhmNraLQ33VVFfk96MmqRFNvotR2fGwc/yqvadb9LAOcCKUVDH0xc+3A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by PRAPR10MB5348.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:29b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Mon, 22 May 2023 05:16:17 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::d638:8333:21fb:5f18]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::d638:8333:21fb:5f18%7]) with mapi id 15.20.6411.028; Mon, 22 May 2023 05:16:17 +0000 Message-ID: Date: Mon, 22 May 2023 07:16:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] crossvars.bbclass: use d.appendVar instead of d.setVar for SDK_TOOLCHAIN variable Content-Language: en-US To: Srinuvasan Arjunan , isar-users@googlegroups.com Cc: amikan@ilbers.de, Srinuvasan A References: <20230522044117.1698718-1-srinuvasan_a@mentor.com> From: Jan Kiszka In-Reply-To: <20230522044117.1698718-1-srinuvasan_a@mentor.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::6) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|PRAPR10MB5348:EE_ X-MS-Office365-Filtering-Correlation-Id: cbfbd631-fecf-4cbb-822f-08db5a83ab92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: irLMqmQ4ZtXKZQaI4qFdilwKViTroCkBgHvHESlXKnq8/5HoCnNHVueU8c5y0oqayM/zkoDRKNFgTBJTJjg+Uwq6bJl2fxwXzh11UfAO8/i6tnycKGpchBDwo1eltyOI98vdRRP381frPgcKd26z/zMjfauyc2EtzQfPDpe6y6mRppSi+p4mJvU/gUWvhcbBSCEtJ6BZtNeAKA6Hs6gkk/tDH+sfsxEcZ/7znXl8osnC20vF1G4hLyi2Ez8e+XotD5yWaIGNZW0nJI/C0H4O8bUqgyCW0oQ8vS1odsxhg+oEEv5Zl+w+q6QvcI2bDB425dsy9h46+/O2d9uN3WytZ39kY7FJeb2lT3j/5PPoMB9Xb7AZ/KseoXK4q8V8n1NrjZHQknLo4c/f4YkVWWlAC87XKIj8yV4LJ2VycxvtOO96q67Grr1Va366DO1xF7UKeZ0sEI3YnVsOikxMxye59s8bvCkeloiA+5rsGqvSGuRyD4YrmrSOQ2Ii8l5L7Mf61DZFK+/lXmVLMC6/BjyxfQrgyKUZi97rhpF4NFbwKvof/KlBBslBCxKFLlA6G+A2PahcJ9byb5ZIMECxUojXNpZtfMtATiASmUl8k0nXlnSXJSNYaa19geFT53tBcGLc2ig4vxuGRS0/+25nPipUKA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199021)(8676002)(8936002)(5660300002)(44832011)(186003)(26005)(53546011)(6512007)(6506007)(83380400001)(86362001)(2616005)(31696002)(38100700002)(82960400001)(107886003)(41300700001)(6666004)(6486002)(66476007)(66556008)(66946007)(316002)(36756003)(4326008)(478600001)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tm92aXBVZDYzbkgxcE9DU3FaQ1pPZ1h4aG5uNldoZElNNEpnQnY5N2lUSWxu?= =?utf-8?B?UitLTWV0MWFUaXRYNnZNZloxUXRTT3BINlFwb2UzOFYwcSs3Vzd3WUdkbWdB?= =?utf-8?B?TUk0eWFNa2MxK1VRM1pHQU9ZbGlHbUNjQTg0aW5ZczVZVnQ4eVZaL0VOdUVj?= =?utf-8?B?Qm1Uc2ZQVzgyUmRBT1lNajNXMHRDaUNMSnJXVlVxUDhreHFXN0lSWXJhdm1L?= =?utf-8?B?WkxhYjFCeG5ubHZFanAxNUJremU3QjNtcTVDckxCQ3hpVnVFNDJhdFMvZGJL?= =?utf-8?B?OGZqMGxQbVN1cWxSN3p0TEljMjltQW52TXNrVU1tcXhzUjYyakZnMWN1R2x4?= =?utf-8?B?Wmp3VzdMMDA4Nk91YVZIVlRSckQ4YjhMeVBlOFNtL3JENEFnanFrN1UvUGRN?= =?utf-8?B?ZExNdndybmFmSUNhYlRjcFRBNGFRS0RtbDd3aEtEczdqeXhBZlROYmdxR1JO?= =?utf-8?B?TzZCWHlscmxGTEp4QnlwOWxOQWpMOWhSMVR3d3hXS3NJSWwrNWxKRlVzTE1T?= =?utf-8?B?SGI0MkFKODZMSHdIQ2p3VEgyWDBPNk1OVldhRUxTd2VCZ3hmM2V2RUxIMEg3?= =?utf-8?B?cVpucEdnaHlxYkY0aTRiTUFra1JBOG81Z0ZBMnhtNm05MnVROSs3WW1Jck1l?= =?utf-8?B?TVVNbkgreWhrVW5tUndpNkswZkp6MHJ2MUVNVk13VHZIUlFHb2RVcTlMdVA0?= =?utf-8?B?dTV2MFhkU3dUVmNGK2RwaTNWc1kwSFUwbFAyWWhrbmM1a1JYRmNHaHZwUWY1?= =?utf-8?B?Ymw2VUhMR0lIbnJ0UkFxREw5ZGxySTF0VndON2JkTzNrdW1hM0F5b0dVWEto?= =?utf-8?B?dG9SQWVCcndjY3FObEwrbC9rTDZnTDkxeDFDdW1VU082Z2lha0hpaGxiZ2JT?= =?utf-8?B?NExVcmxPVzNHMTRHbjJxNlMxajI3d1BmUjdqb3ZOTzk1Z1cyY3pUSVdwdTVJ?= =?utf-8?B?U0R2OFlyQ1ppaytuNzZybWZ2VFV3ZkdBc3FhZVVyd2tQRWQxaVdIcnZhVVVs?= =?utf-8?B?VXBwTGZqZzZIbVRqUktiVGo4bVVBSTA5YzdlRUhYajdFY2hWUklscnJsQ2pC?= =?utf-8?B?YWxqRHZTbVk4MTVxQUFzaUgzV1Q1ZFVOTnFuSXR1VVc2YXVBU1pydTI4NDNj?= =?utf-8?B?MGYxVUNBT2I1VDVaQ0NpZkVnTXZNOCtIa0JJb0J3NGtEd2cwOEljczJjbm9O?= =?utf-8?B?N1JoaURWU0Z2THF3SUc3MUxwS3llOWJKWUVWNThFU1dHeS9zQmFwdmowTHJ1?= =?utf-8?B?c3pWUUp4MEhJMXZOc3Y2MVowMmIwTmljOHRFV3RTTjFxSFhkZ1hPbHRIZGUv?= =?utf-8?B?QkIxa01ZNFhNUGsyU0pIRWE2TGtlejMwcGJ3bS9KbnFJaUFSdE5MenJTWnpG?= =?utf-8?B?Yi9RQW5qOERSRWNUM3NxaWp5ejQ5cmQ4N3QzdWNKSThjOE1aSHp6T0huSTlx?= =?utf-8?B?UDFiVWs3ejdYU0JMRHozTFY1Z2laK09McTNvcm1oODJLQTh4TzRZR1NRTjVT?= =?utf-8?B?em1QZ2FJQlU0ZGN0SGp6ak9kYk5yYysvZzk1TW9UQ0VoM01vRlJ5RUd1ZGVL?= =?utf-8?B?MU5CZ3dXSkFOR3A1ZFZUYTdDOTU2anR5OGEwOElQY2FQSmFwdXBNOWlDSHVM?= =?utf-8?B?L3l6TWMzbHNkaEYxNXk0YnZseXFsNmdvZjVmMk94eDZPeDhxekFCQVNLVzhx?= =?utf-8?B?Rmc2cjl0dmxEMWF3TUx0UFhxYVFrSnBYQ1NhcWpqdFA5K3laRHhaUXVtM2gx?= =?utf-8?B?ZEcvaFFtYUhQN05nZzIvM2lYM2dPZXp3TjlNMjlpRjNpK0pMc0NZWFlVbUph?= =?utf-8?B?amxtVmFUcW5KUFVTQVlWdmNDTlhEYUhReHZNRnF6alBLeUdXcDhXUTV2MHNp?= =?utf-8?B?RGZ4UGE4aVVLdlRaQVROakxMeTFYbUQ2QlJOc1pXRlIva01DZEVTRlRrdnNw?= =?utf-8?B?THZ0alRZOG9GWTIvRHhyVXlFSlJBZ3VNN0xXUEplTVNNaDJQZGtQUDlrOW1Q?= =?utf-8?B?RXVLT0xXSzl6d0xXYUc5QldBR2NRUUNjVVAvcnM2azBIeWNZUlBVTWJveDB5?= =?utf-8?B?UnFpa3pyZ2hhWmRkQTFxNVo2RGw1YTNMMEViZkR1cFVCbEJzNXNEV01keUlt?= =?utf-8?Q?nowtf6TCqj9aRy6TRUaZJFi3C?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbfbd631-fecf-4cbb-822f-08db5a83ab92 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 05:16:17.0226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /e1137c6sIs57kUBH4S4WFqGzcgMKJbf1YNS/t4T/Fd/YjIzbJ1GjpJ9yFa8TUeb+4YbqVYt435l7AGch4+s7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAPR10MB5348 X-TUID: uTXGJI9jWcmN On 22.05.23 06:41, Srinuvasan Arjunan wrote: > From: Srinuvasan A > > In downstream layer we may override the sdk_toolchain, but this not works as > expected in latest ISAR, the reason behind this as they moved toolchain > selection into python Anonymous function. Dod you want to append or do you want to replac SDK_TOOLCHAIN in downstream? In the latter case, we likely rather want to make our assignment in isar weak, no? if not d.getVar('SDK_TOOLCHAIN'): ... Jan > > Anonymous Python functions always run at the end of parsing, regardless of where they are defined > even when we do override in our recipe, always wins the Anonymous Python > functions variable settings, hence change to d.appendVar instead of > d.setVar in sdk toolchain selection, so downstream layer they can modify the > SDK_TOOLCHAIN list if needed (append/remove). > > Signed-off-by: Srinuvasan A > --- > meta/classes/crossvars.bbclass | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/crossvars.bbclass b/meta/classes/crossvars.bbclass > index 201d460..5a3edc4 100644 > --- a/meta/classes/crossvars.bbclass > +++ b/meta/classes/crossvars.bbclass > @@ -17,7 +17,7 @@ python __anonymous() { > sbuild_dep = "sbuild-chroot-target:do_build" > buildchroot_dir = d.getVar('BUILDCHROOT_TARGET_DIR', False) > buildchroot_dep = "buildchroot-target:do_build" > - sdk_toolchain = "build-essential" > + sdk_toolchain = " build-essential" > else: > d.setVar('BUILD_HOST_ARCH', d.getVar('HOST_ARCH')) > schroot_dir = d.getVar('SCHROOT_HOST_DIR', False) > @@ -31,5 +31,5 @@ python __anonymous() { > d.setVar('BUILDCHROOT_DEP', buildchroot_dep) > if isar_can_build_compat(d): > sdk_toolchain += " crossbuild-essential-" + d.getVar('COMPAT_DISTRO_ARCH') > - d.setVar('SDK_TOOLCHAIN', sdk_toolchain) > + d.appendVar('SDK_TOOLCHAIN', sdk_toolchain) > } -- Siemens AG, Technology Competence Center Embedded Linux