From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6729358150130991104 X-Received: by 2002:a50:ce5a:: with SMTP id k26mr17359800edj.218.1566808853713; Mon, 26 Aug 2019 01:40:53 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:89f6:: with SMTP id h51ls5788836edh.15.gmail; Mon, 26 Aug 2019 01:40:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqz29WK1AQxRPsufzyNYbdeww6Ufj7Y0rUqiXgtneQcedBq+XQEQaqXAtIt+kEeQdrBGz4jv X-Received: by 2002:a50:982a:: with SMTP id g39mr17317499edb.88.1566808853228; Mon, 26 Aug 2019 01:40:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566808853; cv=none; d=google.com; s=arc-20160816; b=Kt3L8jZxvpcGhtmxJWl2QTc9fEePGo3YjggHPZYNS5xceHP6c+m+UY1AlqXZumN8EZ aDD4Rn7o46F5isDbVpDpnossd4g0rRX0Mvj2BRxefevrkKpngO1ePOvb9UlQm/qmaRQS 7X8f/LIwMcoy5lbquFqH6jt31+b4rh9nPsnBG5GvOmVxgmBr6cLXgk9Y3fwJx9Csj76/ NEbt3Iv9LdpXqRTHSLANm3VfeRjyEpGrVywrp7Dlby798Rqk1CGFWKJil5HqmK8J83Pk I+5j9cBDwBlhleIGqKZ0a4TpKxcCa/3lhtrb9Y5CD97u1e7tkOsQTSetclCds1/HKFxh og6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=30BxzCXgYLHz0+4BivwlBRzASIe5P5DlLgygcxswRXE=; b=KaPqoWFJJxoFI7Kjirl1560ZsXD2xh52HZn8OzMNzHAvKiIxLSpvZbf4NrbwXPerFN wuYEPycMv5+2E117Cmjne+kVLeg/gyBZwLswVkNz8VUpoqYwR5Cwuve933uCpWbNhC8M PW5rJFZMtXKynhRqx3pIb2OGNezu1u4tLXZxV/maR9Z9BH6LWTFzzQCjo1g+o8rMJpHo RMiEYPI5S6N/+OU1zcxUVxmLxm0WKLd0tVTbPLF+LMhu4+FOWFMMfVOswTlV8ZrqOo4P gzDmeKX+mZ2FK+AGdd0DTpblYGl1gGnaAdTaaMZK4FBlbUwyI2/RPCgsBkal/yWkaV98 mS2Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id m16si607346edv.2.2019.08.26.01.40.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Aug 2019 01:40:53 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x7Q8eq63014905 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 26 Aug 2019 10:40:52 +0200 Received: from [139.22.35.99] ([139.22.35.99]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x7Q8ep11025950; Mon, 26 Aug 2019 10:40:52 +0200 Subject: Re: [PATCH 18/26] image: Stop changing PF, tune WORKDIR and STAMP directly To: Henning Schild Cc: isar-users References: <20190826103504.59d689bd@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: Date: Mon, 26 Aug 2019 10:40:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190826103504.59d689bd@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: ho1NhXAtSX0Y On 26.08.19 10:35, Henning Schild wrote: > Am Mon, 26 Aug 2019 08:26:19 +0200 > schrieb "[ext] Jan Kiszka" : > >> From: Jan Kiszka >> >> This removes the last fiddling with PF, addressing the issue - a >> common image PN name for multiconfig targets while the results are >> actually machine-specific - by tuning the critical paths directly. >> This are just WORKDIR as well as STAMP and STAMPCLEAN. >> >> Signed-off-by: Jan Kiszka >> --- >> meta/classes/image.bbclass | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass >> index ec6bd39..36e9875 100644 >> --- a/meta/classes/image.bbclass >> +++ b/meta/classes/image.bbclass >> @@ -1,7 +1,10 @@ >> # This software is a part of ISAR. >> # Copyright (C) 2015-2017 ilbers GmbH >> >> -PF = "${PN}-${DISTRO}-${MACHINE}" >> +# Make workdir and stamps machine-specific without changing common >> PN target +WORKDIR .= "-${MACHINE}" >> +STAMP = >> "${STAMPS_DIR}/${DISTRO}-${DISTRO_ARCH}/${PN}-${MACHINE}/${PV}-${PR}" > > .../${PF} ? Nope, that's already included in PN, PV and PR. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux