public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "MOESSBAUER, Felix" <felix.moessbauer@siemens.com>
To: "Prusty, Badrikesh" <badrikesh.prusty@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: Re: [PATCH] nanopi-neo.wks.in: use partition uuid instead of providing mmcblk2 disk
Date: Mon, 27 Nov 2023 09:22:45 +0000	[thread overview]
Message-ID: <f1b1827d74ab8e5053b484fc55b4c724bf518ccc.camel@siemens.com> (raw)
In-Reply-To: <9ed33d28-4442-480d-aa3c-0d68d216905en@googlegroups.com>

On Sun, 2023-11-26 at 12:09 -0800, 'Badrikesh' via isar-users wrote:
> Observing boot failure on nanopi, if booted from external sd-card
> From FriendlyElec documentation, mmcblk2 is used as internal emmc,
> while mmcblk0 is used for external sd-card.
> Some nanopi's doesn't support emmc, instead uses ext sd for booting
> With this change it will allow booting from external sd-card. Also,
> the image can be copied to emmc to boot from emmc as well

Hi Badrikesh,

thanks for this fix. I also wanted to send it, but you were faster.
Once merged, the following issue can be closed:
https://github.com/ilbers/isar/issues/100

Acked-by: Felix Moessbauer <felix.moessbauer@siemens.com>

Happy Coding!
Felix

> 
> Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> ---
>  meta-isar/scripts/lib/wic/canned-wks/nanopi-neo.wks.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-isar/scripts/lib/wic/canned-wks/nanopi-neo.wks.in
> b/meta-isar/scripts/lib/wic/canned-wks/nanopi-neo.wks.in
> index af5b6f08..9489bd12 100644
> --- a/meta-isar/scripts/lib/wic/canned-wks/nanopi-neo.wks.in
> +++ b/meta-isar/scripts/lib/wic/canned-wks/nanopi-neo.wks.in
> @@ -5,6 +5,6 @@
> 
>  part u-boot --source rawcopy --sourceparams "file=/usr/lib/u-
> boot/nanopi_neo/u-boot-sunxi-with-spl.bin" --no-table --align 8
> 
> -part / --source rootfs-u-boot --ondisk mmcblk2 --fstype ext4 --mkfs-
> extraopts "-T default" --sourceparams "builtin_dt=yes" --label
> platform --align 1024 --active
> +part / --source rootfs-u-boot --use-uuid --fstype ext4 --mkfs-
> extraopts "-T default" --sourceparams "builtin_dt=yes" --label
> platform --align 1024 --active
> 
>  bootloader --append "rw rootwait"
> --
> 2.39.2


  reply	other threads:[~2023-11-27  9:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-26 20:09 Badrikesh
2023-11-27  9:22 ` MOESSBAUER, Felix [this message]
2023-11-27 15:12   ` [PATCH] nanopi-neo: Use partition uuid instead of particular disk Badrikesh Prusty
2023-11-27 17:12     ` Badrikesh Prusty
2023-11-30 14:35     ` Uladzimir Bely
2023-11-27 10:24 ` [PATCH] nanopi-neo.wks.in: use partition uuid instead of providing mmcblk2 disk Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1b1827d74ab8e5053b484fc55b4c724bf518ccc.camel@siemens.com \
    --to=felix.moessbauer@siemens.com \
    --cc=badrikesh.prusty@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox