From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6617812835611181056 Date: Tue, 30 Oct 2018 23:51:57 -0700 (PDT) From: chombourger@gmail.com To: isar-users Message-Id: In-Reply-To: <57847f7a-9b85-65ef-b11e-8952bf532e0f@siemens.com> References: <20181030134154.7adc8bf9@md1pvb1c.ad001.siemens.net> <20181031061025.28840-1-Cedric_Hombourger@mentor.com> <57847f7a-9b85-65ef-b11e-8952bf532e0f@siemens.com> Subject: Re: [PATCH v2 0/2] introduce isar-image class MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_275_869479326.1540968717574" X-Google-Token: EI2i5d4F1ZMZEo59d8A0 X-Google-IP: 192.94.31.2 X-TUID: h7w/mCmJnnJb ------=_Part_275_869479326.1540968717574 Content-Type: multipart/alternative; boundary="----=_Part_276_983905842.1540968717574" ------=_Part_276_983905842.1540968717574 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Wednesday, October 31, 2018 at 7:39:14 AM UTC+1, Jan Kiszka wrote: > > Before we move things in meta-isar around: I'd like to first of all get > rid of > the dependency on meta-isar for building typical images. Everything that > is not > of demonstration purpose (specific boards, example recipes etc.) should go > to > the core layer (meta). Therefore, we should not introduce further generic > classes to meta-isar. > Hi Jan, That's great to know, I was wondering if we had some guidelines on what should go to meta vs meta-isar We will probably need to document this somewhere and introduce some mechanisms to have our CI jobs check if isar/meta is buildable without isar/meta-isar In the short term, I can amend the patch series to move the class to isar/meta I believe we could also place isar-image-base there but leave isar-image-debug in isar/meta-isar since the definition of a debug image we have there appears to be just an example What do you think? Thanks Cedric ------=_Part_276_983905842.1540968717574 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable


On Wednesday, October 31, 2018 at 7:39:14 AM UTC+1= , Jan Kiszka wrote:
Before we m= ove things in meta-isar around: I'd like to first of all get rid of=20
the dependency on meta-isar for building typical images. Everything tha= t is not=20
of demonstration purpose (specific boards, example recipes etc.) should= go to=20
the core layer (meta). Therefore, we should not introduce further gener= ic=20
classes to meta-isar.=C2=A0

Hi Jan,=

That's great to know, I was wondering if we h= ad some guidelines on what should go to meta vs meta-isar
We will= probably need to document this somewhere and introduce some mechanisms to = have our CI jobs check if isar/meta is buildable without isar/meta-isar

In the short term, I can amend the patch series to mo= ve the class to isar/meta
I believe we could also place isar-imag= e-base there but leave isar-image-debug in isar/meta-isar since the definit= ion of a debug image we have there appears to be just an example
= What do you think?

Thanks
Cedric=C2=A0
------=_Part_276_983905842.1540968717574-- ------=_Part_275_869479326.1540968717574--