From: "florian.bezdeka@siemens.com" <florian.bezdeka@siemens.com>
To: "quirin.gylstorff@siemens.com" <quirin.gylstorff@siemens.com>,
"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: Re: [PATCH] sshd-regen-keys: do not enable ssh server if previously disabled
Date: Wed, 24 Feb 2021 13:45:48 +0000 [thread overview]
Message-ID: <f1eabb59e9ba50e505da28fcb85a88a35aa2bdae.camel@siemens.com> (raw)
In-Reply-To: <20210224133242.30108-1-Quirin.Gylstorff@siemens.com>
On Wed, 2021-02-24 at 14:32 +0100, [ext] Q. Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>
> The code 'test -n $SSHD_ENABLED' always returns "0" and enables ssh
> even if deactivated previously.
>
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
> meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh
> index 910d879..efcff3e 100644
> --- a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh
> +++ b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh
> @@ -12,7 +12,7 @@ rm -v /etc/ssh/ssh_host_*_key*
> echo "Regenerating keys ..."
> dpkg-reconfigure openssh-server
>
>
>
>
> -if test -n $SSHD_ENABLED; then
> +if [-n "$SSHD_ENABLED" ]; then
Isn't that a syntax error?
- if [-n "$SSHD_ENABLED" ]; then
+ if [ -n "$SSHD_ENABLED" ]; then
> echo "Reenabling ssh server ..."
> systemctl enable --no-reload ssh
> fi
> --
> 2.20.1
>
prev parent reply other threads:[~2021-02-24 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 13:32 Q. Gylstorff
2021-02-24 13:41 ` [PATCH v2] " Q. Gylstorff
2021-02-24 20:26 ` Henning Schild
2021-02-24 20:32 ` Henning Schild
2021-02-25 7:36 ` Gylstorff Quirin
2021-02-24 13:45 ` florian.bezdeka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1eabb59e9ba50e505da28fcb85a88a35aa2bdae.camel@siemens.com \
--to=florian.bezdeka@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=quirin.gylstorff@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox