public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Claudius Heine <claudius.heine.ext@siemens.com>
To: cedric_hombourger@mentor.com, isar-users <isar-users@googlegroups.com>
Subject: Re: IMAGE_TYPE vs IMAGE_TYPE(S)
Date: Mon, 4 Jun 2018 09:17:11 +0200	[thread overview]
Message-ID: <f33a6dc2-9c39-1bc0-7771-fa2b69279b7e@siemens.com> (raw)
In-Reply-To: <45b87a65-2efb-4652-8790-6b5726e1caef@googlegroups.com>

Hi Cedric,

On 2018-06-01 16:40, cedric_hombourger@mentor.com wrote:
> Hello!
> 
> The documentation suggests that IMAGE_TYPE may be a list of images to be
> built:
> 
>     | The `IMAGE_TYPE` variable contains the list of image types to generate.
> 
> (ref: https://github.com/ilbers/isar/blob/master/doc/user_manual.md#image-type-selection)
> 
> It appears that one could set this to e.g. "ext4-img wic-img" to get Isar
> to generate both an EXT4 image and a WIC image.
> Alright.
> 
> But then how about this code:
> 
>     | if d.getVar('IMAGE_TYPE', True) == 'wic-img':
>     |     d.appendVar('BUILDCHROOT_PREINSTALL',
>     |                 d.getVar('BUILDCHROOT_PREINSTALL_WIC', True))
> 
> (ref: https://github.com/ilbers/isar/blob/master/meta/recipes-devtools/buildchroot/buildchroot.bb#L45)
> 
> The condition would be False for the example provided above and our
> buildchroot missing vital tools such mkdosfs
> 
> We probably need to fix one or the other. What are your thoughts?

I knew that building multiple image wasn't possible, but I wasn't aware 
it was documented otherwise. Thanks for making us aware of this.

Personally, I would like to have the ability to build multiple images, 
because that would put us a bit more on par with OE.

Also I already thought about exactly your quoted part of the code. IMO 
that cries for some refactoring anyway. Maybe we could use the overwrite 
bitbake syntax for this.

I don't know when I will find time to tackle this. There a just so many 
things to do everywhere ;). So up for grabs IMO.

Cheers,
Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

      parent reply	other threads:[~2018-06-04  7:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 14:40 cedric_hombourger
2018-06-04  7:16 ` Jan Kiszka
2018-06-04  8:27   ` Henning Schild
2018-06-04  7:17 ` Claudius Heine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f33a6dc2-9c39-1bc0-7771-fa2b69279b7e@siemens.com \
    --to=claudius.heine.ext@siemens.com \
    --cc=cedric_hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox