From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6562126013157867520 X-Received: by 2002:adf:e5c3:: with SMTP id a3-v6mr1418521wrn.19.1528096632279; Mon, 04 Jun 2018 00:17:12 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:4345:: with SMTP id u5-v6ls480238wrr.1.gmail; Mon, 04 Jun 2018 00:17:11 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKltWbSrQePTIPikexVvhX5ojEAxJkcLPFgcaF+khq1for3EFa5lDV7uXAUmoBCzhnw6tq4 X-Received: by 2002:adf:fec9:: with SMTP id q9-v6mr341061wrs.30.1528096631920; Mon, 04 Jun 2018 00:17:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528096631; cv=none; d=google.com; s=arc-20160816; b=bWO3TXD4773Z90vJwZgh01Zn8WlmPyRx5yt4v1fnOSzRL08lffdsIlVNr2oFOeu5JV K6nzNXMphQsOp+t2F7gpNSDX6B8qDw3Kk3SGGnNmJKE3sfz/y3pJ3d0c7zZsoyN5un/C aS7O8256fOkn3y4K9C7eNh2HutONKdRBldtJE5JjcbIEJ1JcSqd7OXZ/6m4jvLwNnMqK s6O7NNr+5ColvudR/huJ4JyoZHLTf7BhJcvS+8Lvz1bhD7r7m1O5WY7v55kU6ozCF6r8 Ju6oNJVnc8x9DfzxhEOsxcW+Kq31QrqHCji/CyRYJVdkrIpDAXvnJdsHYU1NoEmZ8yyJ 5CLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=eiKcG0E45rXRFuh82Gbg5/dhn/VIceGYqJXaq5tX/GY=; b=pxlWFdTjv8k3A1ptx8YYlIhEBolUIzzswAbhKFGNBVVpj5CHc563ZBFT4Tn8chfENj lmD0zUIiVez5g9IGVFUgjG66sQ73+tYg0KBZO0JrHpE6EPamBSWiR23AmQ9V2PUkWFjE SprFs/7kJzRBXVHa8OfJASMfiYFzfwZAPFZKOFWsz6CcrvYKIYntJjY8vjv/P6sJw+jb kIf4rTxMNHUxIUBBF+uRP4CLTBo/iJibnpkcTa9RSh35hcVkO0ZpPYaeY1Ktekecbtxw G7IYWG43QFmUdSY96aLsv1Yn/f2aUFscIXLHBR8zQFjxeTn9PeL99t8Z2m0eZJjWaK9A WWtg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id r7-v6si400422wmc.0.2018.06.04.00.17.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 00:17:11 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w547HBcM011258 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Jun 2018 09:17:11 +0200 Received: from [139.25.69.69] (linux-ses-ext02.ppmd.siemens.net [139.25.69.69]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w547HBV3021296; Mon, 4 Jun 2018 09:17:11 +0200 Subject: Re: IMAGE_TYPE vs IMAGE_TYPE(S) To: cedric_hombourger@mentor.com, isar-users References: <45b87a65-2efb-4652-8790-6b5726e1caef@googlegroups.com> From: Claudius Heine Message-ID: Date: Mon, 4 Jun 2018 09:17:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <45b87a65-2efb-4652-8790-6b5726e1caef@googlegroups.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 0KGw/koRVVXr Hi Cedric, On 2018-06-01 16:40, cedric_hombourger@mentor.com wrote: > Hello! > > The documentation suggests that IMAGE_TYPE may be a list of images to be > built: > > | The `IMAGE_TYPE` variable contains the list of image types to generate. > > (ref: https://github.com/ilbers/isar/blob/master/doc/user_manual.md#image-type-selection) > > It appears that one could set this to e.g. "ext4-img wic-img" to get Isar > to generate both an EXT4 image and a WIC image. > Alright. > > But then how about this code: > > | if d.getVar('IMAGE_TYPE', True) == 'wic-img': > | d.appendVar('BUILDCHROOT_PREINSTALL', > | d.getVar('BUILDCHROOT_PREINSTALL_WIC', True)) > > (ref: https://github.com/ilbers/isar/blob/master/meta/recipes-devtools/buildchroot/buildchroot.bb#L45) > > The condition would be False for the example provided above and our > buildchroot missing vital tools such mkdosfs > > We probably need to fix one or the other. What are your thoughts? I knew that building multiple image wasn't possible, but I wasn't aware it was documented otherwise. Thanks for making us aware of this. Personally, I would like to have the ability to build multiple images, because that would put us a bit more on par with OE. Also I already thought about exactly your quoted part of the code. IMO that cries for some refactoring anyway. Maybe we could use the overwrite bitbake syntax for this. I don't know when I will find time to tackle this. There a just so many things to do everywhere ;). So up for grabs IMO. Cheers, Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de