From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Schmidt,
Adriaan (T RDA IOT SES-DE)" <adriaan.schmidt@siemens.com>,
"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: Re: [PATCH v2 03/10] rootfs: recursively depend on packages
Date: Wed, 13 Oct 2021 17:09:01 +0200 [thread overview]
Message-ID: <f3c990bc-99ac-015d-8618-d9d875b895e3@siemens.com> (raw)
In-Reply-To: <AM4PR1001MB12204FB866B118670812C3FAEDB79@AM4PR1001MB1220.EURPRD10.PROD.OUTLOOK.COM>
On 13.10.21 16:43, Schmidt, Adriaan (T RDA IOT SES-DE) wrote:
>> On 12.10.21 14:36, Adriaan Schmidt wrote:
>>> This fixes a bug.
>>> So far, this only worked when the dependency-of-dependency packages
>>> were in isar-apt because they were just built. This explicitly
>>> enforces do_deploy_deb on *all* dependencies.
>>
>> More curiosity: I'm not yet understanding the error scenario. A rootfs
>> depends on a package recipe A, and that means on the completion of that
>> recipe's do_deploy_deb task. If that recipe A depends on another package
>> recipe B that one needs to be in isar-apt, thus has to finish its
>> do_deploy_deb as well. But why could A have finished its build when B didn't
>> even run do_deploy_deb yet? If A depends on B, it also depends on B's
>> do_deploy_deb task, no?
>
> The rootfs depends on A's do_deploy_deb, but only A's do_prepare_build depends on B's do_deploy_deb.
> If we can produce A (do_deploy_deb) from cache without running its do_prepare_build, then B might not be there (which is exactly what happened to me).
>
OK, this issue only surfaces once you introduce caching. Without
caching, it's impossible to complete do_deploy_deb (or do_prepare_build)
without all dependencies' do_deploy_deb.
> Thinking about it I'm wondering if the same thing can happen when building a package, and if actually also do_prepare_build in dpkg-base needs to define recrdeptask instead of its current `do_prepare_build[deptask] = "do_deploy_deb"`?
Conceptually, yes, same scenario, just different root.
How does OE handle such cases? I bet there can be more.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2021-10-13 15:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 12:36 [PATCH v2 00/10] Add sstate-cache Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 01/10] oe imports in central location Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 02/10] wic-img: create deploy dir Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 03/10] rootfs: recursively depend on packages Adriaan Schmidt
2021-10-13 14:29 ` Jan Kiszka
2021-10-13 14:43 ` Schmidt, Adriaan
2021-10-13 15:09 ` Jan Kiszka [this message]
2021-10-13 15:18 ` Schmidt, Adriaan
2021-10-13 16:01 ` Jan Kiszka
2021-10-19 8:10 ` Schmidt, Adriaan
2021-10-12 12:36 ` [PATCH v2 04/10] base: remove unneeded "before do_build" task dependencies Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 05/10] dpkg: add explicit dependency to isar-apt Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 06/10] meta: add sstate feature from oe Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 07/10] sstate: configure Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 08/10] sstate: add caching to isar-bootstrap Adriaan Schmidt
2021-10-13 14:17 ` Anton Mikanovich
2021-10-19 8:11 ` Schmidt, Adriaan
2021-10-12 12:36 ` [PATCH v2 09/10] sstate: add caching to rootfs Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 10/10] sstate: add caching to debian packages Adriaan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3c990bc-99ac-015d-8618-d9d875b895e3@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=adriaan.schmidt@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox