From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6671974161673355264 X-Received: by 2002:a5d:6b0d:: with SMTP id v13mr18332275wrw.284.1553540857786; Mon, 25 Mar 2019 12:07:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:f8c6:: with SMTP id f6ls7906wrq.11.gmail; Mon, 25 Mar 2019 12:07:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqx9UYNhsa3dsTlqXPbPqMKh53/LydmaKWAidvKvYz0SsQuURPNu48UbMT6OJuR7VnH+031/ X-Received: by 2002:adf:f3ce:: with SMTP id g14mr17657723wrp.129.1553540857313; Mon, 25 Mar 2019 12:07:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553540857; cv=none; d=google.com; s=arc-20160816; b=O3BOZslYPQrr4miW4uQIQ7tk9jCU+8OMV6ouCDPLb6Gq5/+SjCXhwBMiqeL3g3zNLD w15p5CSASZ+rDeEEm9zej2kqha/DgeUpk041W9ln5Cm6HtKsOCoQ9Indj4ky2/1QvB7Y U0rDZxm8sgfgyrkhUzNeUSaTcvhJueJAg3WryYSahvbg/3QBFEOoBtuP7BwBbMni8cA3 o5EgOLGck2EhJUEGnn42KWWqIxoU9dB/uB0VtfBQNpWIuWINxFs3sfuNYiCc4HgsIk/b OvsJHuqn/CT6xSmZ3EjZIQxWFchmOE0+iGqMxT9oo65c+NtW/bkCjKRbYI7pTEWRmvEK sKMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=/raD1dGAXapqSa/PcW22e/j7yG3tbxzh9riR/fym2DM=; b=msVuorwp4xo2cc0SZnsbpUDbiRAO7pMwqUFyWAPslhwSaW6I7S/hr34txw90ISuVCl 81TmoQkNMV15FlHpvnnJ9rMuKLchGq+teaFxTWhQo4YsL0XyahLC8tZkkznjxoaLdtox v6vXhC++fbUsw1fIlQkdDglsBbze5Q2AAMGaY3FYeAeh3Ny4QdeC7nyHFlFxjfilW1qF tx8ohgwV9LN8tIGqkOi+dE3iDWi7AtDl8TcqI5LDEh7v2aW4I1VUhRQR6xW6UakwuZY2 98X7iWq2GOfiIV8FgwHSGcC8mYXqkczGYdXEkoJiFGnctEdEJTfEpw7pSArgdm5KgANK mlrA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 7si811239wma.1.2019.03.25.12.07.37 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Mar 2019 12:07:37 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.164] (d51A48A80.access.telenet.be [81.164.138.128]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x2PJ7ZVT019939 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Mar 2019 20:07:36 +0100 Subject: Re: [PATCH] dpkg: Beautify runbuild To: Jan Kiszka , isar-users Cc: Cedric Hombourger References: <75befabe-76f0-7750-a1bf-3c2c3dbd2b22@web.de> <662125e4-f136-45c6-db81-c93638e58578@web.de> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: Date: Mon, 25 Mar 2019 20:07:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <662125e4-f136-45c6-db81-c93638e58578@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: 0nUZFhDa1LWw Applied to the 'next'. Thanks, Maxim. On 3/25/19 2:40 PM, Jan Kiszka wrote: > On 25.03.19 14:19, Maxim Yu. Osipov wrote: >> On 3/24/19 4:07 PM, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> Properly indent so that it becomes clearer that chroot runs under a >>> lock. Also avoid overlong lines. >> >> I've tried to apply the patch against the current 'next' and git am failed: >> >> git am ../patches/\[PATCH\]\ dpkg\:\ Beautify\ runbuild.eml >> Applying: dpkg: Beautify runbuild >> error: corrupt patch at line 18 >> Patch failed at 0001 dpkg: Beautify runbuild >> > > Sorry, forgot to disable line wrapping: > > ---8<--- > > From: Jan Kiszka > > dpkg: Beautify runbuild > > Properly indent so that it becomes clearer that chroot runs under a > lock. Also avoid overlong lines. > Signed-off-by: Jan Kiszka > --- > meta/classes/dpkg.bbclass | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index f4e3d7a..997f2f3 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -20,5 +20,6 @@ do_install_builddeps[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > dpkg_runbuild() { > E="${@ bb.utils.export_proxies(d)}" > flock -s "${REPO_ISAR_DIR}/isar.lock" \ > - sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH} > + sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} \ > + /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH} > } > -- > 2.16.4 > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov