* [PATCH] dpkg: Beautify runbuild
@ 2019-03-24 15:07 Jan Kiszka
2019-03-25 13:19 ` Maxim Yu. Osipov
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2019-03-24 15:07 UTC (permalink / raw)
To: isar-users; +Cc: Cedric Hombourger
From: Jan Kiszka <jan.kiszka@siemens.com>
Properly indent so that it becomes clearer that chroot runs under a
lock. Also avoid overlong lines.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
Looked at it while trying to understand why jailhouse-images started to
serialize jobs massively. The reason is simple: If you have one package with a
heavy-weight build, every other packages that didn't finish its
install_builddeps or even apt_fetch before that build starts will now wait for
the fat guy. This is fairly suboptimal. I guess the best answer to that is to
avoid the sharing: per package buildchroots. A topic for the next release...
meta/classes/dpkg.bbclass | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index f4e3d7a..997f2f3 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -20,5 +20,6 @@ do_install_builddeps[stamp-extra-info] =
"${DISTRO}-${DISTRO_ARCH}"
dpkg_runbuild() {
E="${@ bb.utils.export_proxies(d)}"
flock -s "${REPO_ISAR_DIR}/isar.lock" \
- sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR}
/isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH}
+ sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} \
+ /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH}
}
--
2.16.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dpkg: Beautify runbuild
2019-03-24 15:07 [PATCH] dpkg: Beautify runbuild Jan Kiszka
@ 2019-03-25 13:19 ` Maxim Yu. Osipov
2019-03-25 13:40 ` Jan Kiszka
0 siblings, 1 reply; 4+ messages in thread
From: Maxim Yu. Osipov @ 2019-03-25 13:19 UTC (permalink / raw)
To: Jan Kiszka, isar-users; +Cc: Cedric Hombourger
On 3/24/19 4:07 PM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Properly indent so that it becomes clearer that chroot runs under a
> lock. Also avoid overlong lines.
I've tried to apply the patch against the current 'next' and git am failed:
git am ../patches/\[PATCH\]\ dpkg\:\ Beautify\ runbuild.eml
Applying: dpkg: Beautify runbuild
error: corrupt patch at line 18
Patch failed at 0001 dpkg: Beautify runbuild
Maxim.
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> Looked at it while trying to understand why jailhouse-images started to
> serialize jobs massively. The reason is simple: If you have one package with a
> heavy-weight build, every other packages that didn't finish its
> install_builddeps or even apt_fetch before that build starts will now wait for
> the fat guy. This is fairly suboptimal. I guess the best answer to that is to
> avoid the sharing: per package buildchroots. A topic for the next release...
>
> meta/classes/dpkg.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index f4e3d7a..997f2f3 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -20,5 +20,6 @@ do_install_builddeps[stamp-extra-info] =
> "${DISTRO}-${DISTRO_ARCH}"
> dpkg_runbuild() {
> E="${@ bb.utils.export_proxies(d)}"
> flock -s "${REPO_ISAR_DIR}/isar.lock" \
> - sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR}
> /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH}
> + sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} \
> + /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH}
> }
> --
> 2.16.4
>
--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dpkg: Beautify runbuild
2019-03-25 13:19 ` Maxim Yu. Osipov
@ 2019-03-25 13:40 ` Jan Kiszka
2019-03-25 19:07 ` Maxim Yu. Osipov
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2019-03-25 13:40 UTC (permalink / raw)
To: Maxim Yu. Osipov, isar-users; +Cc: Cedric Hombourger
On 25.03.19 14:19, Maxim Yu. Osipov wrote:
> On 3/24/19 4:07 PM, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Properly indent so that it becomes clearer that chroot runs under a
>> lock. Also avoid overlong lines.
>
> I've tried to apply the patch against the current 'next' and git am failed:
>
> git am ../patches/\[PATCH\]\ dpkg\:\ Beautify\ runbuild.eml
> Applying: dpkg: Beautify runbuild
> error: corrupt patch at line 18
> Patch failed at 0001 dpkg: Beautify runbuild
>
Sorry, forgot to disable line wrapping:
---8<---
From: Jan Kiszka <jan.kiszka@siemens.com>
dpkg: Beautify runbuild
Properly indent so that it becomes clearer that chroot runs under a
lock. Also avoid overlong lines.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
meta/classes/dpkg.bbclass | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index f4e3d7a..997f2f3 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -20,5 +20,6 @@ do_install_builddeps[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
dpkg_runbuild() {
E="${@ bb.utils.export_proxies(d)}"
flock -s "${REPO_ISAR_DIR}/isar.lock" \
- sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH}
+ sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} \
+ /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH}
}
--
2.16.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dpkg: Beautify runbuild
2019-03-25 13:40 ` Jan Kiszka
@ 2019-03-25 19:07 ` Maxim Yu. Osipov
0 siblings, 0 replies; 4+ messages in thread
From: Maxim Yu. Osipov @ 2019-03-25 19:07 UTC (permalink / raw)
To: Jan Kiszka, isar-users; +Cc: Cedric Hombourger
Applied to the 'next'.
Thanks,
Maxim.
On 3/25/19 2:40 PM, Jan Kiszka wrote:
> On 25.03.19 14:19, Maxim Yu. Osipov wrote:
>> On 3/24/19 4:07 PM, Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> Properly indent so that it becomes clearer that chroot runs under a
>>> lock. Also avoid overlong lines.
>>
>> I've tried to apply the patch against the current 'next' and git am failed:
>>
>> git am ../patches/\[PATCH\]\ dpkg\:\ Beautify\ runbuild.eml
>> Applying: dpkg: Beautify runbuild
>> error: corrupt patch at line 18
>> Patch failed at 0001 dpkg: Beautify runbuild
>>
>
> Sorry, forgot to disable line wrapping:
>
> ---8<---
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> dpkg: Beautify runbuild
>
> Properly indent so that it becomes clearer that chroot runs under a
> lock. Also avoid overlong lines.
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> meta/classes/dpkg.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index f4e3d7a..997f2f3 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -20,5 +20,6 @@ do_install_builddeps[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
> dpkg_runbuild() {
> E="${@ bb.utils.export_proxies(d)}"
> flock -s "${REPO_ISAR_DIR}/isar.lock" \
> - sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH}
> + sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} \
> + /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH}
> }
> --
> 2.16.4
>
--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-25 19:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-24 15:07 [PATCH] dpkg: Beautify runbuild Jan Kiszka
2019-03-25 13:19 ` Maxim Yu. Osipov
2019-03-25 13:40 ` Jan Kiszka
2019-03-25 19:07 ` Maxim Yu. Osipov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox