From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6671974161673355264 X-Received: by 2002:a1c:40c:: with SMTP id 12mr11623084wme.3.1553519965374; Mon, 25 Mar 2019 06:19:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:fc87:: with SMTP id g7ls80738wrr.4.gmail; Mon, 25 Mar 2019 06:19:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqxntzhPU4mpbybR1y9txRzbicqzKZw+jkkBJ7nvFwugSZWpGkNOBDlYOvmUeK5hzfEJNWaM X-Received: by 2002:a05:6000:120c:: with SMTP id e12mr2016315wrx.187.1553519964817; Mon, 25 Mar 2019 06:19:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553519964; cv=none; d=google.com; s=arc-20160816; b=1JtDd8DJaRnVkZQXNVp+TsPKhpfm3zHLdauutXGLBDQSYk92uUyaalqWFSKXCkx+Km gn1qmiN9IMm+IwS67SUByZQWrZ3zsG64NNjBmBdTitJGX7YRw0p1wfFVmSD1qwPUUaIm 3wIL7S9q7w+DmhDiHSAoNEAWHLRQLBHrMBpTzINAi1L42M3KLuZuP+tPjZJie6wQvUmG MPz/0ebBZjA3NWA/LUz1xeWj023YxMJl9ztjH0QL5xVFol3GP6jtGpwarKag/9bmT+DR JeQRb0raAIt97aE8jbIIAbRmkzIPGYfjTzgdzEQUZOMNMlYi54jJjVM04XpDVU1WV8cR xmTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=cFEP9AznvPtd9ULNM3/VfCoCsRzosSDK4uFVwUFr5p8=; b=1CqNEaQthQzZlJKUGTq0BxOW1BtDQAPcUnetzo1mOI4UZUzCAGHpYO42I68YWRPBpJ cGjRnRZg+gUBo74ZwUVCbIgRA/ZT/f/2buSYt8mxQpPhI2XSQOUh2bPD6LbhfNy4NuVs m1qFx/t6r/6P9QcWCxS5sgRAd0ky4uCm9l52B873rI04sN2caPnEeJztW9l2oM0zOlCL dCV4KgsaBG4TG10oJEP8gW5bxt5SLeotjE5cxk9DCVOmMakKHf62YiNorFBnqe4WrW6J z+n+li5YbpnQUBjpHl3ft8K3IQLma2Wv3YMiXfXOn6/GPYz9EZe2Yr8UTzV0hX7sbMwH FvtA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 7si771004wma.1.2019.03.25.06.19.24 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Mar 2019 06:19:24 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.164] (d51a48a80.access.telenet.be [81.164.138.128]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x2PDJNel018095 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Mar 2019 14:19:23 +0100 Subject: Re: [PATCH] dpkg: Beautify runbuild To: Jan Kiszka , isar-users Cc: Cedric Hombourger References: <75befabe-76f0-7750-a1bf-3c2c3dbd2b22@web.de> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: Date: Mon, 25 Mar 2019 14:19:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <75befabe-76f0-7750-a1bf-3c2c3dbd2b22@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: BJCeTY6N9rxs On 3/24/19 4:07 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Properly indent so that it becomes clearer that chroot runs under a > lock. Also avoid overlong lines. I've tried to apply the patch against the current 'next' and git am failed: git am ../patches/\[PATCH\]\ dpkg\:\ Beautify\ runbuild.eml Applying: dpkg: Beautify runbuild error: corrupt patch at line 18 Patch failed at 0001 dpkg: Beautify runbuild Maxim. > Signed-off-by: Jan Kiszka > --- > > Looked at it while trying to understand why jailhouse-images started to > serialize jobs massively. The reason is simple: If you have one package with a > heavy-weight build, every other packages that didn't finish its > install_builddeps or even apt_fetch before that build starts will now wait for > the fat guy. This is fairly suboptimal. I guess the best answer to that is to > avoid the sharing: per package buildchroots. A topic for the next release... > > meta/classes/dpkg.bbclass | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index f4e3d7a..997f2f3 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -20,5 +20,6 @@ do_install_builddeps[stamp-extra-info] = > "${DISTRO}-${DISTRO_ARCH}" > dpkg_runbuild() { > E="${@ bb.utils.export_proxies(d)}" > flock -s "${REPO_ISAR_DIR}/isar.lock" \ > - sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} > /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH} > + sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} \ > + /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH} > } > -- > 2.16.4 > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov